: REPOST cleanup debug message in init_kstat_irqs()
A message that is not in the archive (sent off-list or not yet received): [email protected]
Whoops... Subject should have been REPOST cleanup debug message in irq_to_desc_alloc_node()
Sorry 'bout that.
P.
Quoted 33 lines · Prarit Bhargava
[Sending to a wider audience this time, cc'ing Andrew and Ingo directly]
Clean up debug messages in
irq_to_desc_alloc_node().This debug message can result in valid output like
alloc
irq_descfor 73 on node -1which looks like alot like an error message.
This debug statement has been in the kernel for about a year, so I think it is safe to remove it and report the irq and node in the error case instead.
Signed-off-by Prarit Bhargava <[email protected]>kernel/irq/handle.c +3
-2@@ -224,9 +224,10 @@ struct irq_desc * __ref irq_to_desc_alloc_node(unsigned int irq, int node)else desc =alloc_bootmem_node (NODE_DATA (node),sizeof (*desc)); -printk (KERN_DEBUG " alloc irq_desc for %d on node %d\n" , irq, node);if (!desc) { -printk (KERN_ERR "can not alloc irq_desc\n" ); +printk (KERN_ERR +"can not alloc irq_desc for irq %d on node %d\n" , + irq, node);BUG_ON (1 ); }init_one_irq_desc (irq, desc, node);