Skip to contentSkip to conversation

Let check_preimage() use memset() to initialize "struct checkout"

PATCH New Jens Lehmann 1 participant 1 message Jun 15, 2016

lore
Share & tools
lore

Jens Lehmann

author
#0 lore raw

PATCH 1/1 Let check_preimage() use memset() to initialize "struct checkout"

Every code site except check_preimage() uses either memset() or declares a static instance of "struct checkout" to achieve proper initialization. Lets use memset() instead of explicit initialization of all members here too to be on the safe side in case this structure is expanded someday.

Signed-off-by Jens Lehmann <[email protected]>

---

 builtin/apply.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)
builtin/apply.c +1 -4
index ec755ac..d56cabf 100644
@@ -2821,11 +2821,8 @@ static int check_preimage(struct patch *patch, struct cache_entry **ce, struct s
 		if (stat_ret < 0) {
 			struct checkout costate;
 			/* checkout */
+			memset(&costate, 0, sizeof(costate));
 			costate.base_dir = "";
-			costate.base_dir_len = 0;
-			costate.force = 0;
-			costate.quiet = 0;
-			costate.not_new = 0;
 			costate.refresh_cache = 1;
 			if (checkout_entry(*ce, &costate, NULL) ||
 			    lstat(old_name, st))
Signature · 1 line
1.7.0.3.517.g0017