Skip to contentSkip to conversation

libxl: make set_memory_target work on domains with no videoram

PATCH In review Jeremy Fitzhardinge 2 participants 2 messages Apr 30, 2010 – May 1, 2010

lore
Share & tools
lore

Jeremy Fitzhardinge

author
#0 lore raw

PATCH 1/1 libxl: make set_memory_target work on domains with no videoram

If a domain has no videoram (say, dom0), then treat the size as 0 and continue, rather than just failing.

Signed-off-by Jeremy Fitzhardinge <[email protected]>
tools/libxl/libxl.c +4 -3
diff -r 0ea790d96997 tools/libxl/libxl.c
@@ -2292,9 +2292,10 @@
     char *dompath = libxl_xs_get_dompath(ctx, domid);
 
     videoram_s = libxl_xs_read(ctx, XBT_NULL, libxl_sprintf(ctx, "%s/memory/videoram", dompath));
-    if (!videoram_s)
-        return -1;
-    videoram = atoi(videoram_s);
+    if (videoram_s)
+      videoram = atoi(videoram_s);
+    else
+      videoram = 0;
 
     libxl_xs_write(ctx, XBT_NULL, libxl_sprintf(ctx, "%s/memory/target", dompath), "%lu", target_memkb);
     rc = xc_domain_setmaxmem(ctx->xch, domid, target_memkb + LIBXL_MAXMEM_CONSTANT);