Skip to contentSkip to conversation

fec.c: Fix memory corruption in fec_set_mac_address.

PATCH New Mattias Walstrom 3 participants 3 messages May 2, 2010 – May 6, 2010 Network drivers

lore
Share & tools
lore

Mattias Walstrom

author
#0 lore raw

PATCH 1/1 fec.c: Fix memory corruption in fec_set_mac_address.

Fix memory corruption that may result in kernel panics.

Signed-off-by Mattias Walstr?m <[email protected]>

fec.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/fec.c +1 -1
index 9f98c1c..9b4e8f7 100644
@@ -1653,7 +1653,7 @@ fec_set_mac_address(struct net_device *dev, void *p)
 		(dev->dev_addr[1] << 16) | (dev->dev_addr[0] << 24),
 		fep->hwp + FEC_ADDR_LOW);
 	writel((dev->dev_addr[5] << 16) | (dev->dev_addr[4] << 24),
-		fep + FEC_ADDR_HIGH);
+		fep->hwp + FEC_ADDR_HIGH);
 	return 0;
 }
#1 lore raw

PATCH 1/1 fec.c: Fix memory corruption in fec_set_mac_address.

Hi Mattias,

Quoted 4 lines · Mattias Walstrom

Fix memory corruption that may result in kernel panics.

Signed-off-by Mattias Walstr?m <[email protected]>

You might want to send this to netdev and make sure to keep the diffstat out of the changelog.

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
#2 lore raw

PATCH 1/1 fec.c: Fix memory corruption in fec_set_mac_address.

Hi Uwe, Mattias,

Quoted 7 lines · Uwe Kleine-K?nig
Quoted 4 lines · Mattias Walstrom

Fix memory corruption that may result in kernel panics.

Signed-off-by Mattias Walstr?m <[email protected]>

You might want to send this to netdev and make sure to keep the diffstat out of the changelog.

This is already applied upstream (7cff0943a).

baruch

Signature · 3 lines
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -