Skip to contentSkip to conversation

apparent key mapping error for usb keyboard

PATCH Michael Tokarev 2 participants 2 messages Apr 27, 2010 – May 4, 2010 KVM

lore
Share & tools
lore
#0 lore raw

I've a debian bugreport that claims to have a fix for apparently wrong keymap for usb keyboard. I noticed this before with ps/2 keyboard too, the sympthoms were that e.g windows keys were not working in guests, but later on that has been fixed. But with `-usbdevice keyboard', i.e. with usb keyboard, it still does not work. See
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=578846
for details and for the proposed patch which fixes the mentioned issue. Here's the patch itself:

hw/usb-hid.c +1 -1
@@ -399,3 +399,3 @@
     0x51, 0x4e, 0x49, 0x4c, 0x00, 0x00, 0x00, 0x00,
-    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+    0x00, 0x00, 0x00, 0xe3, 0xe7, 0x65, 0x00, 0x00,
     0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,

I'm not sure if it's right fix however. Hence I'm asking for opinions here. If it's a right way to go, it should probably be applied to -stable too.

Thanks!

/mjt

#1 lore raw
Quoted 19 lines · Michael Tokarev

I've a debian bugreport that claims to have a fix for apparently wrong keymap for usb keyboard. I noticed this before with ps/2 keyboard too, the sympthoms were that e.g windows keys were not working in guests, but later on that has been fixed. But with `-usbdevice keyboard', i.e. with usb keyboard, it still does not work. See
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=578846
for details and for the proposed patch which fixes the mentioned issue. Here's the patch itself:

hw/usb-hid.c +1 -1
@@ -399,3 +399,3 @@
     0x51, 0x4e, 0x49, 0x4c, 0x00, 0x00, 0x00, 0x00,
-    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+    0x00, 0x00, 0x00, 0xe3, 0xe7, 0x65, 0x00, 0x00,
     0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
Quoted 3 lines

I'm not sure if it's right fix however. Hence I'm asking for opinions here. If it's a right way to go, it should probably be applied to -stable too.

I've no idea, but the correct place to ask is qemu-devel (copied).

Signature · 1 line
error compiling committee.c: too many arguments to function