i915: missing unlock on error path
Subsystems (2)
PATCH 1/1 i915: missing unlock on error path
There was a missing mutex_unlock(&dev->struct_mutex) on this error path.
---
I thought Jiri sent this patch earlier but a google search for "stanse struct_mutex i965_reset" didn't find any patches, so I'm resending.
drivers/gpu/drm/i915/i915_drv.c +1 -0
@@ -369,6 +369,7 @@ int i965_reset(struct drm_device *dev, u8 flags) } }else {DRM_ERROR ("Error occurred. Don't know how to reset this chip.\n" ); +mutex_unlock (&dev->struct_mutex);return -ENODEV ; }
------------------------------------------------------------------------------
--
Quoted 6 lines · Dan Carpenter
There was a missing
mutex_unlock(&dev->struct_mutex)on this error path.Signed-off-by Dan Carpenter <[email protected]>---
I thought Jiri sent this patch earlier but a google search for "stansestruct_mutexi965_reset" didn't find any patches, so I'm resending.
I don't remember either. I found I had only fixed potential NULL-deref in i915_suspend.
Quoted 12 lines
drivers/gpu/drm/i915/i915_drv.c +1
-0@@ -369,6 +369,7 @@ int i965_reset(struct drm_device *dev, u8 flags) } }else {DRM_ERROR ("Error occurred. Don't know how to reset this chip.\n" ); +mutex_unlock (&dev->struct_mutex);return -ENODEV ; }
Signature · 5 lines
js ------------------------------------------------------------------------------ --
Quoted 12 lines · Dan Carpenter
There was a missing
mutex_unlock(&dev->struct_mutex)on this error path.Signed-off-by Dan Carpenter <[email protected]>---
I thought Jiri sent this patch earlier but a google search for "stansestruct_mutexi965_reset" didn't find any patches, so I'm resending.drivers/gpu/drm/i915/i915_drv.c +0
-0
drivers/gpu/drm/i915/i915_drv.c int i965_reset(struct drm_device *dev, u8 flags) · line 375
Quoted 7 lines
drivers/gpu/drm/i915/i915_drv.c +1
-0@@ -369,6 +369,7 @@ int i965_reset(struct drm_device *dev, u8 flags) } }else {DRM_ERROR ("Error occurred. Don't know how to reset this chip.\n" ); +mutex_unlock (&dev->struct_mutex);return -ENODEV ; }
Heh, got another version of this patch from Daniel J Blueman and ended up applying his first as I went through my tag:todo list. Thanks, though!
------------------------------------------------------------------------------
--
_______________________________________________
Dri-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dri-devel