sky2: Avoid race in sky2_change_mtu
Subsystems (2)
PATCH 1/5 sky2: Avoid race in sky2_change_mtu
netif_stop_queue does not ensure all in-progress transmits are complete,
so use netif_tx_disable() instead.
Secondly, make sure NAPI polls are disabled before stopping the tx queue,
otherwise sky2_status_intr might trigger a TX queue wakeup between when we stop the queue and NAPI is disabled.
Signed-off-by Mike McCormack <[email protected]>
--- drivers/net/sky2.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/sky2.c +1 -1
@@ -2236,8 +2236,8 @@ static int sky2_change_mtu(struct net_device *dev, int new_mtu)sky2_write32 (hw,B0_IMSK ,0 ); dev->trans_start = jiffies;/* prevent tx timeout */ -netif_stop_queue (dev);napi_disable (&hw->napi); +netif_tx_disable (dev);synchronize_irq (hw->pdev->irq);
Signature · 1 line
1.5.6.5