Skip to contentSkip to conversation

sky2: Shut off interrupts before NAPI

PATCH New Mike McCormack 1 participant 1 message May 12, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 3/5 sky2: Shut off interrupts before NAPI

Interrupts should be masked, then synchronized, and finally NAPI should be disabled.

---
 drivers/net/sky2.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/sky2.c +2 -2
index 58ae840..04adcee 100644
@@ -3266,10 +3266,10 @@ static void sky2_restart(struct work_struct *work)
 
 	rtnl_lock();
 
-	napi_disable(&hw->napi);
-	synchronize_irq(hw->pdev->irq);
 	imask = sky2_read32(hw, B0_IMSK);
 	sky2_write32(hw, B0_IMSK, 0);
+	synchronize_irq(hw->pdev->irq);
+	napi_disable(&hw->napi);
 
 	for (i = 0; i < hw->ports; i++) {
 		struct net_device *dev = hw->dev[i];
Signature · 1 line
1.5.6.5