Skip to contentSkip to conversation

Watchdog: Adding support for Watchdog found with ARM CortexA9

PATCH RESEND Superseded Viresh KUMAR 3 participants 6 messages May 17, 2010 Watchdog device drivers

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 Watchdog: Adding support for Watchdog found with ARM CortexA9

Watchdog details can be found in ARM Cortex A9 reference manual at:
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0407e/indix.html

---
 drivers/watchdog/Kconfig        |    7 +
 drivers/watchdog/Makefile       |    1 +
 drivers/watchdog/cortexa9_wdt.c |  414 +++++++++++++++++++++++++++++++++++++++
 3 files changed, 422 insertions(+), 0 deletions(-)
 create mode 100644 drivers/watchdog/cortexa9_wdt.c
drivers/watchdog/Kconfig +7 -0
index 0bf5020..b5c0f6f 100644
@@ -73,6 +73,13 @@ config WM8350_WATCHDOG
 
 # ARM Architecture
 
+config ARM_CORTEXA9_WATCHDOG
+	tristate "ARM CortexA9 Watchdog"
+	depends on ARM_AMBA
+	help
+	  Watchdog timer present with ARM Cortex A9 processor. This will reboot
+	  your system when the timeout is reached.
+
 config AT91RM9200_WATCHDOG
 	tristate "AT91RM9200 watchdog"
 	depends on ARCH_AT91RM9200
drivers/watchdog/Makefile +1 -0
index 5e3cb95..7704efc 100644
@@ -25,6 +25,7 @@ obj-$(CONFIG_USBPCWATCHDOG) += pcwd_usb.o
 # ALPHA Architecture
 
 # ARM Architecture
+obj-$(CONFIG_ARM_CORTEXA9_WATCHDOG) += cortexa9_wdt.o
 obj-$(CONFIG_AT91RM9200_WATCHDOG) += at91rm9200_wdt.o
 obj-$(CONFIG_AT91SAM9X_WATCHDOG) += at91sam9_wdt.o
 obj-$(CONFIG_OMAP_WATCHDOG) += omap_wdt.o
drivers/watchdog/cortexa9_wdt.c new file +414 -0

414 lines not on this page · raw message

Signature · 1 line
1.6.0.2
#1 lore raw

PATCH RESEND 1/1 Watchdog: Adding support for Watchdog found with ARM CortexA9

<snip>

Quoted 24 lines

-----Original Message-----
From: linux-arm-kernel-bounces at lists.infradead.org [mailto:linux-arm-kernel- bounces at lists.infradead.org] On Behalf Of Viresh KUMAR
Sent: Monday, May 17, 2010 3:29 PM
To: linux-arm-kernel at lists.infradead.org
Cc: armando.visconti at st.com; shiraz.hashim at st.com; Viresh Kumar; linus.walleij at stericsson.com
Subject: [PATCH Resend] Watchdog: Adding support for Watchdog found with ARM CortexA9

Watchdog details can be found in ARM Cortex A9 reference manual at:
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0407e/indix.html

---
 drivers/watchdog/Kconfig        |    7 +
 drivers/watchdog/Makefile       |    1 +
 drivers/watchdog/cortexa9_wdt.c |  414 +++++++++++++++++++++++++++++++++++++++
 3 files changed, 422 insertions(+), 0 deletions(-)
 create mode 100644 drivers/watchdog/cortexa9_wdt.c
drivers/watchdog/Kconfig +0 -0
index 0bf5020..b5c0f6f 100644

drivers/watchdog/Kconfig config WM8350_WATCHDOG · line 78

Quoted 6 lines
drivers/watchdog/Kconfig +3 -0
@@ -73,6 +73,13 @@ config WM8350_WATCHDOG
 
 # ARM Architecture
 
+config ARM_CORTEXA9_WATCHDOG
+	tristate "ARM CortexA9 Watchdog"
+	depends on ARM_AMBA

What is the ARM_AMBA dependency with CA-9 watchdog?

Quoted 7 lines
drivers/watchdog/Kconfig +4 -0
+	help
+	  Watchdog timer present with ARM Cortex A9 processor. This will reboot
+	  your system when the timeout is reached.
+
 config AT91RM9200_WATCHDOG
 	tristate "AT91RM9200 watchdog"
 	depends on ARCH_AT91RM9200
#2 lore raw

PATCH RESEND 1/1 Watchdog: Adding support for Watchdog found with ARM CortexA9

Quoted 26 lines · Santosh

<snip>

Quoted 25 lines

-----Original Message-----
From: linux-arm-kernel-bounces at lists.infradead.org [mailto:linux-arm-kernel- bounces at lists.infradead.org] On Behalf Of Viresh KUMAR
Sent: Monday, May 17, 2010 3:29 PM
To: linux-arm-kernel at lists.infradead.org
Cc: armando.visconti at st.com; shiraz.hashim at st.com; Viresh Kumar; linus.walleij at stericsson.com
Subject: [PATCH Resend] Watchdog: Adding support for Watchdog found with ARM CortexA9

Watchdog details can be found in ARM Cortex A9 reference manual at:
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0407e/indix.html

---
 drivers/watchdog/Kconfig        |    7 +
 drivers/watchdog/Makefile       |    1 +
 drivers/watchdog/cortexa9_wdt.c |  414 +++++++++++++++++++++++++++++++++++++++
 3 files changed, 422 insertions(+), 0 deletions(-)
 create mode 100644 drivers/watchdog/cortexa9_wdt.c
drivers/watchdog/Kconfig +0 -0
index 0bf5020..b5c0f6f 100644
@@ -73,6 +73,13 @@ config WM8350_WATCHDOG
 
Quoted 7 lines

drivers/watchdog/Kconfig config WM8350_WATCHDOG · line 78

Quoted 5 lines
drivers/watchdog/Kconfig +3 -0
 # ARM Architecture
 
+config ARM_CORTEXA9_WATCHDOG
+	tristate "ARM CortexA9 Watchdog"
+	depends on ARM_AMBA

What is the ARM_AMBA dependency with CA-9 watchdog?

Not really on amba, rather on ARM. Or CPU_V7 (cortex related)? Maybe some other ARM core also have similar design, so can keep it dependent on ARM. Does this looks fine?

viresh

#3 lore raw

PATCH RESEND 1/1 Watchdog: Adding support for Watchdog found with ARM CortexA9

Quoted 43 lines

-----Original Message-----
From: Viresh KUMAR [mailto:viresh.kumar at st.com]
Sent: Monday, May 17, 2010 4:03 PM
To: Shilimkar, Santosh
Cc: linux-arm-kernel at lists.infradead.org; armando.visconti at st.com; shiraz.hashim at st.com; linus.walleij at stericsson.com
Subject: Re: [PATCH Resend] Watchdog: Adding support for Watchdog found with ARM CortexA9

Quoted 26 lines · Santosh

<snip>

Quoted 25 lines

-----Original Message-----
From: linux-arm-kernel-bounces at lists.infradead.org [mailto:linux-arm-kernel- bounces at lists.infradead.org] On Behalf Of Viresh KUMAR
Sent: Monday, May 17, 2010 3:29 PM
To: linux-arm-kernel at lists.infradead.org
Cc: armando.visconti at st.com; shiraz.hashim at st.com; Viresh Kumar; linus.walleij at stericsson.com
Subject: [PATCH Resend] Watchdog: Adding support for Watchdog found with ARM CortexA9

Watchdog details can be found in ARM Cortex A9 reference manual at:
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0407e/indix.html

---
 drivers/watchdog/Kconfig        |    7 +
 drivers/watchdog/Makefile       |    1 +
 drivers/watchdog/cortexa9_wdt.c |  414 +++++++++++++++++++++++++++++++++++++++
 3 files changed, 422 insertions(+), 0 deletions(-)
 create mode 100644 drivers/watchdog/cortexa9_wdt.c
drivers/watchdog/Kconfig +0 -0
index 0bf5020..b5c0f6f 100644
@@ -73,6 +73,13 @@ config WM8350_WATCHDOG
 
Quoted 7 lines

drivers/watchdog/Kconfig config WM8350_WATCHDOG · line 78

Quoted 5 lines
drivers/watchdog/Kconfig +3 -0
 # ARM Architecture
 
+config ARM_CORTEXA9_WATCHDOG
+	tristate "ARM CortexA9 Watchdog"
+	depends on ARM_AMBA

What is the ARM_AMBA dependency with CA-9 watchdog?

Quoted 4 lines

Not really on amba, rather on ARM. Or CPU_V7 (cortex related)? Maybe some other ARM core also have similar design, so can keep it dependent on ARM. Does this looks fine?

Thanks for clarification. Even CPU_V7 isn't correct dependency because CA8 is based on V7 as well where the WDT isn't there. So not sure about it. May be V7 + SMP might fit but not necessarily correct again. Or you just leave it as "depends on ARM"

Regards,
Santosh

#4 lore raw

PATCH RESEND 1/1 Watchdog: Adding support for Watchdog found with ARM CortexA9

In reply to Viresh KUMAR
Quoted 6 lines · Viresh KUMAR
Quoted 1 line · Santosh

What is the ARM_AMBA dependency with CA-9 watchdog?

Not really on amba, rather on ARM. Or CPU_V7 (cortex related)? Maybe some other ARM core also have similar design, so can keep it dependent on ARM. Does this looks fine?

It makes sense to make it dependent on CPU_V7 for the time being.

#5 lore raw

PATCH RESEND 1/1 Watchdog: Adding support for Watchdog found with ARM CortexA9

Quoted 10 lines · Russell King - ARM Linux
Quoted 6 lines · Viresh KUMAR
Quoted 1 line · Santosh

What is the ARM_AMBA dependency with CA-9 watchdog?

Not really on amba, rather on ARM. Or CPU_V7 (cortex related)? Maybe some other ARM core also have similar design, so can keep it dependent on ARM. Does this looks fine?

It makes sense to make it dependent on CPU_V7 for the time being.

OK.