Skip to contentSkip to conversation

MIPS DINSU

PATCH In review Dmitry Antipov 2 participants 2 messages May 17, 2010 – May 28, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MIPS DINSU

Hello,

shouldn't it be in that way?

Dmitry

target-mips/translate.c +1 -1
@@ -2761,7 +2761,7 @@
     case OPC_DINSU:
         if (lsb > msb)
             goto fail;
-        mask = ((1ULL << (msb - lsb + 1)) - 1) << lsb;
+        mask = ((1ULL << (msb - lsb + 1)) - 1) << (lsb + 32);
         gen_load_gpr(t0, rt);
         tcg_gen_andi_tl(t0, t0, ~mask);
         tcg_gen_shli_tl(t1, t1, lsb + 32);
#1 lore raw
Quoted 6 lines · Dmitry Antipov

Hello,

shouldn't it be in that way?

Dmitry

Good catch, it is correct. Would you mind resending the patch with a
Signed-off-by: line?

Quoted 11 lines
target-mips/translate.c +1 -1
@@ -2761,7 +2761,7 @@
     case OPC_DINSU:
         if (lsb > msb)
             goto fail;
-        mask = ((1ULL << (msb - lsb + 1)) - 1) << lsb;
+        mask = ((1ULL << (msb - lsb + 1)) - 1) << (lsb + 32);
         gen_load_gpr(t0, rt);
         tcg_gen_andi_tl(t0, t0, ~mask);
         tcg_gen_shli_tl(t1, t1, lsb + 32);
Signature · 2 lines
Aurelien Jarno                          GPG: 1024D/F1BCDB73
[email protected]                 http://www.aurel32.net