Skip to contentSkip to conversation

x86, hpet: Add reference to chipset erratum documentation for disable-hpet-msi-quirk

PATCH In review Andreas Herrmann 4 participants 5 messages May 17, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86, hpet: Add reference to chipset erratum documentation for disable-hpet-msi-quirk

From: Andreas Herrmann <[email protected]>

(At the moment the "SB700 Family Product Errata" document is available at http://support.amd.com/us/Embedded_TechDocs/46837.pdf)

---
 arch/x86/kernel/quirks.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

Linus recommended to add a pointer to that erratum to the source. See

http://marc.info/[email protected]

Please apply.

Thanks,

Andreas

arch/x86/kernel/quirks.c +3 -0
index cd2c336..e72d3fc 100644
@@ -495,6 +495,9 @@ void force_hpet_resume(void)
 /*
  * HPET MSI on some boards (ATI SB700/SB800) has side effect on
  * floppy DMA. Disable HPET MSI on such platforms.
+ * See erratum #27 (Misinterpreted MSI Requests May Result in
+ * Corrupted LPC DMA Data) in AMD Publication #46837,
+ * "SB700 Family Product Errata", Rev. 1.0, March 2010.
  *
  * Also force the read back of the CMP register in hpet_next_event()
  * to work around the problem that the CMP register write seems to be
Signature · 1 line
1.6.4.4
#2 lore raw
Quoted 10 lines · Linus Torvalds
Quoted 3 lines · Andreas Herrmann

(At the moment the "SB700 Family Product Errata" document is available at http://support.amd.com/us/Embedded_TechDocs/46837.pdf)

Ok, this is against x86 -tip, right? It doesn't apply for me, so I'll just assume I will get it through the normal x86 merge requests.

It conflicts with a related change in -tip, but I'll fix it up and you'll get it with the usual merge window flood.

-hpa

Signature · 2 lines
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.
#3 lore raw
Quoted 8 lines · H. Peter Anvin
Quoted 7 lines · Linus Torvalds
Quoted 3 lines · Andreas Herrmann

(At the moment the "SB700 Family Product Errata" document is available at http://support.amd.com/us/Embedded_TechDocs/46837.pdf)

Quoted 7 lines
Quoted 3 lines

Ok, this is against x86 -tip, right? It doesn't apply for me, so I'll just assume I will get it through the normal x86 merge requests.

It conflicts with a related change in -tip, but I'll fix it up and you'll get it with the usual merge window flood.

Slight correction: it didn't conflict, it was based upon. Anyway, it's queued up in -tip now.

-hpa

Signature · 2 lines
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.
#4 lore raw
In reply to Andreas Herrmann
Commit-ID:  fec84e330719c20d2146c8dbdc9ff50b3a1d7039
Gitweb:     http://git.kernel.org/tip/fec84e330719c20d2146c8dbdc9ff50b3a1d7039
Author:     Andreas Herrmann <[email protected]>
AuthorDate: Mon, 17 May 2010 18:43:24 +0200
Committer:  H. Peter Anvin <[email protected]>
CommitDate: Mon, 17 May 2010 10:04:43 -0700

x86, hpet: Add reference to chipset erratum documentation for disable-hpet-msi-quirk

(At the moment the "SB700 Family Product Errata" document is available at http://support.amd.com/us/Embedded_TechDocs/46837.pdf)

LKML-Reference: <[email protected]>

---
 arch/x86/kernel/quirks.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
arch/x86/kernel/quirks.c +3 -0
index cd2c336..e72d3fc 100644
@@ -495,6 +495,9 @@ void force_hpet_resume(void)
 /*
  * HPET MSI on some boards (ATI SB700/SB800) has side effect on
  * floppy DMA. Disable HPET MSI on such platforms.
+ * See erratum #27 (Misinterpreted MSI Requests May Result in
+ * Corrupted LPC DMA Data) in AMD Publication #46837,
+ * "SB700 Family Product Errata", Rev. 1.0, March 2010.
  *
  * Also force the read back of the CMP register in hpet_next_event()
  * to work around the problem that the CMP register write seems to be