Skip to contentSkip to conversation

USB: s3c_hsotg: define USB_GADGET_DUALSPEED in Kconfig

PATCH In review Maurus Cuelenaere 1 participant 2 messages May 17, 2010 – May 19, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 2/2 USB: s3c_hsotg: define USB_GADGET_DUALSPEED in Kconfig

The s3c_hsotg driver sets usb_gadget->is_dualspeed to 1, yet it doesn't define USB_GADGET_DUALSPEED in Kconfig. This triggers a NULL pointer dereference in the composite driver (which is fixed in another patch).

---
 drivers/usb/gadget/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/usb/gadget/Kconfig +1 -0
index 11a3e0f..b9df8a5 100644
@@ -295,6 +295,7 @@ config USB_GADGET_S3C_HSOTG
 	boolean "S3C HS/OtG USB Device controller"
 	depends on S3C_DEV_USB_HSOTG
 	select USB_GADGET_S3C_HSOTG_PIO
+	select USB_GADGET_DUALSPEED
 	help
 	  The Samsung S3C64XX USB2.0 high-speed gadget controller
 	  integrated into the S3C64XX series SoC.
Signature · 1 line
1.7.1
author Acked-by Ben Dooks on v1 2/2
#1 lore raw

Op 17-05-10 21:12, Maurus Cuelenaere schreef:

Quoted 9 lines

The s3c_hsotg driver sets usb_gadget->is_dualspeed to 1, yet it doesn't define USB_GADGET_DUALSPEED in Kconfig. This triggers a NULL pointer dereference in the composite driver (which is fixed in another patch).

---
 drivers/usb/gadget/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

I'm unsure whether I should be the one stating this, but Ben acked this patch:

Signature · 1 line
Maurus Cuelenaere