Skip to contentSkip to conversation

HID: remove redundant key mappings from Desktop Wireless 6000

PATCH Applied Don Prince 2 participants 2 messages May 17, 2010 – May 18, 2010 HID

lore
Share & tools
lore

Don Prince

author
#0 lore raw

PATCH 1/1 HID: remove redundant key mappings from Desktop Wireless 6000

Remove 7 redundant key mappings from Desktop Wireless 6000 that are already handled by the default hid code.

---

Spotted by by Robert Schedel <[email protected]>

drivers/hid/hid-samsung.c +0 -7
diff -X /opt/scripts/diff-exclude.txt -Npaur a/drivers/hid/hid-samsung.c b/drivers/hid/hid-samsung.c
@@ -112,13 +112,6 @@ static int samsung_kbd_mouse_input_mappi
 
 	switch (usage->hid & HID_USAGE) {
 	/* report 2 */
-	case 0x0b5: samsung_kbd_mouse_map_key_clear(KEY_NEXTSONG); break;
-	case 0x0b6: samsung_kbd_mouse_map_key_clear(KEY_PREVIOUSSONG); break;
-	case 0x0b7: samsung_kbd_mouse_map_key_clear(KEY_STOPCD); break;
-	case 0x0cd: samsung_kbd_mouse_map_key_clear(KEY_PLAYPAUSE); break;
-	case 0x0e2: samsung_kbd_mouse_map_key_clear(KEY_MUTE); break;
-	case 0x0e9: samsung_kbd_mouse_map_key_clear(KEY_VOLUMEUP); break;
-	case 0x0ea: samsung_kbd_mouse_map_key_clear(KEY_VOLUMEDOWN); break;
 	case 0x183: samsung_kbd_mouse_map_key_clear(KEY_MEDIA); break;
 	case 0x195: samsung_kbd_mouse_map_key_clear(KEY_EMAIL);	break;
 	case 0x196: samsung_kbd_mouse_map_key_clear(KEY_CALC); break;

___________________________________________________________
All new Yahoo! Mail "The new Interface is stunning in its simplicity and ease of use." - PC Magazine
http://uk.docs.yahoo.com/nowyoucan.html

Applied
#1 lore raw
Quoted 14 lines · Don Prince

Remove 7 redundant key mappings from Desktop Wireless 6000 that are already handled by the default hid code.

---

Spotted by by Robert Schedel <[email protected]>

diff -X /opt/scripts/diff-exclude.txt -Npaur a/drivers/hid/hid-samsung.c b/drivers/hid/hid-samsung.c

drivers/hid/hid-samsung.c static int samsung_kbd_mouse_input_mappi · line 121

Quoted 10 lines
drivers/hid/hid-samsung.c +0 -7
@@ -112,13 +112,6 @@ static int samsung_kbd_mouse_input_mappi
 
 	switch (usage->hid & HID_USAGE) {
 	/* report 2 */
-	case 0x0b5: samsung_kbd_mouse_map_key_clear(KEY_NEXTSONG); break;
-	case 0x0b6: samsung_kbd_mouse_map_key_clear(KEY_PREVIOUSSONG); break;
-	case 0x0b7: samsung_kbd_mouse_map_key_clear(KEY_STOPCD); break;
-	case 0x0cd: samsung_kbd_mouse_map_key_clear(KEY_PLAYPAUSE); break;
-	case 0x0e2: samsung_kbd_mouse_map_key_clear(KEY_MUTE); break;
-	case 0x0e9: samsung_kbd_mouse_map_key_clear(KEY_VOLUMEUP); break;
-	case 0x0ea: samsung_kbd_mouse_map_key_clear(KEY_VOLUMEDOWN); break;

Applied, thanks for spotting it Robert.

Signature · 2 lines
Jiri Kosina
SUSE Labs, Novell Inc.