Skip to contentSkip to conversation

cross.bbclass: fix build of meta-toolchain

PATCH In review Eric Benard 5 participants 6 messages May 14, 2010 – May 18, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cross.bbclass: fix build of meta-toolchain

- without this bitbake meta-toolchain fails because it doesn't find who provides gdb-cross-sdk
- found thanks to a hint from Phil Blundell on IRC
- tested with Angstrom/ARMv5te

---
 classes/cross.bbclass |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
classes/cross.bbclass +0 -2
index 69f6511..5c2d5be 100644
@@ -17,8 +17,6 @@ PACKAGE_ARCH = "${OLD_PACKAGE_ARCH}"
 OLD_BASE_PACKAGE_ARCH := "${BASE_PACKAGE_ARCH}"
 BASE_PACKAGE_ARCH = "${OLD_BASE_PACKAGE_ARCH}"
 
-PACKAGES = ""
-
 HOST_ARCH = "${BUILD_ARCH}"
 HOST_VENDOR = "${BUILD_VENDOR}"
 HOST_OS = "${BUILD_OS}"
Signature · 1 line
1.6.3.3
#1 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I can confirm that 'meta-toolchain' builds against with this (angstrom/beagleboard), but I don't know what the effect of this is on cross recipes.

regards,

Koen

Quoted 15 lines · Eric Benard

- without this bitbake meta-toolchain fails because it doesn't find who provides gdb-cross-sdk
- found thanks to a hint from Phil Blundell on IRC
- tested with Angstrom/ARMv5te

---
 classes/cross.bbclass |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
classes/cross.bbclass +0 -0
index 69f6511..5c2d5be 100644

classes/cross.bbclass PACKAGE_ARCH = "${OLD_PACKAGE_ARCH}" · line 22

Quoted 8 lines
classes/cross.bbclass +0 -2
@@ -17,8 +17,6 @@ PACKAGE_ARCH = "${OLD_PACKAGE_ARCH}"
 OLD_BASE_PACKAGE_ARCH := "${BASE_PACKAGE_ARCH}"
 BASE_PACKAGE_ARCH = "${OLD_BASE_PACKAGE_ARCH}"
 
-PACKAGES = ""
-
 HOST_ARCH = "${BUILD_ARCH}"
 HOST_VENDOR = "${BUILD_VENDOR}"
 HOST_OS = "${BUILD_OS}"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFL8BvSMkyGM64RGpERApFQAJ40WH4OOiFb0PZVfy/8gbQG4tFn4ACdFiHQ 9sEaKXsbeiDyzv/P/7+fQ4A=
=14NR
-----END PGP SIGNATURE-----

#2 lore raw

Hi,

Quoted 6 lines · Koen Kooi

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I can confirm that 'meta-toolchain' builds against with this (angstrom/beagleboard), but I don't know what the effect of this is on cross recipes.

Who could confirm that this change may not introduce any unwanted behaviour ?

Thanks,
Eric

Quoted 40 lines · Eric Benard
Quoted 15 lines

- without this bitbake meta-toolchain fails because it doesn't find who provides gdb-cross-sdk
- found thanks to a hint from Phil Blundell on IRC
- tested with Angstrom/ARMv5te

---
  classes/cross.bbclass |    2 --
  1 files changed, 0 insertions(+), 2 deletions(-)
classes/cross.bbclass +0 -0
index 69f6511..5c2d5be 100644

classes/cross.bbclass PACKAGE_ARCH = "${OLD_PACKAGE_ARCH}" · line 22

Quoted 8 lines
classes/cross.bbclass +0 -2
@@ -17,8 +17,6 @@ PACKAGE_ARCH = "${OLD_PACKAGE_ARCH}"
  OLD_BASE_PACKAGE_ARCH := "${BASE_PACKAGE_ARCH}"
  BASE_PACKAGE_ARCH = "${OLD_BASE_PACKAGE_ARCH}"
 
-PACKAGES = ""
-
  HOST_ARCH = "${BUILD_ARCH}"
  HOST_VENDOR = "${BUILD_VENDOR}"
  HOST_OS = "${BUILD_OS}"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFL8BvSMkyGM64RGpERApFQAJ40WH4OOiFb0PZVfy/8gbQG4tFn4ACdFiHQ 9sEaKXsbeiDyzv/P/7+fQ4A=
=14NR
-----END PGP SIGNATURE-----

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Acked-by
#3 lore raw
Quoted 6 lines · Eric Bénard

Hi,

Quoted 3 lines · Koen Kooi

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 6 lines
Quoted 3 lines

I can confirm that 'meta-toolchain' builds against with this (angstrom/beagleboard), but I don't know what the effect of this is on cross recipes.

Who could confirm that this change may not introduce any unwanted behaviour ?

I have build a console-image so far ok with this change in. I did not notice any difference.
So you have my ack

Quoted 49 lines

Thanks,
Eric

Quoted 35 lines · Eric Benard
Quoted 15 lines

- without this bitbake meta-toolchain fails because it doesn't find who provides gdb-cross-sdk
- found thanks to a hint from Phil Blundell on IRC
- tested with Angstrom/ARMv5te

---
 classes/cross.bbclass |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
classes/cross.bbclass +0 -0
index 69f6511..5c2d5be 100644

classes/cross.bbclass PACKAGE_ARCH = "${OLD_PACKAGE_ARCH}" · line 22

Quoted 8 lines
classes/cross.bbclass +0 -2
@@ -17,8 +17,6 @@ PACKAGE_ARCH = "${OLD_PACKAGE_ARCH}"
 OLD_BASE_PACKAGE_ARCH := "${BASE_PACKAGE_ARCH}"
 BASE_PACKAGE_ARCH = "${OLD_BASE_PACKAGE_ARCH}"
 
-PACKAGES = ""
-
 HOST_ARCH = "${BUILD_ARCH}"
 HOST_VENDOR = "${BUILD_VENDOR}"
 HOST_OS = "${BUILD_OS}"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFL8BvSMkyGM64RGpERApFQAJ40WH4OOiFb0PZVfy/8gbQG4tFn4ACdFiHQ 9sEaKXsbeiDyzv/P/7+fQ4A=
=14NR
-----END PGP SIGNATURE-----

Quoted 5 lines

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

#4 lore raw
In reply to Eric Bénard
Quoted 6 lines · Eric Bénard

Hi,

Quoted 3 lines · Koen Kooi

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 6 lines
Quoted 3 lines

I can confirm that 'meta-toolchain' builds against with this (angstrom/beagleboard), but I don't know what the effect of this is on cross recipes.

Who could confirm that this change may not introduce any unwanted behaviour ?

In the long term I think this patch is a good idea, and I think we already have a similar change on the toolchain-desuck branch.

In the short term, this patch is probably harmless since I think the other bits in cross.bbclass will prevent any packages from actually being generated (since the install paths won't match against any FILES). If you did get packages out then they would be somewhat misleadingly named and this would probably be a bad thing.

I think you might as well go ahead and check this in, if you haven't already, and if any issues do crop up we can deal with them at that time. I would like to try to get the other toolchain-packaging changes merged as well at some point soonish.

p.

#5 lore raw
In reply to Eric Benard
Quoted 20 lines · Eric Benard

- without this bitbake meta-toolchain fails because it doesn't find who provides gdb-cross-sdk
- found thanks to a hint from Phil Blundell on IRC
- tested with Angstrom/ARMv5te

---
 classes/cross.bbclass |    2 --

 1 files changed, 0 insertions(+), 2 deletions(-)
classes/cross.bbclass +0 -0
index 69f6511..5c2d5be 100644
@@ -17,8 +17,6 @@ PACKAGE_ARCH = "${OLD_PACKAGE_ARCH}"

 OLD_BASE_PACKAGE_ARCH := "${BASE_PACKAGE_ARCH}"
 BASE_PACKAGE_ARCH = "${OLD_BASE_PACKAGE_ARCH}"

classes/cross.bbclass +0 -2
-PACKAGES = ""
-
Quoted 5 lines

 HOST_ARCH = "${BUILD_ARCH}"
 HOST_VENDOR = "${BUILD_VENDOR}"
 HOST_OS = "${BUILD_OS}"
--
1.6.3.3

This fixes meta-toolchain builds for me.

Thanks,
Cliff