Skip to contentSkip to conversation

dm-ioctl: Remove useless __dev_status call for "device geometry" and "target message" ioctl

PATCH New Peter Rajnoha 1 participant 1 message May 18, 2010 Device mapper

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dm-ioctl: Remove useless __dev_status call for "device geometry" and "target message" ioctl

Remove useless __dev_status call while processing an ioctl that sets up device geometry and target message.

---
 drivers/md/dm-ioctl.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)
drivers/md/dm-ioctl.c +0 -6
index f67ec28..afb641c 100644
@@ -818,8 +818,6 @@ static int dev_set_geometry(struct dm_ioctl *param, size_t param_size)
 	geometry.start = indata[3];
 
 	r = dm_set_geometry(md, &geometry);
-	if (!r)
-		r = __dev_status(md, param);
 
 	param->data_size = 0;
 
@@ -1333,10 +1331,6 @@ static int target_message(struct dm_ioctl *param, size_t param_size)
 	if (!md)
 		return -ENXIO;
 
-	r = __dev_status(md, param);
-	if (r)
-		goto out;
-
 	if (tmsg < (struct dm_target_msg *) param->data ||
 	    invalid_str(tmsg->message, (void *) param + param_size)) {
 		DMWARN("Invalid target message parameters.");