Skip to contentSkip to conversation

ARM: S5PV210: Add GONI board support

PATCH New Joonyoung Shim 5 participants 6 messages May 19, 2010 – May 21, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: S5PV210: Add GONI board support

This is for samsung GONI board using s5pc110.

---
 arch/arm/mach-s5pv210/Kconfig     |    8 +++
 arch/arm/mach-s5pv210/Makefile    |    1 +
 arch/arm/mach-s5pv210/mach-goni.c |   98 +++++++++++++++++++++++++++++++++++++
 3 files changed, 107 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-s5pv210/mach-goni.c
arch/arm/mach-s5pv210/Kconfig +8 -0
index 7601c28..83b15b2 100644
@@ -36,6 +36,14 @@ config MACH_SMDKC110
 	  Machine support for Samsung SMDKC110
 	  S5PC110(MCP) is one of package option of S5PV210
 
+config MACH_GONI
+	bool "GONI"
+	select CPU_S5PV210
+	select ARCH_SPARSEMEM_ENABLE
+	help
+	  Machine support for Samsung GONI board
+	  S5PC110(MCP) is one of package option of S5PV210
+
 endchoice
 
 endif
arch/arm/mach-s5pv210/Makefile +1 -0
index 9982781..5135577 100644
@@ -19,6 +19,7 @@ obj-$(CONFIG_CPU_S5PV210)	+= setup-i2c0.o
 
 obj-$(CONFIG_MACH_SMDKV210)	+= mach-smdkv210.o
 obj-$(CONFIG_MACH_SMDKC110)	+= mach-smdkc110.o
+obj-$(CONFIG_MACH_GONI)		+= mach-goni.o
 
 # device support
 
arch/arm/mach-s5pv210/mach-goni.c new file +98 -0

98 lines not on this page · raw message

Signature · 1 line
1.7.0.4
#1 lore raw

PATCH 1/1 ARM: S5PV210: Add GONI board support

Quoted 4 lines · Joonyoung Shim

This is for samsung GONI board using s5pc110.

I'll think about adding this, however it is very late in the development cycle, and the only thing saving it from immediate stalling until the next round is the fact that it is so simple.

Quoted 109 lines
---
 arch/arm/mach-s5pv210/Kconfig     |    8 +++
 arch/arm/mach-s5pv210/Makefile    |    1 +
 arch/arm/mach-s5pv210/mach-goni.c |   98 +++++++++++++++++++++++++++++++++++++
 3 files changed, 107 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-s5pv210/mach-goni.c
arch/arm/mach-s5pv210/Kconfig +8 -0
index 7601c28..83b15b2 100644
@@ -36,6 +36,14 @@ config MACH_SMDKC110
 	  Machine support for Samsung SMDKC110
 	  S5PC110(MCP) is one of package option of S5PV210
 
+config MACH_GONI
+	bool "GONI"
+	select CPU_S5PV210
+	select ARCH_SPARSEMEM_ENABLE
+	help
+	  Machine support for Samsung GONI board
+	  S5PC110(MCP) is one of package option of S5PV210
+
 endchoice
 
 endif
arch/arm/mach-s5pv210/Makefile +1 -0
index 9982781..5135577 100644
@@ -19,6 +19,7 @@ obj-$(CONFIG_CPU_S5PV210)	+= setup-i2c0.o
 
 obj-$(CONFIG_MACH_SMDKV210)	+= mach-smdkv210.o
 obj-$(CONFIG_MACH_SMDKC110)	+= mach-smdkc110.o
+obj-$(CONFIG_MACH_GONI)		+= mach-goni.o
 
 # device support
 
arch/arm/mach-s5pv210/mach-goni.c new file +65 -0
new file mode 100644
index 0000000..4863b13
@@ -0,0 +1,98 @@
+/* linux/arch/arm/mach-s5pv210/mach-goni.c
+ *
+ * Copyright (c) 2010 Samsung Electronics Co., Ltd.
+ *		http://www.samsung.com/
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+#include <linux/kernel.h>
+#include <linux/types.h>
+#include <linux/init.h>
+#include <linux/serial_core.h>
+
+#include <asm/mach/arch.h>
+#include <asm/mach/map.h>
+#include <asm/setup.h>
+#include <asm/mach-types.h>
+
+#include <mach/map.h>
+#include <mach/regs-clock.h>
+
+#include <plat/regs-serial.h>
+#include <plat/s5pv210.h>
+#include <plat/devs.h>
+#include <plat/cpu.h>
+
+/* Following are default values for UCON, ULCON and UFCON UART registers */
+#define S5PV210_UCON_DEFAULT	(S3C2410_UCON_TXILEVEL |	\
+				 S3C2410_UCON_RXILEVEL |	\
+				 S3C2410_UCON_TXIRQMODE |	\
+				 S3C2410_UCON_RXIRQMODE |	\
+				 S3C2410_UCON_RXFIFO_TOI |	\
+				 S3C2443_UCON_RXERR_IRQEN)
+
+#define S5PV210_ULCON_DEFAULT	S3C2410_LCON_CS8
+
+#define S5PV210_UFCON_DEFAULT	(S3C2410_UFCON_FIFOMODE |	\
+				 S5PV210_UFCON_TXTRIG4 |	\
+				 S5PV210_UFCON_RXTRIG4)
+
+static struct s3c2410_uartcfg goni_uartcfgs[] __initdata = {
+	[0] = {
+		.hwport		= 0,
+		.flags		= 0,
+		.ucon		= S5PV210_UCON_DEFAULT,
+		.ulcon		= S5PV210_ULCON_DEFAULT,
+		.ufcon		= S5PV210_UFCON_DEFAULT,
+	},
+	[1] = {
+		.hwport		= 1,
+		.flags		= 0,
+		.ucon		= S5PV210_UCON_DEFAULT,
+		.ulcon		= S5PV210_ULCON_DEFAULT,
+		.ufcon		= S5PV210_UFCON_DEFAULT,
+	},
+	[2] = {
+		.hwport		= 2,
+		.flags		= 0,
+		.ucon		= S5PV210_UCON_DEFAULT,
+		.ulcon		= S5PV210_ULCON_DEFAULT,
+		.ufcon		= S5PV210_UFCON_DEFAULT,
+	},
+	[3] = {

arch/arm/mach-s5pv210/mach-goni.c line 75

Quoted 10 lines
arch/arm/mach-s5pv210/mach-goni.c new file +10 -0
+		.hwport		= 3,
+		.flags		= 0,
+		.ucon		= S5PV210_UCON_DEFAULT,
+		.ulcon		= S5PV210_ULCON_DEFAULT,
+		.ufcon		= S5PV210_UFCON_DEFAULT,
+	},
+};
+
+static struct platform_device *goni_devices[] __initdata = {
+};

If you promise to actually populate this, then it can stay.

Quoted 22 lines
arch/arm/mach-s5pv210/mach-goni.c new file +22 -0
+static void __init goni_map_io(void)
+{
+	s5p_init_io(NULL, 0, S5P_VA_CHIPID);
+	s3c24xx_init_clocks(24000000);
+	s3c24xx_init_uarts(goni_uartcfgs, ARRAY_SIZE(goni_uartcfgs));
+}
+
+static void __init goni_machine_init(void)
+{
+	platform_add_devices(goni_devices, ARRAY_SIZE(goni_devices));
+}
+
+MACHINE_START(GONI, "GONI")
+	/* Maintainers: Kyungmin Park <[email protected]> */
+	.phys_io	= S3C_PA_UART & 0xfff00000,
+	.io_pg_offst	= (((u32)S3C_VA_UART) >> 18) & 0xfffc,
+	.boot_params	= S5P_PA_SDRAM + 0x100,
+	.init_irq	= s5pv210_init_irq,
+	.map_io		= goni_map_io,
+	.init_machine	= goni_machine_init,
+	.timer		= &s3c24xx_timer,
+MACHINE_END
Signature · 4 lines
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.
#2 lore raw

PATCH 1/1 ARM: S5PV210: Add GONI board support

Quoted 9 lines · Ben Dooks
Quoted 4 lines · Joonyoung Shim

This is for samsung GONI board using s5pc110.

I'll think about adding this, however it is very late in the development cycle, and the only thing saving it from immediate stalling until the next round is the fact that it is so simple.

Hi,

In the previous time, Marek sent the s5pv210 patch including the aquila board support.
But in this merge cycle, it doesn't included. of course all s5pv210 patches too, Please find the patch subject "ARM: S5PV210: add Aquila board" and check it again.

Thank you,
Kyungmin Park

Quoted 158 lines
Quoted 110 lines

---

?arch/arm/mach-s5pv210/Kconfig ? ? | ? ?8 +++
?arch/arm/mach-s5pv210/Makefile ? ?| ? ?1 +
?arch/arm/mach-s5pv210/mach-goni.c | ? 98 +++++++++++++++++++++++++++++++++++++

?3 files changed, 107 insertions(+), 0 deletions(-) ?create mode 100644 arch/arm/mach-s5pv210/mach-goni.c

arch/arm/mach-s5pv210/Kconfig +0 -0
index 7601c28..83b15b2 100644
@@ -36,6 +36,14 @@ config MACH_SMDKC110

? ? ? ? Machine support for Samsung SMDKC110
? ? ? ? S5PC110(MCP) is one of package option of S5PV210

arch/arm/mach-s5pv210/Kconfig +8 -0
+config MACH_GONI
+ ? ? bool "GONI"
+ ? ? select CPU_S5PV210
+ ? ? select ARCH_SPARSEMEM_ENABLE
+ ? ? help
+ ? ? ? Machine support for Samsung GONI board
+ ? ? ? S5PC110(MCP) is one of package option of S5PV210
+

?endchoice

?endif

arch/arm/mach-s5pv210/Makefile +0 -0
index 9982781..5135577 100644
@@ -19,6 +19,7 @@ obj-$(CONFIG_CPU_S5PV210) ? += setup-i2c0.o
 

?obj-$(CONFIG_MACH_SMDKV210) ?+= mach-smdkv210.o ?obj-$(CONFIG_MACH_SMDKC110) ?+= mach-smdkc110.o +obj-$(CONFIG_MACH_GONI) ? ? ? ? ? ? ?+= mach-goni.o

?# device support

arch/arm/mach-s5pv210/mach-goni.c new file +65 -0
new file mode 100644
index 0000000..4863b13
@@ -0,0 +1,98 @@
+/* linux/arch/arm/mach-s5pv210/mach-goni.c
+ *
+ * Copyright (c) 2010 Samsung Electronics Co., Ltd.
+ * ? ? ? ? ? http://www.samsung.com/
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+#include <linux/kernel.h>
+#include <linux/types.h>
+#include <linux/init.h>
+#include <linux/serial_core.h>
+
+#include <asm/mach/arch.h>
+#include <asm/mach/map.h>
+#include <asm/setup.h>
+#include <asm/mach-types.h>
+
+#include <mach/map.h>
+#include <mach/regs-clock.h>
+
+#include <plat/regs-serial.h>
+#include <plat/s5pv210.h>
+#include <plat/devs.h>
+#include <plat/cpu.h>
+
+/* Following are default values for UCON, ULCON and UFCON UART registers */
+#define S5PV210_UCON_DEFAULT (S3C2410_UCON_TXILEVEL | ? ? ? ?\
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_RXILEVEL | ? ? ? ?\
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_TXIRQMODE | ? ? ? \
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_RXIRQMODE | ? ? ? \
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_RXFIFO_TOI | ? ? ?\
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2443_UCON_RXERR_IRQEN)
+
+#define S5PV210_ULCON_DEFAULT ? ? ? ?S3C2410_LCON_CS8
+
+#define S5PV210_UFCON_DEFAULT ? ? ? ?(S3C2410_UFCON_FIFOMODE | ? ? ? \
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S5PV210_UFCON_TXTRIG4 | ? ? ? ?\
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S5PV210_UFCON_RXTRIG4)
+
+static struct s3c2410_uartcfg goni_uartcfgs[] __initdata = {
+ ? ? [0] = {
+ ? ? ? ? ? ? .hwport ? ? ? ? = 0,
+ ? ? ? ? ? ? .flags ? ? ? ? ?= 0,
+ ? ? ? ? ? ? .ucon ? ? ? ? ? = S5PV210_UCON_DEFAULT,
+ ? ? ? ? ? ? .ulcon ? ? ? ? ?= S5PV210_ULCON_DEFAULT,
+ ? ? ? ? ? ? .ufcon ? ? ? ? ?= S5PV210_UFCON_DEFAULT,
+ ? ? },
+ ? ? [1] = {
+ ? ? ? ? ? ? .hwport ? ? ? ? = 1,
+ ? ? ? ? ? ? .flags ? ? ? ? ?= 0,
+ ? ? ? ? ? ? .ucon ? ? ? ? ? = S5PV210_UCON_DEFAULT,
+ ? ? ? ? ? ? .ulcon ? ? ? ? ?= S5PV210_ULCON_DEFAULT,
+ ? ? ? ? ? ? .ufcon ? ? ? ? ?= S5PV210_UFCON_DEFAULT,
+ ? ? },
+ ? ? [2] = {
+ ? ? ? ? ? ? .hwport ? ? ? ? = 2,
+ ? ? ? ? ? ? .flags ? ? ? ? ?= 0,
+ ? ? ? ? ? ? .ucon ? ? ? ? ? = S5PV210_UCON_DEFAULT,
+ ? ? ? ? ? ? .ulcon ? ? ? ? ?= S5PV210_ULCON_DEFAULT,
+ ? ? ? ? ? ? .ufcon ? ? ? ? ?= S5PV210_UFCON_DEFAULT,
+ ? ? },
+ ? ? [3] = {

arch/arm/mach-s5pv210/mach-goni.c line 75

Quoted 10 lines
arch/arm/mach-s5pv210/mach-goni.c new file +10 -0
+ ? ? ? ? ? ? .hwport ? ? ? ? = 3,
+ ? ? ? ? ? ? .flags ? ? ? ? ?= 0,
+ ? ? ? ? ? ? .ucon ? ? ? ? ? = S5PV210_UCON_DEFAULT,
+ ? ? ? ? ? ? .ulcon ? ? ? ? ?= S5PV210_ULCON_DEFAULT,
+ ? ? ? ? ? ? .ufcon ? ? ? ? ?= S5PV210_UFCON_DEFAULT,
+ ? ? },
+};
+
+static struct platform_device *goni_devices[] __initdata = {
+};

If you promise to actually populate this, then it can stay.

Quoted 12 lines
arch/arm/mach-s5pv210/mach-goni.c new file +12 -0
+static void __init goni_map_io(void)
+{
+ ? ? s5p_init_io(NULL, 0, S5P_VA_CHIPID);
+ ? ? s3c24xx_init_clocks(24000000);
+ ? ? s3c24xx_init_uarts(goni_uartcfgs, ARRAY_SIZE(goni_uartcfgs));
+}
+
+static void __init goni_machine_init(void)
+{
+ ? ? platform_add_devices(goni_devices, ARRAY_SIZE(goni_devices));
+}
+

arch/arm/mach-s5pv210/mach-goni.c line 97

Quoted 10 lines
arch/arm/mach-s5pv210/mach-goni.c new file +10 -0
+MACHINE_START(GONI, "GONI")
+ ? ? /* Maintainers: Kyungmin Park <[email protected]> */
+ ? ? .phys_io ? ? ? ?= S3C_PA_UART & 0xfff00000,
+ ? ? .io_pg_offst ? ?= (((u32)S3C_VA_UART) >> 18) & 0xfffc,
+ ? ? .boot_params ? ?= S5P_PA_SDRAM + 0x100,
+ ? ? .init_irq ? ? ? = s5pv210_init_irq,
+ ? ? .map_io ? ? ? ? = goni_map_io,
+ ? ? .init_machine ? = goni_machine_init,
+ ? ? .timer ? ? ? ? ?= &s3c24xx_timer,
+MACHINE_END

--
Ben

Q: ? ? ?What's a light-year?
A: ? ? ?One-third less calories than a regular year.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#3 lore raw

PATCH 1/1 ARM: S5PV210: Add GONI board support

Quoted 11 lines · Kyungmin Park
Quoted 9 lines · Ben Dooks
Quoted 4 lines · Joonyoung Shim

This is for samsung GONI board using s5pc110.

I'll think about adding this, however it is very late in the development cycle, and the only thing saving it from immediate stalling until the next round is the fact that it is so simple.

Quoted 7 lines

Hi,

In the previous time, Marek sent the s5pv210 patch including the aquila board support.
But in this merge cycle, it doesn't included. of course all s5pv210 patches too, Please find the patch subject "ARM: S5PV210: add Aquila board" and check it again.

I thought he said it depended on some other work and it was being held until this was sorted. Will check with Marek again and find out what is going on. If it is mergeable I will add it in with the final pull request to Russell to sort out the S5PC100 re-arangement that is currently going on.

Quoted 160 lines

Thank you,
Kyungmin Park

Quoted 158 lines
Quoted 110 lines

---

?arch/arm/mach-s5pv210/Kconfig ? ? | ? ?8 +++
?arch/arm/mach-s5pv210/Makefile ? ?| ? ?1 +
?arch/arm/mach-s5pv210/mach-goni.c | ? 98 +++++++++++++++++++++++++++++++++++++

?3 files changed, 107 insertions(+), 0 deletions(-) ?create mode 100644 arch/arm/mach-s5pv210/mach-goni.c

arch/arm/mach-s5pv210/Kconfig +0 -0
index 7601c28..83b15b2 100644
@@ -36,6 +36,14 @@ config MACH_SMDKC110

? ? ? ? Machine support for Samsung SMDKC110
? ? ? ? S5PC110(MCP) is one of package option of S5PV210

arch/arm/mach-s5pv210/Kconfig +8 -0
+config MACH_GONI
+ ? ? bool "GONI"
+ ? ? select CPU_S5PV210
+ ? ? select ARCH_SPARSEMEM_ENABLE
+ ? ? help
+ ? ? ? Machine support for Samsung GONI board
+ ? ? ? S5PC110(MCP) is one of package option of S5PV210
+

?endchoice

?endif

arch/arm/mach-s5pv210/Makefile +0 -0
index 9982781..5135577 100644
@@ -19,6 +19,7 @@ obj-$(CONFIG_CPU_S5PV210) ? += setup-i2c0.o
 

?obj-$(CONFIG_MACH_SMDKV210) ?+= mach-smdkv210.o ?obj-$(CONFIG_MACH_SMDKC110) ?+= mach-smdkc110.o +obj-$(CONFIG_MACH_GONI) ? ? ? ? ? ? ?+= mach-goni.o

?# device support

arch/arm/mach-s5pv210/mach-goni.c new file +65 -0
new file mode 100644
index 0000000..4863b13
@@ -0,0 +1,98 @@
+/* linux/arch/arm/mach-s5pv210/mach-goni.c
+ *
+ * Copyright (c) 2010 Samsung Electronics Co., Ltd.
+ * ? ? ? ? ? http://www.samsung.com/
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+#include <linux/kernel.h>
+#include <linux/types.h>
+#include <linux/init.h>
+#include <linux/serial_core.h>
+
+#include <asm/mach/arch.h>
+#include <asm/mach/map.h>
+#include <asm/setup.h>
+#include <asm/mach-types.h>
+
+#include <mach/map.h>
+#include <mach/regs-clock.h>
+
+#include <plat/regs-serial.h>
+#include <plat/s5pv210.h>
+#include <plat/devs.h>
+#include <plat/cpu.h>
+
+/* Following are default values for UCON, ULCON and UFCON UART registers */
+#define S5PV210_UCON_DEFAULT (S3C2410_UCON_TXILEVEL | ? ? ? ?\
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_RXILEVEL | ? ? ? ?\
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_TXIRQMODE | ? ? ? \
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_RXIRQMODE | ? ? ? \
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_RXFIFO_TOI | ? ? ?\
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2443_UCON_RXERR_IRQEN)
+
+#define S5PV210_ULCON_DEFAULT ? ? ? ?S3C2410_LCON_CS8
+
+#define S5PV210_UFCON_DEFAULT ? ? ? ?(S3C2410_UFCON_FIFOMODE | ? ? ? \
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S5PV210_UFCON_TXTRIG4 | ? ? ? ?\
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S5PV210_UFCON_RXTRIG4)
+
+static struct s3c2410_uartcfg goni_uartcfgs[] __initdata = {
+ ? ? [0] = {
+ ? ? ? ? ? ? .hwport ? ? ? ? = 0,
+ ? ? ? ? ? ? .flags ? ? ? ? ?= 0,
+ ? ? ? ? ? ? .ucon ? ? ? ? ? = S5PV210_UCON_DEFAULT,
+ ? ? ? ? ? ? .ulcon ? ? ? ? ?= S5PV210_ULCON_DEFAULT,
+ ? ? ? ? ? ? .ufcon ? ? ? ? ?= S5PV210_UFCON_DEFAULT,
+ ? ? },
+ ? ? [1] = {
+ ? ? ? ? ? ? .hwport ? ? ? ? = 1,
+ ? ? ? ? ? ? .flags ? ? ? ? ?= 0,
+ ? ? ? ? ? ? .ucon ? ? ? ? ? = S5PV210_UCON_DEFAULT,
+ ? ? ? ? ? ? .ulcon ? ? ? ? ?= S5PV210_ULCON_DEFAULT,
+ ? ? ? ? ? ? .ufcon ? ? ? ? ?= S5PV210_UFCON_DEFAULT,
+ ? ? },
+ ? ? [2] = {
+ ? ? ? ? ? ? .hwport ? ? ? ? = 2,
+ ? ? ? ? ? ? .flags ? ? ? ? ?= 0,
+ ? ? ? ? ? ? .ucon ? ? ? ? ? = S5PV210_UCON_DEFAULT,
+ ? ? ? ? ? ? .ulcon ? ? ? ? ?= S5PV210_ULCON_DEFAULT,
+ ? ? ? ? ? ? .ufcon ? ? ? ? ?= S5PV210_UFCON_DEFAULT,
+ ? ? },
+ ? ? [3] = {

arch/arm/mach-s5pv210/mach-goni.c line 75

Quoted 10 lines
arch/arm/mach-s5pv210/mach-goni.c new file +10 -0
+ ? ? ? ? ? ? .hwport ? ? ? ? = 3,
+ ? ? ? ? ? ? .flags ? ? ? ? ?= 0,
+ ? ? ? ? ? ? .ucon ? ? ? ? ? = S5PV210_UCON_DEFAULT,
+ ? ? ? ? ? ? .ulcon ? ? ? ? ?= S5PV210_ULCON_DEFAULT,
+ ? ? ? ? ? ? .ufcon ? ? ? ? ?= S5PV210_UFCON_DEFAULT,
+ ? ? },
+};
+
+static struct platform_device *goni_devices[] __initdata = {
+};

If you promise to actually populate this, then it can stay.

Quoted 12 lines
arch/arm/mach-s5pv210/mach-goni.c new file +12 -0
+static void __init goni_map_io(void)
+{
+ ? ? s5p_init_io(NULL, 0, S5P_VA_CHIPID);
+ ? ? s3c24xx_init_clocks(24000000);
+ ? ? s3c24xx_init_uarts(goni_uartcfgs, ARRAY_SIZE(goni_uartcfgs));
+}
+
+static void __init goni_machine_init(void)
+{
+ ? ? platform_add_devices(goni_devices, ARRAY_SIZE(goni_devices));
+}
+

arch/arm/mach-s5pv210/mach-goni.c line 97

Quoted 10 lines
arch/arm/mach-s5pv210/mach-goni.c new file +10 -0
+MACHINE_START(GONI, "GONI")
+ ? ? /* Maintainers: Kyungmin Park <[email protected]> */
+ ? ? .phys_io ? ? ? ?= S3C_PA_UART & 0xfff00000,
+ ? ? .io_pg_offst ? ?= (((u32)S3C_VA_UART) >> 18) & 0xfffc,
+ ? ? .boot_params ? ?= S5P_PA_SDRAM + 0x100,
+ ? ? .init_irq ? ? ? = s5pv210_init_irq,
+ ? ? .map_io ? ? ? ? = goni_map_io,
+ ? ? .init_machine ? = goni_machine_init,
+ ? ? .timer ? ? ? ? ?= &s3c24xx_timer,
+MACHINE_END

--
Ben

Q: ? ? ?What's a light-year?
A: ? ? ?One-third less calories than a regular year.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Signature · 5 lines
-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.
#4 lore raw

PATCH 1/1 ARM: S5PV210: Add GONI board support

In reply to Kyungmin Park
Quoted 5 lines · Kyungmin Park

In the previous time, Marek sent the s5pv210 patch including the aquila board support.
But in this merge cycle, it doesn't included. of course all s5pv210 patches too, Please find the patch subject "ARM: S5PV210: add Aquila board" and check it again.

The merge windows are not for people to send their patches which they've been sitting on to mailing lists. The merge window is for the patches prepared and reviewed _prior_ to the merge window opening, and which have been tested in the linux-next tree to be merged into Linus' tree.

I make this comment because it seems to me that as soon as the merge window opened, this mailing list immediately got flooded with Samsung patches. This is not the way it works.

In future, please prepare your patches before the merge window, and submit them to the mailing list for review as soon as they're prepared. Once they've been reviewed, they can be queued and sit in linux-next for a while for the following merge window.

#5 lore raw

PATCH 1/1 ARM: S5PV210: Add GONI board support

Quoted 11 lines · Russell King - ARM Linux
Quoted 5 lines · Kyungmin Park

In the previous time, Marek sent the s5pv210 patch including the aquila board support.
But in this merge cycle, it doesn't included. of course all s5pv210 patches too, Please find the patch subject "ARM: S5PV210: add Aquila board" and check it again.

The merge windows are not for people to send their patches which they've been sitting on to mailing lists. ?The merge window is for the patches prepared and reviewed _prior_ to the merge window opening, and which have been tested in the linux-next tree to be merged into Linus' tree.

Right, I know that. but please note that the aquila board support mail is posted it at Mar 25. 2 month ago!!!. the May 20 is updated version with recent samsung patches.

Quoted 11 lines

I make this comment because it seems to me that as soon as the merge window opened, this mailing list immediately got flooded with Samsung patches. ?This is not the way it works.

In future, please prepare your patches before the merge window, and submit them to the mailing list for review as soon as they're prepared. Once they've been reviewed, they can be queued and sit in linux-next for a while for the following merge window.

I also ask please talk to ben how to merge samsung patches in the future I proper send the patches and request to pull too.

Thank you,
Kyungmin Park

Quoted 6 lines

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel