Hyperv detection - code cleanup
Subsystems (2)
PATCH 1/2 Hyperv detection - code cleanup
From: K. Y. Srinivasan <[email protected]>
Subject: Code cleanup - consolidate all hyperv related definitions into one header file.
arch/x86/include/asm/hyperv.h +7 -0
@@ -190,4 +190,11 @@#define HV_STATUS_INVALID_HYPERCALL_INPUT 3#define HV_STATUS_INVALID_ALIGNMENT 4 +struct ms_hyperv_info { +u32 features; +u32 hints; +}; + +extern struct ms_hyperv_info ms_hyperv; +#endif
arch/x86/include/asm/mshyperv.h deleted +0 -14
@@ -1,14 +0,0 @@ -#ifndef _ASM_X86_MSHYPER_H -#define _ASM_X86_MSHYPER_H - -#include <linux/types.h> -#include <asm/hyperv.h> - -struct ms_hyperv_info { -u32 features; -u32 hints; -}; - -extern struct ms_hyperv_info ms_hyperv; - -#endif
arch/x86/kernel/cpu/mshyperv.c +0 -1
@@ -15,7 +15,6 @@#include <asm/processor.h> #include <asm/hypervisor.h> #include <asm/hyperv.h> -#include <asm/mshyperv.h> struct ms_hyperv_info ms_hyperv;EXPORT_SYMBOL (ms_hyperv);
H. Peter Anvin
reviewerQuoted 5 lines · Ky Srinivasan
From: K. Y. Srinivasan <[email protected]>
Subject: Code cleanup - consolidate all hyperv related definitions into one header file.
How will this affect KVM? I was under the impression that this was separated out as a constants-only header file for a reason.
-hpa
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
On 5/19/2010 at 1:51 PM, in message <[email protected]>, "H. Peter
Quoted 9 lines · Anvin
Quoted 5 lines · Ky Srinivasan
From: K. Y. Srinivasan <[email protected]>
Subject: Code cleanup - consolidate all hyperv related definitions into one header file.How will this affect KVM? I was under the impression that this was separated out as a constants-only header file for a reason.
I was under the impression that hyperv.h was for all public definitions of Hyperv. I am hoping Avi can shed some light on KVM implications (if any).
Regards,
K. Y
Quoted 2 lines
-hpa
Quoted 11 lines · H. Peter Anvin
Quoted 5 lines · Ky Srinivasan
From: K. Y. Srinivasan<[email protected]>
Subject: Code cleanup - consolidate all hyperv related definitions into one header file.How will this affect KVM? I was under the impression that this was separated out as a constants-only header file for a reason.
It's exported, so any types need to be compatible with userspace (i.e. __u32).
Signature · 1 line
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
H. Peter Anvin
reviewerQuoted 8 lines · Avi Kivity
Quoted 7 lines · H. Peter Anvin
Quoted 5 lines · Ky Srinivasan
From: K. Y. Srinivasan<[email protected]>
Subject: Code cleanup - consolidate all hyperv related definitions into one header file.
Quoted 6 lines
Quoted 2 lines
How will this affect KVM? I was under the impression that this was separated out as a constants-only header file for a reason.
It's exported, so any types need to be compatible with userspace (i.e.
__u32).
... and certainly no prototypes for kernel-only functionality. Right, that's what I thought. So NAK on this patch, too.
-hpa