Skip to contentSkip to conversation

mtd: pxa3xx_nand: introduce common timing to reduce read id times

PATCH New Haojian Zhuang 3 participants 3 messages May 14, 2010 – May 24, 2010 Memory technology devices (MTD)

lore
Share & tools
lore
#0 lore raw

PATCH 2/20 mtd: pxa3xx_nand: introduce common timing to reduce read id times

#1 lore raw

PATCH 2/20 mtd: pxa3xx_nand: introduce common timing to reduce read id times

Quoted 72 lines · Haojian Zhuang

From 35a06a21643049e146aba95057e7fe89c55d4b32 Mon Sep 17 00:00:00 2001
From: Lei Wen <[email protected]>
Date: Mon, 22 Mar 2010 10:24:48 +0800
Subject: [PATCH] mtd: pxa3xx_nand: introduce common timing to reduce read id times

We certainly don't need to send read id command times by times, since we already know what the id is after the first read id...

So create a common timing which could ensure it would successfully read id out all supported chip. Then follow the build-in table to reconfigure the timing.

---
 drivers/mtd/nand/pxa3xx_nand.c |   33 +++++++++++++++++----------------
 1 files changed, 17 insertions(+), 16 deletions(-)
drivers/mtd/nand/pxa3xx_nand.c +6 -6
index da40b9a..5658398 100644
@@ -225,7 +225,13 @@ const static struct pxa3xx_nand_cmdset cmdset = {
 	.lock_status	= 0x007A,
 };
 
+/**
+ * The timing defined in the builtin_flash_types[0]
+ * could be considered as the common timing which is used to
+ * detect the chip id before we know how to optimize further
+ */
 static struct pxa3xx_nand_flash __devinitdata builtin_flash_types[] = {
+{ 0, 0, 0, 0, 0, 0, { 40, 80, 60, 100, 80, 100, 90000, 400, 40, }, },
 { 0x46ec, 32, 512, 16, 16, 4096, { 10, 0, 20, 40, 30, 40, 11123, 110, 10, }, },
 { 0xdaec, 64, 2048, 8, 8, 2048, { 10, 0, 20, 40, 30, 40, 11123, 110, 10, }, },
 { 0xd7ec, 128, 4096, 8, 8, 8192, { 10, 0, 20, 40, 30, 40, 11123, 110, 10, }, },
@@ -850,12 +856,6 @@ static int pxa3xx_nand_config_flash(struct
 pxa3xx_nand_info *info,
 	struct pxa3xx_nand_platform_data *pdata = pdev->dev.platform_data;
 	uint32_t ndcr = 0x00000FFF; /* disable all interrupts */
 
-	if (f->page_size != 2048 && f->page_size != 512)
-		return -EINVAL;
-
-	if (f->flash_width != 16 && f->flash_width != 8)
-		return -EINVAL;
-
 	/* calculate flash information */
 	info->oob_size = (f->page_size == 2048) ? 64 : 16;
drivers/mtd/nand/pxa3xx_nand.c +5 -9
 	info->read_id_bytes = (f->page_size == 2048) ? 4 : 2;
@@ -967,23 +967,24 @@ static int pxa3xx_nand_detect_flash(struct
 pxa3xx_nand_info *info,
 		if (pxa3xx_nand_detect_config(info) == 0)
 			return 0;
 
-	for (i = 0; i < ARRAY_SIZE(builtin_flash_types); i++) {
+	f = &builtin_flash_types[0];
+	pxa3xx_nand_config_flash(info, f);
+	if (__readid(info, &id))
+		goto fail_detect;
 
+	for (i = 1; i < ARRAY_SIZE(builtin_flash_types); i++) {
 		f = &builtin_flash_types[i];
-
-		if (pxa3xx_nand_config_flash(info, f))
-			continue;
-
-		if (__readid(info, &id))
-			continue;
-
-		if (id == f->chip_id)

drivers/mtd/nand/pxa3xx_nand.c static int pxa3xx_nand_detect_flash(struct · line 986

Quoted 10 lines
drivers/mtd/nand/pxa3xx_nand.c +5 -1
+		if (f->chip_id == id) {
+			dev_info(&info->pdev->dev, "detect chip id: 0x%x\n", id);
+			pxa3xx_nand_config_flash(info, f);
 			return 0;
+		}
 	}
 
 	dev_warn(&info->pdev->dev,
-		 "failed to detect configured nand flash; found %04x instead of\n",
+			"failed to detect configured nand flash; found %04x instead of\n",

Instead of what?
And, what if the flash is not listed in the builtin_flash_types? Does it really mean it's
-ENODEV?

Quoted 5 lines
drivers/mtd/nand/pxa3xx_nand.c +1 -0
 		 id);
+fail_detect:
 	return -ENODEV;
 }
Signature · 2 lines
Sincerely yours,
Mike.
#2 lore raw

PATCH 2/20 mtd: pxa3xx_nand: introduce common timing to reduce read id times

Quoted 86 lines · Mike Rapoport
Quoted 85 lines · Haojian Zhuang

From 35a06a21643049e146aba95057e7fe89c55d4b32 Mon Sep 17 00:00:00 2001
From: Lei Wen <[email protected]>
Date: Mon, 22 Mar 2010 10:24:48 +0800
Subject: [PATCH] mtd: pxa3xx_nand: introduce common timing to reduce read id times

We certainly don't need to send read id command times by times, since we already know what the id is after the first read id...

So create a common timing which could ensure it would successfully read id out all supported chip. Then follow the build-in table to reconfigure the timing.

---
?drivers/mtd/nand/pxa3xx_nand.c | ? 33 +++++++++++++++++---------------- ?1 files changed, 17 insertions(+), 16 deletions(-)

drivers/mtd/nand/pxa3xx_nand.c +6 -0
index da40b9a..5658398 100644
@@ -225,7 +225,13 @@ const static struct pxa3xx_nand_cmdset cmdset = {
 ? ? ? ?.lock_status ? ?= 0x007A,
 ?};
 
+/**
+ * The timing defined in the builtin_flash_types[0]
+ * could be considered as the common timing which is used to
+ * detect the chip id before we know how to optimize further
+ */
 ?static struct pxa3xx_nand_flash __devinitdata builtin_flash_types[] = {
+{ 0, 0, 0, 0, 0, 0, { 40, 80, 60, 100, 80, 100, 90000, 400, 40, }, },
 ?{ 0x46ec, 32, 512, 16, 16, 4096, { 10, 0, 20, 40, 30, 40, 11123, 110, 10,
 }, },
 ?{ 0xdaec, 64, 2048, 8, 8, 2048, { 10, 0, 20, 40, 30, 40, 11123, 110, 10,

}, },
?{ 0xd7ec, 128, 4096, 8, 8, 8192, { 10, 0, 20, 40, 30, 40, 11123, 110, 10, }, },

drivers/mtd/nand/pxa3xx_nand.c +0 -0
@@ -850,12 +856,6 @@ static int pxa3xx_nand_config_flash(struct
 pxa3xx_nand_info *info,
 ? ? ? ?struct pxa3xx_nand_platform_data *pdata = pdev->dev.platform_data;

? ? ? ?uint32_t ndcr = 0x00000FFF; /* disable all interrupts */

- ? ? ? if (f->page_size != 2048 && f->page_size != 512)
- ? ? ? ? ? ? ? return -EINVAL;

drivers/mtd/nand/pxa3xx_nand.c +0 -4
-
- ? ? ? if (f->flash_width != 16 && f->flash_width != 8)
- ? ? ? ? ? ? ? return -EINVAL;
-

? ? ? ?/* calculate flash information */
? ? ? ?info->oob_size = (f->page_size == 2048) ? 64 : 16; ? ? ? ?info->read_id_bytes = (f->page_size == 2048) ? 4 : 2;

drivers/mtd/nand/pxa3xx_nand.c +9 -9
@@ -967,23 +967,24 @@ static int pxa3xx_nand_detect_flash(struct
 pxa3xx_nand_info *info,
 ? ? ? ? ? ? ? ?if (pxa3xx_nand_detect_config(info) == 0)
 ? ? ? ? ? ? ? ? ? ? ? ?return 0;
 
- ? ? ? for (i = 0; i < ARRAY_SIZE(builtin_flash_types); i++) {
+ ? ? ? f = &builtin_flash_types[0];
+ ? ? ? pxa3xx_nand_config_flash(info, f);
+ ? ? ? if (__readid(info, &id))
+ ? ? ? ? ? ? ? goto fail_detect;
 
+ ? ? ? for (i = 1; i < ARRAY_SIZE(builtin_flash_types); i++) {
 ? ? ? ? ? ? ? ?f = &builtin_flash_types[i];
-
- ? ? ? ? ? ? ? if (pxa3xx_nand_config_flash(info, f))
- ? ? ? ? ? ? ? ? ? ? ? continue;
-
- ? ? ? ? ? ? ? if (__readid(info, &id))
- ? ? ? ? ? ? ? ? ? ? ? continue;
-
- ? ? ? ? ? ? ? if (id == f->chip_id)
+ ? ? ? ? ? ? ? if (f->chip_id == id) {
+ ? ? ? ? ? ? ? ? ? ? ? dev_info(&info->pdev->dev, "detect chip id:
 0x%x\n", id);
+ ? ? ? ? ? ? ? ? ? ? ? pxa3xx_nand_config_flash(info, f);
 ? ? ? ? ? ? ? ? ? ? ? ?return 0;
+ ? ? ? ? ? ? ? }
 ? ? ? ?}
 
Quoted 10 lines

drivers/mtd/nand/pxa3xx_nand.c static int pxa3xx_nand_detect_flash(struct · line 989

Quoted 5 lines
drivers/mtd/nand/pxa3xx_nand.c +1 -1
 ? ? ? ?dev_warn(&info->pdev->dev,
- ? ? ? ? ? ? ? ?"failed to detect configured nand flash; found %04x
 instead of\n",
+ ? ? ? ? ? ? ? ? ? ? ? "failed to detect configured nand flash; found
 %04x instead of\n",

Instead of what?
And, what if the flash is not listed in the builtin_flash_types? Does it really mean it's
-ENODEV?

Yes, when the flash type is not listed in, you should add the new one manually. For now, just add two lines is enough for a new type flash.

The reason why we do this is for different flash has different attribute that need to be seperated supported.
For example, if one flash need different timing and higher ecc(This function is not included in this patch set, I would submit it later), the driver need to know it to deal in correct behavior.

Best regards,
Lei