xl: allow nameless domains to be named
PATCH 1/1 xl: allow nameless domains to be named
At present, find_domain() will exit(2) if you specify a domain by number, but that domain doesn't have a corresponding name. However, nothing seem to critically depend on common_domname being set, and the test prevents dom0 or other nameless domains from being named. So just remove the check.
tools/libxl/xl_cmdimpl.c +0 -4
@@ -138,10 +138,6 @@exit (2 ); } common_domname = was_name ? p :libxl_domid_to_name (&ctx, domid); -if (!common_domname) { -fprintf (stderr,"%s is an invalid domain identifier.\n" , p); -exit (2 ); - } } #define LOG(_f, _a...) dolog(__FILE__, __LINE__, __func__, _f "\n", ##_a)
Hi jeremy,
Quoted 5 lines · Jeremy Fitzhardinge
At present,
find_domain()will exit(2) if you specify a domain by number, but that domain doesn't have a corresponding name. However, nothing seem to critically depend oncommon_domnamebeing set, and the test prevents dom0 or other nameless domains from being named. So just remove the check.
Thank you, for now, remove the check seems to be the solution.
Quoted 2 lines
Signed-off-by Jeremy Fitzhardinge <[email protected]>
Quoted 24 lines
diff -r
ba7fdd53f44ctools/libxl/xl_cmdimpl.ctools/libxl/xl_cmdimpl.c +0
-4@@ -138,10 +138,6 @@exit (2 ); } common_domname = was_name ? p :libxl_domid_to_name (&ctx, domid); -if (!common_domname) { -fprintf (stderr,"%s is an invalid domain identifier.\n" , p); -exit (2 ); - } } #define LOG(_f, _a...) dolog(__FILE__, __LINE__, __func__, _f "\n", ##_a)_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel
Signature · 2 lines
Regards Yang Hongyang