sctp: use memdup_user to copy data from userspace
Subsystems (2)
PATCH 4/4 sctp: use memdup_user to copy data from userspace
Use common function to simply code.
Signed-off-by Shan Wei <[email protected]>
--- net/sctp/socket.c | 22 ++++++---------------- 1 files changed, 6 insertions(+), 16 deletions(-)
net/sctp/socket.c +6 -16
@@ -3201,14 +3201,9 @@ static int sctp_setsockopt_hmac_ident(struct sock *sk,if (optlen <sizeof (struct sctp_hmacalgo ))return -EINVAL ; - hmacs =kmalloc (optlen,GFP_KERNEL ); -if (!hmacs) -return -ENOMEM ; - -if (copy_from_user (hmacs, optval, optlen)) { - err = -EFAULT ; - goto out; - } + hmacs=memdup_user (optval, optlen); +if (IS_ERR (hmacs)) +return PTR_ERR (hmacs); idents = hmacs->shmac_num_idents; if (idents = 0 || idents > SCTP_AUTH_NUM_HMACS ||
@@ -3243,14 +3238,9 @@ static int sctp_setsockopt_auth_key(struct sock *sk,if (optlen <=sizeof (struct sctp_authkey ))return -EINVAL ; - authkey =kmalloc (optlen,GFP_KERNEL ); -if (!authkey) -return -ENOMEM ; - -if (copy_from_user (authkey, optval, optlen)) { - ret = -EFAULT ; - goto out; - } + authkey=memdup_user (optval, optlen); +if (IS_ERR (authkey)) +return PTR_ERR (authkey);if (authkey->sca_keylength > optlen -sizeof (struct sctp_authkey )) { ret = -EINVAL ;
Signature · 1 line
1.7.0