Skip to contentSkip to conversation

s5pc1xx: gpio: bug fix at gpio_set_pull function

PATCH New Minkyu Kang 2 participants 2 messages May 28, 2010 – May 31, 2010 GPIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 s5pc1xx: gpio: bug fix at gpio_set_pull function

When set to PULL_NONE, gpio_set_pull function is returned without write the register.
This patch fixed it.

---
 drivers/gpio/s5p_gpio.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/gpio/s5p_gpio.c +1 -1
index 0439477..a1bcddc 100644
@@ -96,7 +96,7 @@ void gpio_set_pull(struct s5p_gpio_bank *bank, int gpio, int mode)
 		value |= PULL_MODE(gpio, mode);
 		break;
 	default:
-		return;
+		break;
 	}
 
 	writel(value, &bank->pull);
Signature · 1 line
1.6.3.3
#1 lore raw

PATCH 1/1 s5pc1xx: gpio: bug fix at gpio_set_pull function

Quoted 9 lines · Minkyu Kang

When set to PULL_NONE, gpio_set_pull function is returned without write the register.
This patch fixed it.

---
?drivers/gpio/s5p_gpio.c | ? ?2 +-
?1 files changed, 1 insertions(+), 1 deletions(-)

Applied to u-boot-samsung.

Minkyu Kang

Signature · 2 lines
from. prom.
www.promsoft.net