Skip to contentSkip to conversation

ARM/footbridge: fix wrong parenthesis

PATCH New Wan ZongShun 2 participants 3 messages Jun 4, 2010 – Jun 7, 2010

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm/footbridge architecture
lore
Share & tools
lore

Wan ZongShun

author
#0 lore raw

PATCH 1/1 ARM/footbridge: fix wrong parenthesis

There is a wrong redundant right parenthesis in this code.

Signed-off-by Wan ZongShun <[email protected]>
---
 arch/arm/mach-footbridge/common.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-footbridge/common.c +1 -1
index e3bc3f6..cdbea55 100644
@@ -232,7 +232,7 @@ EXPORT_SYMBOL(__bus_to_virt);
 
 unsigned long __pfn_to_bus(unsigned long pfn)
 {
-	return __pfn_to_phys(pfn) + (fb_bus_sdram_offset() - PHYS_OFFSET));
+	return __pfn_to_phys(pfn + (fb_bus_sdram_offset() - PHYS_OFFSET));
 }
 EXPORT_SYMBOL(__pfn_to_bus);
Signature · 1 line
1.6.3.3
#1 lore raw

PATCH 1/1 ARM/footbridge: fix wrong parenthesis

Quoted 1 line · Wan ZongShun

There is a wrong redundant right parenthesis in this code.

This patch is wrong.

arch/arm/mach-footbridge/common.c EXPORT_SYMBOL(__bus_to_virt); · line 235

Quoted 4 lines

unsigned long __pfn_to_bus(unsigned long pfn)
{

arch/arm/mach-footbridge/common.c +1 -1
-	return __pfn_to_phys(pfn) + (fb_bus_sdram_offset() - PHYS_OFFSET));
+	return __pfn_to_phys(pfn + (fb_bus_sdram_offset() - PHYS_OFFSET));

It makes no sense to add byte address offsets to a PFN. The correct solution is to delete the right paren at the end of the line instead.

author
#2 lore raw

PATCH 1/1 ARM/footbridge: fix wrong parenthesis

So should I send a true one again or fix it by your self?

2010/6/7, Russell King - ARM Linux <[email protected]>:

Quoted 13 lines · Wan ZongShun
Quoted 1 line

There is a wrong redundant right parenthesis in this code.

This patch is wrong.

arch/arm/mach-footbridge/common.c EXPORT_SYMBOL(__bus_to_virt); · line 235

Quoted 4 lines

unsigned long __pfn_to_bus(unsigned long pfn)
{

arch/arm/mach-footbridge/common.c +1 -1
-	return __pfn_to_phys(pfn) + (fb_bus_sdram_offset() - PHYS_OFFSET));
+	return __pfn_to_phys(pfn + (fb_bus_sdram_offset() - PHYS_OFFSET));

It makes no sense to add byte address offsets to a PFN. The correct solution is to delete the right paren at the end of the line instead.

Signature · 10 lines
*linux-arm-kernel mailing list
mail addr:linux-arm-kernel at lists.infradead.org
you can subscribe by:
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

* linux-arm-NUC900 mailing list
mail addr:NUC900 at googlegroups.com
main web: https://groups.google.com/group/NUC900
you can subscribe it by sending me mail:
mcuos.com at gmail.com