MTD/pxa: use __devinit for pxa2xx_flash_probe
PATCH v2 1/3 MTD/pxa: use __devinit for pxa2xx_flash_probe
This patch is to use the '__devinit' for pxa2xx_flash_probe.
Signed-off-by Wan ZongShun <[email protected]>
Acked-by Eric Miao <[email protected]>
--- drivers/mtd/maps/pxa2xx-flash.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mtd/maps/pxa2xx-flash.c +1 -1
@@ -51,7 +51,7 @@ struct pxa2xx_flash_info {static const char *probes[] = {"RedBoot" ,"cmdlinepart" ,NULL }; -static int __init pxa2xx_flash_probe (struct platform_device *pdev) +static int __devinit pxa2xx_flash_probe (struct platform_device *pdev) {struct flash_platform_data *flash = pdev->dev.platform_data;struct pxa2xx_flash_info *info;
Signature · 1 line
1.6.3.3
PATCH v2 1/3 MTD/pxa: use __devinit for pxa2xx_flash_probe
Quoted 1 line · Wan ZongShun
This patch is to use the '
__devinit' forpxa2xx_flash_probe.
Why? Is it hot-pluggable device? I guess not...
Quoted 2 lines
Signed-off-by Wan ZongShun <[email protected]>Acked-by Eric Miao <[email protected]>
WBR, Sergei
PATCH v2 1/3 MTD/pxa: use __devinit for pxa2xx_flash_probe
Quoted 6 lines · Sergei Shtylyov
Quoted 1 line · Wan ZongShun
This patch is to use the '
__devinit' forpxa2xx_flash_probe.? Why? Is it hot-pluggable device? I guess not...
Then I guess the __devexit is not applicable to pxa2xx_flash_remove as well. Apart from the _probe() being unnecessarily built in when HOTPLUG is defined, is there any drawbacks. It does make code a little bit consistent from my POV.
Quoted 6 lines
Quoted 2 lines
Signed-off-by Wan ZongShun <[email protected]>Acked-by Eric Miao <[email protected]>WBR, Sergei