Skip to contentSkip to conversation

megaraid_sas locks down frame count to 8

DISCUSSION Hannes Reinecke 1 participant 1 message Jun 14, 2010 SCSI

lore
Share & tools
lore
#0 lore raw

Hi all,

we have this bit in drivers/scsi/megaraid/megaraid_sas.c:799

	if (frame_count > 7)
		frame_count = 8;

which is supposed to report the number of frames required to handle the passed in sg list.
This results in a nice memory scribble if we pass in a large enough sg list, as the sg list contents will then written in the memory area for the next frame.

Any comments here?

If it were me I would just remove that check, but
then LSI might have a valid reason for doing so.

Cheers,

Hannes
--
Dr. Hannes Reinecke zSeries & Storage
[email protected] +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html