ARM: remove unused ATAG

PATCH New Minkyu Kang 3 participants 7 messages Jun 18, 2010 – Jun 22, 2010 Arm (32-bit)

lore

Share & tools

lore

Minkyu Kang

author

2010-06-18 10:31 UTC #0 lore raw

PATCH 1/1 ARM: remove unused ATAG

ATAG_VIDEOLFB is not used anywhere.
The belowing warning is occurred due to this ATAG.

[    0.000000] Ignoring unrecognised tag 0x54410008

This patch fixed it.

Signed-off-by Minkyu Kang <[email protected]>

Signed-off-by Kyungmin Park <[email protected]>

---
 arch/arm/lib/bootm.c |   43 +++----------------------------------------
 1 files changed, 3 insertions(+), 40 deletions(-)

arch/arm/lib/bootm.c +3 ~~-40~~

index 128b7e3..5ac1302 100644
@@ -33,9 +33,7 @@ DECLARE_GLOBAL_DATA_PTR;
     defined (CONFIG_CMDLINE_TAG) || \
     defined (CONFIG_INITRD_TAG) || \
     defined (CONFIG_SERIAL_TAG) || \
-    defined (CONFIG_REVISION_TAG) || \
-    defined (CONFIG_VFD) || \
-    defined (CONFIG_LCD)
+    defined (CONFIG_REVISION_TAG)
 static void setup_start_tag (bd_t *bd);
 
 # ifdef CONFIG_SETUP_MEMORY_TAGS

@@ -49,10 +47,6 @@ static void setup_initrd_tag (bd_t *bd, ulong initrd_start,
 # endif
 static void setup_end_tag (bd_t *bd);
 
-# if defined (CONFIG_VFD) || defined (CONFIG_LCD)
-static void setup_videolfb_tag (gd_t *gd);
-# endif
-
 static struct tag *params;
 #endif /* CONFIG_SETUP_MEMORY_TAGS || CONFIG_CMDLINE_TAG || CONFIG_INITRD_TAG */

@@ -87,9 +81,7 @@ int do_bootm_linux(int flag, int argc, char *argv[], bootm_headers_t *images)
     defined (CONFIG_CMDLINE_TAG) || \
     defined (CONFIG_INITRD_TAG) || \
     defined (CONFIG_SERIAL_TAG) || \
-    defined (CONFIG_REVISION_TAG) || \
-    defined (CONFIG_LCD) || \
-    defined (CONFIG_VFD)
+    defined (CONFIG_REVISION_TAG)
 	setup_start_tag (bd);
 #ifdef CONFIG_SERIAL_TAG
 	setup_serial_tag (&params);

@@ -107,9 +99,6 @@ int do_bootm_linux(int flag, int argc, char *argv[], bootm_headers_t *images)
 	if (images->rd_start && images->rd_end)
 		setup_initrd_tag (bd, images->rd_start, images->rd_end);
 #endif
-#if defined (CONFIG_VFD) || defined (CONFIG_LCD)
-	setup_videolfb_tag ((gd_t *) gd);
-#endif
 	setup_end_tag (bd);
 #endif

@@ -136,9 +125,7 @@ int do_bootm_linux(int flag, int argc, char *argv[], bootm_headers_t *images)
     defined (CONFIG_CMDLINE_TAG) || \
     defined (CONFIG_INITRD_TAG) || \
     defined (CONFIG_SERIAL_TAG) || \
-    defined (CONFIG_REVISION_TAG) || \
-    defined (CONFIG_LCD) || \
-    defined (CONFIG_VFD)
+    defined (CONFIG_REVISION_TAG)
 static void setup_start_tag (bd_t *bd)
 {
 	params = (struct tag *) bd->bi_boot_params;

@@ -214,30 +201,6 @@ static void setup_initrd_tag (bd_t *bd, ulong initrd_start, ulong initrd_end)
 }
 #endif /* CONFIG_INITRD_TAG */
 
-
-#if defined (CONFIG_VFD) || defined (CONFIG_LCD)
-extern ulong calc_fbsize (void);
-static void setup_videolfb_tag (gd_t *gd)
-{
-	/* An ATAG_VIDEOLFB node tells the kernel where and how large
-	 * the framebuffer for video was allocated (among other things).
-	 * Note that a _physical_ address is passed !
-	 *
-	 * We only use it to pass the address and size, the other entries
-	 * in the tag_videolfb are not of interest.
-	 */
-	params->hdr.tag = ATAG_VIDEOLFB;
-	params->hdr.size = tag_size (tag_videolfb);
-
-	params->u.videolfb.lfb_base = (u32) gd->fb_base;
-	/* Fb size is calculated according to parameters for our panel
-	 */
-	params->u.videolfb.lfb_size = calc_fbsize();
-
-	params = tag_next (params);
-}
-#endif /* CONFIG_VFD || CONFIG_LCD */
-
 #ifdef CONFIG_SERIAL_TAG
 void setup_serial_tag (struct tag **tmp)
 {

Signature · 1 line

1.6.3.3

By removing all references to CONFIG_VFD you break support for the board using this feature. As far as I know this board is stillrunnign a 2.4.27-vrs1 kernel, which hdas ATAG_VIDEOLFB defined and used in include/asm-arm/setup.h resp. arch/arm/kernel/setup.c

Best regards,

Wolfgang Denk

Signature · 4 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
To be is to program.

Martin Krause

2010-06-18 11:05 UTC #2 lore raw

PATCH 1/1 ARM: remove unused ATAG

u-boot-bounces at lists.denx.de wrote on Friday, June 18, 2010 12:50 PM:

Quoted 34 lines

Dear Minkyu Kang,
Quoted 1 line · In message <[email protected]> you wrote:
ATAG_VIDEOLFB is not used anywhere.
... not any more, that is.
Quoted 5 lines
The belowing warning is occurred due to this ATAG.
[    0.000000] Ignoring unrecognised tag 0x54410008
This patch fixed it.
I think we should try to find another way to fix this.
Quoted 4 lines
arch/arm/lib/bootm.c +1 -2
-    defined (CONFIG_VFD) || \
-    defined (CONFIG_LCD)
+    defined (CONFIG_REVISION_TAG)
 static void setup_start_tag (bd_t *bd);
...
Quoted 3 lines
arch/arm/lib/bootm.c +0 -3
-# if defined (CONFIG_VFD) || defined (CONFIG_LCD)
-static void setup_videolfb_tag (gd_t *gd);
-# endif
...
Quoted 4 lines
arch/arm/lib/bootm.c +1 -3
-    defined (CONFIG_REVISION_TAG) || \
-    defined (CONFIG_LCD) || \
-    defined (CONFIG_VFD)
+    defined (CONFIG_REVISION_TAG)
...
Quoted 3 lines
arch/arm/lib/bootm.c +0 -3
-#if defined (CONFIG_VFD) || defined (CONFIG_LCD)
-	setup_videolfb_tag ((gd_t *) gd);
-#endif
...

Quoted 4 lines

etc.
By removing all references to CONFIG_VFD you break support for the board using this feature. As far as I know this board is stillrunnign

If you reference to the trab board, then yes it is still running. But on this board a very very old version of U-Boot is running, and I don't see, that this would change during the remaining lifetime of the board. Thus it's fine by me to break/remove the board support from current U-Boot.

Quoted 6 lines

a 2.4.27-vrs1 kernel, which hdas ATAG_VIDEOLFB defined and used in include/asm-arm/setup.h resp. arch/arm/kernel/setup.c
Best regards,
Wolfgang Denk

Best regards,
Martin Krause

Development
Phone +49 8153 9308-157, Fax +49 8153 9308-7157
mailto:martin.krause at tqs.de

TQ-Systems GmbH
Muehlstrasse 2, Gut Delling, D-82229 Seefeld, Germany
Amtsgericht M?nchen, HRB 105 018, UST-IdNr. DE 811 607 913
Place of business: Seefeld
Managing Directors: Dipl.-Ing. (FH) Detlef Schneider, Dipl.-Ing. (FH) R?diger Stahl
http://www.tq-group.com/

Wolfgang Denk

2010-06-18 18:18 UTC #3 lore raw

PATCH 1/1 ARM: remove unused ATAG

Dear Martin,

Quoted 6 lines · In message <[email protected]> you…

If you reference to the trab board, then yes it is still running. But on this board a very very old version of U-Boot is running, and I don't see, that this would change during the remaining lifetime of the board. Thus it's fine by me to break/remove the board support from current U-Boot.

Should we remove the whole trab support, then?

Best regards,

Wolfgang Denk

Signature · 5 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Gods don't like people not doing much work. People  who  aren't  busy
all the time might start to _think_.  - Terry Pratchett, _Small Gods_

Martin Krause

2010-06-21 07:52 UTC #4 lore raw

PATCH 1/1 ARM: remove unused ATAG

Hi Wolfgang,

Wolfgang Denk wrote on Friday, June 18, 2010 8:18 PM:

Quoted 6 lines

Dear Martin,
In message <[email protected]> you
Quoted 1 line · wrote:

Quoted 7 lines

Quoted 5 lines
If you reference to the trab board, then yes it is still running. But on this board a very very old version of U-Boot is running, and I don't see, that this would change during the remaining lifetime of the board. Thus it's fine by me to break/remove the board support from current U-Boot.
Should we remove the whole trab support, then?

If it helps in any way to make U-Boot better (make the code more maintainable, remove some special configuration options, which are only used on trab board, etc.), and no one has objections, then the whole trab board support can be removed.

Best Regards,
Martin Krasue

Wolfgang Denk

2010-06-22 20:50 UTC #5 lore raw

PATCH 1/1 ARM: remove unused ATAG

Dear "Martin Krause",

Quoted 7 lines · In message <[email protected]> you…

Quoted 2 lines
Should we remove the whole trab support, then?
If it helps in any way to make U-Boot better (make the code more maintainable, remove some special configuration options, which are only used on trab board, etc.), and no one has objections, then=20 the whole trab board support can be removed.

OK, I'll keep this in mind. So far the board support is still somewhat useful as I use it as test case for s3c2400 processors, but as soon as this board should cause troube that would require efforts we will consider dropping it.

Thanks for the feedback.

Best regards,

Wolfgang Denk

Signature · 6 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Where humor is concerned there are no standards -- no  one  can  say
what is good or bad, although you can be sure that everyone will.
- John Kenneth Galbraith

Wolfgang Denk

Applied

2010-06-22 22:11 UTC #6 lore raw

PATCH 1/1 ARM: remove unused ATAG

In reply to Minkyu Kang

Dear Minkyu Kang,

Quoted 5 lines · In message <[email protected]> you wrote:

ATAG_VIDEOLFB is not used anywhere.
The belowing warning is occurred due to this ATAG.
[    0.000000] Ignoring unrecognised tag 0x54410008

Quoted 7 lines

This patch fixed it.
Signed-off-by Minkyu Kang <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
---
 arch/arm/lib/bootm.c |   43 +++----------------------------------------
 1 files changed, 3 insertions(+), 40 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 4 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Our business is run on trust.  We trust you will pay in advance.