Skip to contentSkip to conversation

b43: Clarify logged message after fatal DMA error and switch to PIO mode

PATCH New Larry Finger 4 participants 7 messages Jun 19, 2010 – Jun 21, 2010 Networking drivers (wireless)

lore
Share & tools
lore

Larry Finger

author
#0 lore raw

PATCH 1/1 b43: Clarify logged message after fatal DMA error and switch to PIO mode

The message following fatal DMA errors fails to indicate properly that the driver has switched to PIO mode.

Signed-off-by Larry Finger <[email protected]>

---

drivers/net/wireless/b43/main.c +1 -1
Index: wireless-testing/drivers/net/wireless/b43/main.c
===================================================================
@@ -1804,7 +1804,7 @@ static void b43_do_interrupt_thread(stru
 			       dma_reason[2], dma_reason[3],
 			       dma_reason[4], dma_reason[5]);
 			b43err(dev->wl, "This device does not support DMA "
-			       "on your system. Please use PIO instead.\n");
+			       "on your system. It will now be switched to PIO.\n");
 			/* Fall back to PIO transfers if we get fatal DMA errors! */
 			dev->use_pio = 1;
 			b43_controller_restart(dev, "DMA error");
#1 lore raw

PATCH 1/1 b43: Clarify logged message after fatal DMA error and switch to PIO mode

Quoted 20 lines · Larry Finger

The message following fatal DMA errors fails to indicate properly that the driver has switched to PIO mode.

Signed-off-by Larry Finger<[email protected]>

---

Index: wireless-testing/drivers/net/wireless/b43/main.c
===================================================================

drivers/net/wireless/b43/main.c +1 -1
@@ -1804,7 +1804,7 @@ static void b43_do_interrupt_thread(stru
  			       dma_reason[2], dma_reason[3],
  			       dma_reason[4], dma_reason[5]);
  			b43err(dev->wl, "This device does not support DMA "
-			       "on your system. Please use PIO instead.\n");
+			       "on your system. It will now be switched to PIO.\n");
  			/* Fall back to PIO transfers if we get fatal DMA errors! */
  			dev->use_pio = 1;
  			b43_controller_restart(dev, "DMA error");
Quoted 5 lines

_______________________________________________
b43-dev mailing list
b43-dev at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev

Ack.

But what's the current status of the debugging of the PCI-core code w.r.t DMA?

Signature · 1 line
Greetings Michael.
author
#2 lore raw

PATCH 1/1 b43: Clarify logged message after fatal DMA error and switch to PIO mode

Quoted 3 lines · Michael B?sch

But what's the current status of the debugging of the PCI-core code w.r.t DMA?

There has been no progress.

John: Would you be offended if I tried to swap that HP Mini 110 for some other Netbook that does have the DMA problem? I was thinking of contacting Linus as I know he has a box with the problem.

Larry

#3 lore raw

PATCH 1/1 b43: Clarify logged message after fatal DMA error and switch to PIO mode

2010/6/19 Larry Finger <[email protected]>:

Quoted 6 lines · Michael B?sch
Quoted 3 lines

But what's the current status of the debugging of the PCI-core code w.r.t DMA?

There has been no progress.

What about PCI specs you prepared some time ago? Can we "suspect" them to be cure for DMA errors?

Signature · 1 line
Rafa?
author
#4 lore raw

PATCH 1/1 b43: Clarify logged message after fatal DMA error and switch to PIO mode

Quoted 10 lines · Rafa? Mi?ecki

2010/6/19 Larry Finger <[email protected]>:

Quoted 6 lines · Michael B?sch
Quoted 3 lines

But what's the current status of the debugging of the PCI-core code w.r.t DMA?

There has been no progress.

What about PCI specs you prepared some time ago? Can we "suspect" them to be cure for DMA errors?

They might be as they have not been tested.

Larry

#5 lore raw

PATCH 1/1 b43: Clarify logged message after fatal DMA error and switch to PIO mode

In reply to Larry Finger
Quoted 10 lines · Larry Finger
Quoted 3 lines · Michael B?sch

But what's the current status of the debugging of the PCI-core code w.r.t DMA?

There has been no progress.

John: Would you be offended if I tried to swap that HP Mini 110 for some other Netbook that does have the DMA problem? I was thinking of contacting Linus as I know he has a box with the problem.

Fine by me. :-)

Signature · 2 lines
John W. Linville		Someday the world will need a hero, and you
linville at tuxdriver.com			might be all we have.  Be ready.
#6 lore raw

PATCH 1/1 b43: Clarify logged message after fatal DMA error and switch to PIO mode

In reply to Larry Finger
Quoted 12 lines · Larry Finger

The message following fatal DMA errors fails to indicate properly that the driver has switched to PIO mode.

Signed-off-by Larry Finger<[email protected]>

---

Index: wireless-testing/drivers/net/wireless/b43/main.c
===================================================================

drivers/net/wireless/b43/main.c static void b43_do_interrupt_thread(stru · line 1810

Quoted 8 lines
drivers/net/wireless/b43/main.c +1 -1
@@ -1804,7 +1804,7 @@ static void b43_do_interrupt_thread(stru
  			       dma_reason[2], dma_reason[3],
  			       dma_reason[4], dma_reason[5]);
  			b43err(dev->wl, "This device does not support DMA "
-			       "on your system. Please use PIO instead.\n");
+			       "on your system. It will now be switched to PIO.\n");
  			/* Fall back to PIO transfers if we get fatal DMA errors! */
  			dev->use_pio = 1;
  			b43_controller_restart(dev, "DMA error");

Ack.

But what's the current status of the debugging of the PCI-core code w.r.t DMA?

Signature · 1 line
Greetings Michael.