Skip to contentSkip to conversation

uli526x: drop newlines from device name

PATCH New Mike Frysinger 2 participants 2 messages Jun 10, 2010 – Jun 21, 2010 Network drivers

lore
Share & tools
lore

Mike Frysinger

author
#0 lore raw

PATCH 1/1 uli526x: drop newlines from device name

Device names should not contain non-printable characters like newlines.

Signed-off-by Mike Frysinger <[email protected]>
---
 drivers/net/uli526x.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/uli526x.c +1 -1
index 9477851..56eee7b 100644
@@ -225,7 +225,7 @@ int uli526x_initialize(bd_t *bis)
 		iobase &= ~0xf;
 
 		dev = (struct eth_device *)malloc(sizeof *dev);
-		sprintf(dev->name, "uli526x#%d\n", card_number);
+		sprintf(dev->name, "uli526x#%d", card_number);
 		db = (struct uli526x_board_info *)
 			malloc(sizeof(struct uli526x_board_info));
Signature · 1 line
1.7.1
Applied
#1 lore raw

PATCH 1/1 uli526x: drop newlines from device name

Hi Mike,

Quoted 13 lines · Mike Frysinger

Device names should not contain non-printable characters like newlines.

Signed-off-by Mike Frysinger<[email protected]>
---
  drivers/net/uli526x.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/uli526x.c +0 -0
index 9477851..56eee7b 100644

drivers/net/uli526x.c int uli526x_initialize(bd_t *bis) · line 231

Quoted 8 lines
drivers/net/uli526x.c +1 -1
@@ -225,7 +225,7 @@ int uli526x_initialize(bd_t *bis)
  		iobase&= ~0xf;
 
  		dev = (struct eth_device *)malloc(sizeof *dev);
-		sprintf(dev->name, "uli526x#%d\n", card_number);
+		sprintf(dev->name, "uli526x#%d", card_number);
  		db = (struct uli526x_board_info *)
  			malloc(sizeof(struct uli526x_board_info));

Applied to net/next.

regards,
Ben