GPIO PL061: Adding Clk framework support
PATCH RESEND 1/1 GPIO PL061: Adding Clk framework support
From: Viresh KUMAR <[email protected]>
GPIO Clk is never enabled on Platforms, like: SPEAr, which are based upon clock framework and use PL061 driver. This patch adds support for Clk enabling and disabling as and when gpios are requested and freed.
Signed-off-by Viresh Kumar <[email protected]>
--- drivers/gpio/pl061.c | 44 +++++++++++++++++++++++++++++++++++++++++--- 1 files changed, 41 insertions(+), 3 deletions(-)
drivers/gpio/pl061.c +41 -3
@@ -11,7 +11,10 @@* * Data sheet: ARM DDI 0190B, September 2000 */ + +#include <linux/clk.h> #include <linux/spinlock.h> +#include <linux/err.h> #include <linux/errno.h> #include <linux/module.h> #include <linux/list.h>
@@ -56,8 +59,33 @@ struct pl061_gpio {void __iomem *base;unsigned irq_base;struct gpio_chip gc; +unsigned usage_count; +struct clk *clk; }; +static int pl061_request (struct gpio_chip *gc,unsigned offset) +{ + struct pl061_gpio *chip = container_of(gc, struct pl061_gpio, gc); + +if (offset >= gc->ngpio) +return -EINVAL ; + +if (!chip->usage_count) +clk_enable (chip->clk); + + chip->usage_count++; +return 0 ; +} + +static void pl061_free (struct gpio_chip *gc,unsigned offset) +{ + struct pl061_gpio *chip = container_of(gc, struct pl061_gpio, gc); + + chip->usage_count--; +if (!chip->usage_count) +clk_disable (chip->clk); +} +static int pl061_direction_input (struct gpio_chip *gc,unsigned offset) { struct pl061_gpio *chip = container_of(gc, struct pl061_gpio, gc);
@@ -260,10 +288,18 @@ static int __init pl061_probe(struct amba_device *dev, struct amba_id *id) goto release_region; } + chip->clk =clk_get (&dev->dev,NULL ); +if (IS_ERR (chip->clk)) { + ret =PTR_ERR (chip->clk); + goto iounmap; + } +spin_lock_init (&chip->lock);spin_lock_init (&chip->irq_lock);INIT_LIST_HEAD (&chip->list); + chip->gc.request = pl061_request; + chip->gc.free = pl061_free; chip->gc.direction_input = pl061_direction_input; chip->gc.direction_output = pl061_direction_output; chip->gc.get = pl061_get_value;
@@ -279,7 +315,7 @@ static int __init pl061_probe(struct amba_device *dev, struct amba_id *id) ret =gpiochip_add (&chip->gc);if (ret) - goto iounmap; + goto free_clk;/* * irq_chip support
@@ -292,7 +328,7 @@ static int __init pl061_probe(struct amba_device *dev, struct amba_id *id) irq = dev->irq[0 ];if (irq <0 ) { ret = -ENODEV ; - goto iounmap; + goto free_clk; }set_irq_chained_handler (irq, pl061_irq_handler);if (!test_and_set_bit (irq, init_irq)) {/* list initialized? */
@@ -300,7 +336,7 @@ static int __init pl061_probe(struct amba_device *dev, struct amba_id *id)if (chip_list ==NULL ) {clear_bit (irq, init_irq); ret = -ENOMEM ; - goto iounmap; + goto free_clk; }INIT_LIST_HEAD (chip_list);set_irq_data (irq, chip_list);
@@ -323,6 +359,8 @@ static int __init pl061_probe(struct amba_device *dev, struct amba_id *id)return 0 ; +free_clk: +clk_put (chip->clk); iounmap:iounmap (chip->base); release_region:
Signature · 1 line
1.6.0.2
PATCH RESEND 1/1 GPIO PL061: Adding Clk framework support
Quoted 7 lines · Viresh KUMAR
drivers/gpio/pl061.c +2
-0@@ -56,8 +59,33 @@ struct pl061_gpio {void __iomem *base;unsigned irq_base;struct gpio_chip gc; +unsigned usage_count; +struct clk *clk; };
drivers/gpio/pl061.c struct pl061_gpio { · line 74
Quoted 10 lines
drivers/gpio/pl061.c +9
-0+static int pl061_request (struct gpio_chip *gc,unsigned offset) +{ + struct pl061_gpio *chip = container_of(gc, struct pl061_gpio, gc); + +if (offset >= gc->ngpio) +return -EINVAL ; + +if (!chip->usage_count) +clk_enable (chip->clk);
Clocks are already use-counted.
PATCH RESEND 1/1 GPIO PL061: Adding Clk framework support
Quoted 9 lines · Russell King - ARM Linux
Quoted 8 lines · Viresh KUMAR
drivers/gpio/pl061.c +2
-0@@ -56,8 +59,33 @@ struct pl061_gpio {void __iomem *base;unsigned irq_base;struct gpio_chip gc; +unsigned usage_count; +struct clk *clk; };
Quoted 12 lines
drivers/gpio/pl061.c struct pl061_gpio { · line 74
Quoted 9 lines
drivers/gpio/pl061.c +9
-0+static int pl061_request (struct gpio_chip *gc,unsigned offset) +{ + struct pl061_gpio *chip = container_of(gc, struct pl061_gpio, gc); + +if (offset >= gc->ngpio) +return -EINVAL ; + +if (!chip->usage_count) +clk_enable (chip->clk);Clocks are already use-counted.
Yes. This is not required. Can simple call clk_enable and clk_disable.