Skip to contentSkip to conversation

sched,cpuset: drop __cpuexit from cpu hotplug callbacks

PATCH In review Tejun Heo 2 participants 3 messages Jun 21, 2010 – Jun 22, 2010

lore
Share & tools
lore

Tejun Heo

author
#0 lore raw

PATCH 1/1 sched,cpuset: drop __cpuexit from cpu hotplug callbacks

Commit 3a101d05 (sched: adjust when cpu_active and cpuset configurations are updated during cpu on/offlining) added hotplug notifiers marked with __cpuexit; however, ia64 drops text in __cpuexit during link unlike x86. This means that functions which are referenced during init but used only for cpu hot unplugging afterwards shouldn't be marked with __cpuexit. Drop __cpuexit from those functions.

Signed-off-by Tejun Heo <[email protected]>
Reported-by Tony Luck <[email protected]>

---
This seems to work fine here but it would be nice if you can confirm this. Thanks.

 kernel/cpuset.c |    2 +-
 kernel/sched.c  |    8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)
kernel/cpuset.c +1 -1
index 05727dc..7146793 100644
@@ -2118,7 +2118,7 @@ static void scan_for_empty_cpusets(struct cpuset *root)
  * Called within get_online_cpus().  Needs to call cgroup_lock()
  * before calling generate_sched_domains().
  */
-void __cpuexit cpuset_update_active_cpus(void)
+void cpuset_update_active_cpus(void)
 {
 	struct sched_domain_attr *attr;
 	cpumask_var_t *doms;
kernel/sched.c +4 -4
index b4427cc..9064e7d 100644
@@ -7477,8 +7477,8 @@ int __init sched_create_sysfs_power_savings_entries(struct sysdev_class *cls)
  * disabled, cpuset_update_active_cpus() becomes a simple wrapper
  * around partition_sched_domains().
  */
-static int __cpuexit cpuset_cpu_active(struct notifier_block *nfb,
-				       unsigned long action, void *hcpu)
+static int cpuset_cpu_active(struct notifier_block *nfb, unsigned long action,
+			     void *hcpu)
 {
 	switch (action & ~CPU_TASKS_FROZEN) {
 	case CPU_ONLINE:

@@ -7490,8 +7490,8 @@ static int __cpuexit cpuset_cpu_active(struct notifier_block *nfb,
 	}
 }
 
-static int __cpuexit cpuset_cpu_inactive(struct notifier_block *nfb,
-					 unsigned long action, void *hcpu)
+static int cpuset_cpu_inactive(struct notifier_block *nfb, unsigned long action,
+			       void *hcpu)
 {
 	switch (action & ~CPU_TASKS_FROZEN) {
 	case CPU_DOWN_PREPARE:
author
#2 lore raw

[tip:sched/core] sched, cpuset: Drop __cpuexit from cpu hotplug callbacks

In reply to Tejun Heo
Commit-ID:  0b2e918aa99fe6c3b8f163aa323a275ad8577828
Gitweb:     http://git.kernel.org/tip/0b2e918aa99fe6c3b8f163aa323a275ad8577828
Author:     Tejun Heo <[email protected]>
AuthorDate: Mon, 21 Jun 2010 23:53:31 +0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Tue, 22 Jun 2010 08:07:39 +0200

sched, cpuset: Drop __cpuexit from cpu hotplug callbacks

Commit 3a101d05 (sched: adjust when cpu_active and cpuset configurations are updated during cpu on/offlining) added hotplug notifiers marked with __cpuexit; however, ia64 drops text in __cpuexit during link unlike x86.

This means that functions which are referenced during init but used only for cpu hot unplugging afterwards shouldn't be marked with __cpuexit. Drop __cpuexit from those functions.

Reported-by Tony Luck <[email protected]>
Signed-off-by Tejun Heo <[email protected]>
Acked-by Tony Luck <[email protected]>
Cc Peter Zijlstra <[email protected]>

LKML-Reference: <[email protected]>

Signed-off-by Ingo Molnar <[email protected]>
---
 kernel/cpuset.c |    2 +-
 kernel/sched.c  |    8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)
kernel/cpuset.c +1 -1
index 05727dc..7146793 100644
@@ -2118,7 +2118,7 @@ static void scan_for_empty_cpusets(struct cpuset *root)
  * Called within get_online_cpus().  Needs to call cgroup_lock()
  * before calling generate_sched_domains().
  */
-void __cpuexit cpuset_update_active_cpus(void)
+void cpuset_update_active_cpus(void)
 {
 	struct sched_domain_attr *attr;
 	cpumask_var_t *doms;
kernel/sched.c +4 -4
index b4427cc..9064e7d 100644
@@ -7477,8 +7477,8 @@ int __init sched_create_sysfs_power_savings_entries(struct sysdev_class *cls)
  * disabled, cpuset_update_active_cpus() becomes a simple wrapper
  * around partition_sched_domains().
  */
-static int __cpuexit cpuset_cpu_active(struct notifier_block *nfb,
-				       unsigned long action, void *hcpu)
+static int cpuset_cpu_active(struct notifier_block *nfb, unsigned long action,
+			     void *hcpu)
 {
 	switch (action & ~CPU_TASKS_FROZEN) {
 	case CPU_ONLINE:

@@ -7490,8 +7490,8 @@ static int __cpuexit cpuset_cpu_active(struct notifier_block *nfb,
 	}
 }
 
-static int __cpuexit cpuset_cpu_inactive(struct notifier_block *nfb,
-					 unsigned long action, void *hcpu)
+static int cpuset_cpu_inactive(struct notifier_block *nfb, unsigned long action,
+			       void *hcpu)
 {
 	switch (action & ~CPU_TASKS_FROZEN) {
 	case CPU_DOWN_PREPARE: