Fix wrong orion5x MPP and GIPO writel arguments

PATCH New Albert Aribaud 3 participants 6 messages Jun 21, 2010 – Jun 22, 2010 Arm (32-bit)

lore

Share & tools

lore

Albert Aribaud

author

2010-06-21 20:46 UTC #0 lore raw

PATCH 1/1 Fix wrong orion5x MPP and GIPO writel arguments

Signed-off-by Albert Aribaud <[email protected]>

---
Orion5x MPP and GPIO setting code had writel arguments the wrong way around. Fixed and tested.

 arch/arm/cpu/arm926ejs/orion5x/cpu.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

arch/arm/cpu/arm926ejs/orion5x/cpu.c +4 -4

index c2f5253..03c6d06 100644
@@ -260,10 +260,10 @@ int arch_misc_init(void)
 
 	/* Set CPIOs and MPPs - values provided by board
 	   include file */
-	writel(ORION5X_MPP_BASE+0x00, ORION5X_MPP0_7);
-	writel(ORION5X_MPP_BASE+0x04, ORION5X_MPP8_15);
-	writel(ORION5X_MPP_BASE+0x50, ORION5X_MPP16_23);
-	writel(ORION5X_GPIO_BASE+0x04, ORION5X_GPIO_OUT_ENABLE);
+	writel(ORION5X_MPP0_7, ORION5X_MPP_BASE+0x00);
+	writel(ORION5X_MPP8_15, ORION5X_MPP_BASE+0x04);
+	writel(ORION5X_MPP16_23, ORION5X_MPP_BASE+0x50);
+	writel(ORION5X_GPIO_OUT_ENABLE, ORION5X_GPIO_BASE+0x04);
 
 	return 0;
 }

Signature · 1 line

1.6.4.4

Prafulla Wadaskar

2010-06-22 06:20 UTC #1 lore raw

PATCH 1/1 Fix wrong orion5x MPP and GIPO writel arguments

Quoted 26 lines

-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Albert Aribaud
Sent: Tuesday, June 22, 2010 2:17 AM
To: u-boot at lists.denx.de
Subject: [U-Boot] [PATCH] Fix wrong orion5x MPP and GIPO writel arguments
Signed-off-by Albert Aribaud <[email protected]>
---
Orion5x MPP and GPIO setting code had writel arguments the wrong way around. Fixed and tested.
 arch/arm/cpu/arm926ejs/orion5x/cpu.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
arch/arm/cpu/arm926ejs/orion5x/cpu.c +0 -0
index c2f5253..03c6d06 100644
@@ -260,10 +260,10 @@ int arch_misc_init(void)
 

arch/arm/cpu/arm926ejs/orion5x/cpu.c int arch_misc_init(void) · line 266

Quoted 10 lines

arch/arm/cpu/arm926ejs/orion5x/cpu.c +4 -4

 	/* Set CPIOs and MPPs - values provided by board
 	   include file */
-	writel(ORION5X_MPP_BASE+0x00, ORION5X_MPP0_7);
-	writel(ORION5X_MPP_BASE+0x04, ORION5X_MPP8_15);
-	writel(ORION5X_MPP_BASE+0x50, ORION5X_MPP16_23);
-	writel(ORION5X_GPIO_BASE+0x04, ORION5X_GPIO_OUT_ENABLE);
+	writel(ORION5X_MPP0_7, ORION5X_MPP_BASE+0x00);
+	writel(ORION5X_MPP8_15, ORION5X_MPP_BASE+0x04);
+	writel(ORION5X_MPP16_23, ORION5X_MPP_BASE+0x50);
+	writel(ORION5X_GPIO_OUT_ENABLE, ORION5X_GPIO_BASE+0x04);

This means, earlier patches you posted were not tested properly.
Its great trust on the developers that whatever they submit (even smallest change) is tested. Submitting untested/unused code is strongly discouraged...

I hope everyone agrees with me.

Regards..
Prafulla . .

Prafulla Wadaskar

2010-06-22 06:32 UTC #2 lore raw

PATCH 1/1 Fix wrong orion5x MPP and GIPO writel arguments

Quoted 23 lines

-----Original Message-----
From: u-boot-bounces at lists.denx.de
[mailto:u-boot-bounces at lists.denx.de] On Behalf Of Prafulla Wadaskar
Sent: Tuesday, June 22, 2010 11:51 AM
To: Albert Aribaud; u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH] Fix wrong orion5x MPP and GIPO writel arguments
Quoted 13 lines
-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Albert Aribaud
Sent: Tuesday, June 22, 2010 2:17 AM
To: u-boot at lists.denx.de
Subject: [U-Boot] [PATCH] Fix wrong orion5x MPP and GIPO writel arguments
Signed-off-by Albert Aribaud <[email protected]>
---
Orion5x MPP and GPIO setting code had writel arguments the wrong way around. Fixed and tested.

Hi Wolfgang

The same is available at
http://git.denx.de/?p=u-boot/u-boot-marvell.git;a=commit;h=df33d8b1e1be6111366a3fd51751c9419fc2df5a

Please kindly pull it from u-boot-marvell.git master branch, I have modified original patch little bit for patch comments

Regards..
Prafulla . . .

Wolfgang Denk

Applied

2010-06-22 20:38 UTC #3 lore raw

PATCH 1/1 Fix wrong orion5x MPP and GIPO writel arguments

Dear Prafulla Wadaskar,

Quoted 7 lines · In message <[email protected]>…

The same is available at
http://git.denx.de/?p=3Du-boot/u-boot-marvell.git;a=3Dcommit;h=3Ddf33d8b1e1=
be6111366a3fd51751c9419fc2df5a
Please kindly pull it from u-boot-marvell.git master branch, I have modifie= d original patch little bit for patch comments

I'm not sure if htis was a pull request - in case it was, please resend it as such.

So far, I just cherry-picked this single commit.

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Gods don't like people not doing much work. People  who  aren't  busy
all the time might start to _think_.  - Terry Pratchett, _Small Gods_

Albert ARIBAUD

author

2010-06-22 06:42 UTC #4 lore raw

PATCH 1/1 Fix wrong orion5x MPP and GIPO writel arguments

In reply to Prafulla Wadaskar

Le 22/06/2010 08:20, Prafulla Wadaskar a ?crit :

Quoted 5 lines

This means, earlier patches you posted were not tested properly.
Its great trust on the developers that whatever they submit (even smallest change) is tested. Submitting untested/unused code is strongly discouraged...
I hope everyone agrees with me.

I agree and do apologize.

Amicalement,

Signature · 1 line

Albert.

Prafulla Wadaskar

2010-06-22 06:29 UTC #5 lore raw

PATCH 1/1 Fix wrong orion5x MPP and GIPO writel arguments

In reply to Albert Aribaud

Quoted 27 lines

-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Albert Aribaud
Sent: Tuesday, June 22, 2010 2:17 AM
To: u-boot at lists.denx.de
Subject: [U-Boot] [PATCH] Fix wrong orion5x MPP and GIPO writel arguments
Signed-off-by Albert Aribaud <[email protected]>
---
Orion5x MPP and GPIO setting code had writel arguments the wrong way around. Fixed and tested.
 arch/arm/cpu/arm926ejs/orion5x/cpu.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
arch/arm/cpu/arm926ejs/orion5x/cpu.c +0 -0
index c2f5253..03c6d06 100644
@@ -260,10 +260,10 @@ int arch_misc_init(void)
 
 	/* Set CPIOs and MPPs - values provided by board

arch/arm/cpu/arm926ejs/orion5x/cpu.c int arch_misc_init(void) · line 267

Quoted 10 lines

arch/arm/cpu/arm926ejs/orion5x/cpu.c +4 -4

 	   include file */
-	writel(ORION5X_MPP_BASE+0x00, ORION5X_MPP0_7);
-	writel(ORION5X_MPP_BASE+0x04, ORION5X_MPP8_15);
-	writel(ORION5X_MPP_BASE+0x50, ORION5X_MPP16_23);
-	writel(ORION5X_GPIO_BASE+0x04, ORION5X_GPIO_OUT_ENABLE);
+	writel(ORION5X_MPP0_7, ORION5X_MPP_BASE+0x00);
+	writel(ORION5X_MPP8_15, ORION5X_MPP_BASE+0x04);
+	writel(ORION5X_MPP16_23, ORION5X_MPP_BASE+0x50);
+	writel(ORION5X_GPIO_OUT_ENABLE, ORION5X_GPIO_BASE+0x04);

Applied to u-boot-marvell.git master branch

Regards..
Prafulla . .