Skip to contentSkip to conversation

RTC/max6900: use rtc_valid_tm to check returning tm for max6900

PATCH In review Wan ZongShun 2 participants 3 messages Jun 22, 2010 Real time clock (RTC)

lore
Share & tools
lore

Wan ZongShun

author
#0 lore raw

PATCH 1/1 RTC/max6900: use rtc_valid_tm to check returning tm for max6900

Use rtc_valid_tm to check returning tm for max6900, it can avoid returning wrong tm value.

---
 drivers/rtc/rtc-max6900.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/rtc/rtc-max6900.c +1 -1
index a4f6665..486142c 100644
@@ -159,7 +159,7 @@ static int max6900_i2c_read_time(struct i2c_client *client, struct rtc_time *tm)
 		      bcd2bin(regs[MAX6900_REG_CENTURY]) * 100 - 1900;
 	tm->tm_wday = bcd2bin(regs[MAX6900_REG_DW]);
 
-	return 0;
+	return rtc_valid_tm(tm);
 }
 
 static int max6900_i2c_clear_write_protect(struct i2c_client *client)
Signature · 1 line
1.6.3.3
author
#1 lore raw
Signed-off-by Wan ZongShun <[email protected]>
Quoted 22 lines

Use rtc_valid_tm to check returning tm for max6900, it can avoid returning wrong tm value.
---
 drivers/rtc/rtc-max6900.c |    2 +-

 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/rtc/rtc-max6900.c +1 -2
index a4f6665..486142c 100644
@@ -159,7 +159,7 @@ static int max6900_i2c_read_time(struct i2c_client *client, struct rtc_time *tm)
                      bcd2bin(regs[MAX6900_REG_CENTURY]) * 100 - 1900;
        tm->tm_wday = bcd2bin(regs[MAX6900_REG_DW]);
 
-       return 0;
+       return rtc_valid_tm(tm);
  }
 
  static int max6900_i2c_clear_write_protect(struct i2c_client *client)
--

1.6.3.3

Signature · 10 lines
*linux-arm-kernel mailing list
mail addr:[email protected]
you can subscribe by:
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

* linux-arm-NUC900 mailing list
mail addr:[email protected]
main web: https://groups.google.com/group/NUC900
you can subscribe it by sending me mail:
[email protected]
#2 lore raw
In reply to Wan ZongShun
Quoted 11 lines · Wan ZongShun

Use rtc_valid_tm to check returning tm for max6900, it can avoid returning wrong tm value.

---
 drivers/rtc/rtc-max6900.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/rtc/rtc-max6900.c +0 -0
index a4f6665..486142c 100644

drivers/rtc/rtc-max6900.c static int max6900_i2c_read_time(struct i2c_client *client, struct rtc_time *tm) · line 165

Quoted 8 lines
drivers/rtc/rtc-max6900.c +1 -1
@@ -159,7 +159,7 @@ static int max6900_i2c_read_time(struct i2c_client *client, struct rtc_time *tm)
 		      bcd2bin(regs[MAX6900_REG_CENTURY]) * 100 - 1900;
 	tm->tm_wday = bcd2bin(regs[MAX6900_REG_DW]);
 
-	return 0;
+	return rtc_valid_tm(tm);
 }
 
 static int max6900_i2c_clear_write_protect(struct i2c_client *client)

Ack.

Thanks,
-Dale