Skip to contentSkip to conversation

RTC/nuc900: fix build warning

PATCH In review Wan ZongShun 2 participants 2 messages Jun 24, 2010 – Jun 30, 2010 Real time clock (RTC)

lore
Share & tools
lore
#0 lore raw

PATCH 3/3 RTC/nuc900: fix build warning

Firstly,I am sorry for this patch, because I omit the warning
when I submit 'nuc900-rtc-change-the-waiting-for-device-ready-implement.patch'. so I have to send a patch to fix it.

It is reported by Nuvoton test guys, thanks.

---
 drivers/rtc/rtc-nuc900.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/rtc/rtc-nuc900.c +1 -1
index 0267ea3..62de66a 100644
@@ -85,7 +85,7 @@ static irqreturn_t nuc900_rtc_interrupt(int irq, void *_rtc)
 
 static int *check_rtc_access_enable(struct nuc900_rtc *nuc900_rtc)
 {
-	unsigned int i, timeout = 0x1000;
+	unsigned int timeout = 0x1000;
 	__raw_writel(INIRRESET, nuc900_rtc->rtc_reg + REG_RTC_INIR);
 
 	mdelay(10);
Signature · 1 line
1.6.3.3
#1 lore raw
Quoted 3 lines · On Thu, 24 Jun 2010 17:05:57 +0800 Wan ZongShun <[email protected]> wrote:

Firstly,I am sorry for this patch, because I omit the warning
when I submit 'nuc900-rtc-change-the-waiting-for-device-ready-implement.patch'. so I have to send a patch to fix it.

When fixing a warning or build error, pelase quote the compiler messages in the changelog so we can see what got fixed.

Quoted 1 line

It is reported by Nuvoton test guys, thanks.

I don't know who that is. Perhaps use the Reported-by: tag here?

Quoted 11 lines
---
 drivers/rtc/rtc-nuc900.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/rtc/rtc-nuc900.c +0 -0
index 0267ea3..62de66a 100644

drivers/rtc/rtc-nuc900.c static irqreturn_t nuc900_rtc_interrupt(int irq, void *_rtc) · line 89

Quoted 6 lines
drivers/rtc/rtc-nuc900.c +1 -1
@@ -85,7 +85,7 @@ static irqreturn_t nuc900_rtc_interrupt(int irq, void *_rtc)
 
 static int *check_rtc_access_enable(struct nuc900_rtc *nuc900_rtc)
 {
-	unsigned int i, timeout = 0x1000;
+	unsigned int timeout = 0x1000;
 	__raw_writel(INIRRESET, nuc900_rtc->rtc_reg + REG_RTC_INIR);

Well it's pretty obvious what the warning was this time.