Skip to contentSkip to conversation

Don't reset bs->is_temporary in bdrv_open_common

PATCH Applied Ryan Harper 2 participants 2 messages Jun 28, 2010 – Jun 29, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Don't reset bs->is_temporary in bdrv_open_common

To fix https://bugs.launchpad.net/qemu/+bug/597402 where qemu fails to call unlink() on temporary snapshots due to bs->is_temporary getting clobbered in bdrv_open_common() after being set in bdrv_open() which calls the former.

We don't need to initialize bs->is_temporary in bdrv_open_common().

---
 block.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
block.c +0 -1
index e71a771..a55882e 100644
@@ -393,7 +393,6 @@ static int bdrv_open_common(BlockDriverState *bs, const char *filename,
 
     bs->file = NULL;
     bs->total_sectors = 0;
-    bs->is_temporary = 0;
     bs->encrypted = 0;
     bs->valid_key = 0;
     bs->open_flags = flags;
Signature · 8 lines
1.6.3.3


-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
[email protected]
Applied
#1 lore raw

Am 28.06.2010 16:38, schrieb Ryan Harper:

Quoted 7 lines

To fix https://bugs.launchpad.net/qemu/+bug/597402 where qemu fails to call unlink() on temporary snapshots due to bs->is_temporary getting clobbered in bdrv_open_common() after being set in bdrv_open() which calls the former.

We don't need to initialize bs->is_temporary in bdrv_open_common().

Thanks, applied to the block branch.

Kevin