Makefile: add fsdev/*.{o,d} to clean

PATCH In review Hidetoshi Seto 2 participants 4 messages Jul 1, 2010 – Jul 3, 2010 Kbuild

lore

Share & tools

lore

Hidetoshi Seto

author

2010-07-01 03:32 UTC #0 lore raw

PATCH 1/1 Makefile: add fsdev/*.{o,d} to clean

There were fsdev/qemu-fsdev.{o,d} not removed at "make clean".

Signed-off-by Hidetoshi Seto <[email protected]>

---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Makefile +1 -1

index 560eac6..ce5f0e6 100644
@@ -159,7 +159,7 @@ clean:
 # avoid old build problems by removing potentially incorrect old files
 	rm -f config.mak op-i386.h opc-i386.h gen-op-i386.h op-arm.h opc-arm.h gen-op-arm.h
 	rm -f *.o *.d *.a $(TOOLS) TAGS cscope.* *.pod *~ */*~
-	rm -f slirp/*.o slirp/*.d audio/*.o audio/*.d block/*.o block/*.d net/*.o net/*.d
+	rm -f {slirp,audio,block,net,fsdev}/*.{o,d}
 	rm -f qemu-img-cmds.h
 	$(MAKE) -C tests clean
 	for d in $(ALL_SUBDIRS) libhw32 libhw64 libuser libdis libdis-user; do \

Signature · 1 line

1.7.0

Blue Swirl

2010-07-01 19:48 UTC #1 lore raw

2010/7/1 Hidetoshi Seto <[email protected]>:

Quoted 13 lines

There were fsdev/qemu-fsdev.{o,d} not removed at "make clean".
Signed-off-by Hidetoshi Seto <[email protected]>
---
Makefile | 2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Makefile +0 -0
index 560eac6..ce5f0e6 100644
@@ -159,7 +159,7 @@ clean:
  # avoid old build problems by removing potentially incorrect old files

Quoted 4 lines

rm -f config.mak op-i386.h opc-i386.h gen-op-i386.h op-arm.h opc-arm.h gen-op-arm.h rm -f *.o *.d *.a $(TOOLS) TAGS cscope.* *.pod *~ */*~
- rm -f slirp/*.o slirp/*.d audio/*.o audio/*.d block/*.o block/*.d net/*.o net/*.d
+ rm -f {slirp,audio,block,net,fsdev}/*.{o,d}

Not every shell out there support {}:
dash -c 'echo {a,b}*.c'
{a,b}*.c

bash -c 'echo {a,b}*.c'
acl.c aes.c aio.c alpha-dis.c arch_init.c arm-dis.c arm-semi.c async.c balloon.c block-migration.c block.c blockdev.c bt-host.c bt-vhci.c buffered_file.c

Hidetoshi Seto

author

2010-07-02 06:28 UTC #2 lore raw

Quoted 23 lines · Blue Swirl

2010/7/1 Hidetoshi Seto <[email protected]>:
Quoted 12 lines
There were fsdev/qemu-fsdev.{o,d} not removed at "make clean".
Signed-off-by Hidetoshi Seto <[email protected]>
---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Makefile +0 -0
index 560eac6..ce5f0e6 100644
Makefile clean: · line 162
Quoted 5 lines
Makefile +1 -1
@@ -159,7 +159,7 @@ clean:
 # avoid old build problems by removing potentially incorrect old files
       rm -f config.mak op-i386.h opc-i386.h gen-op-i386.h op-arm.h opc-arm.h gen-op-arm.h
       rm -f *.o *.d *.a $(TOOLS) TAGS cscope.* *.pod *~ */*~
-       rm -f slirp/*.o slirp/*.d audio/*.o audio/*.d block/*.o block/*.d net/*.o net/*.d
+       rm -f {slirp,audio,block,net,fsdev}/*.{o,d}
Not every shell out there support {}:
dash -c 'echo {a,b}*.c'
{a,b}*.c

Quoted 4 lines

bash -c 'echo {a,b}*.c'
acl.c aes.c aio.c alpha-dis.c arch_init.c arm-dis.c arm-semi.c async.c balloon.c block-migration.c block.c blockdev.c bt-host.c bt-vhci.c buffered_file.c

You are right, but I found that Makefile already has:

169 distclean: clean
(snip)
174 rm -f qemu-{doc,tech}.{info,aux,cp,dvi,fn,info,ky,log,pdf,pg,toc,tp,vr}

So then is it better to rewrite this line not to use {} ...?

Thanks,
S.Seto

Blue Swirl

2010-07-03 07:16 UTC #3 lore raw

Quoted 29 lines · Hidetoshi Seto

Quoted 23 lines · Blue Swirl
2010/7/1 Hidetoshi Seto <[email protected]>:
Quoted 13 lines
There were fsdev/qemu-fsdev.{o,d} not removed at "make clean".
Signed-off-by Hidetoshi Seto <[email protected]>
---
Makefile | 2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Makefile +0 -0
index 560eac6..ce5f0e6 100644
@@ -159,7 +159,7 @@ clean:
  # avoid old build problems by removing potentially incorrect old files
Quoted 4 lines
rm -f config.mak op-i386.h opc-i386.h gen-op-i386.h op-arm.h opc-arm.h gen-op-arm.h rm -f *.o *.d *.a $(TOOLS) TAGS cscope.* *.pod *~ */*~
- rm -f slirp/*.o slirp/*.d audio/*.o audio/*.d block/*.o block/*.d net/*.o net/*.d
+ rm -f {slirp,audio,block,net,fsdev}/*.{o,d}
Not every shell out there support {}:
dash -c 'echo {a,b}*.c'
{a,b}*.c
Quoted 4 lines
bash -c 'echo {a,b}*.c'
acl.c aes.c aio.c alpha-dis.c arch_init.c arm-dis.c arm-semi.c async.c balloon.c block-migration.c block.c blockdev.c bt-host.c bt-vhci.c buffered_file.c

Quoted 7 lines

You are right, but I found that Makefile already has:
169 distclean: clean
(snip)
174 rm -f qemu-{doc,tech}.{info,aux,cp,dvi,fn,info,ky,log,pdf,pg,toc,tp,vr}
So then is it better to rewrite this line not to use {} ...?

Yes, a patch for that would be nice.