Skip to contentSkip to conversation

netfilter: LED: fix man page fragment inclusion

PATCH In review Sergei Zhirikov 2 participants 4 messages Jun 30, 2010 – Jul 5, 2010 netfilter

lore
Share & tools
lore

Sergei Zhirikov

author
#0 lore raw

PATCH 1/1 netfilter: LED: fix man page fragment inclusion

The man page fragment of the recently added LED target does not get included into iptables.8 and ip6tables.8 produced during build. This patch fixes that.

extensions/libxt_LED.c +1 -1
index af0e091..9a08e89 100644
@@ -137,7 +137,7 @@ static void LED_save(const void *ip, const struct xt_entry_target *target)
 static struct xtables_target led_tg_reg = {
 	.version       = XTABLES_VERSION,
 	.name          = "LED",
-	.family        = PF_UNSPEC,
+	.family        = NFPROTO_UNSPEC,
 	.revision      = 0,
 	.size          = XT_ALIGN(sizeof(struct xt_led_info)),
 	.userspacesize = offsetof(struct xt_led_info, internal_data),
#1 lore raw
Quoted 1 line · Sergei Zhirikov

The man page fragment of the recently added LED target does not get included into iptables.8 and ip6tables.8 produced during build. This patch fixes that.

You seem to have attached a different patch, please resend.

author
#2 lore raw

No, it was the correct patch. The Makefile looks for NFPROTO_UNSPEC in the source file in order to decide whether the manpage fragment should be included.

Quoted 13 lines · Patrick McHardy

From: Patrick McHardy <[email protected]>
Subject: Re: [PATCH] netfilter: LED: fix man page fragment inclusion
To: "Sergei Zhirikov" <[email protected]>
Cc: [email protected]
Date: Friday, July 2, 2010, 9:44 AM

Quoted 1 line · Sergei Zhirikov

The man page fragment of the recently added LED target

does not get included into iptables.8 and ip6tables.8 produced during build. This patch fixes that.

You seem to have attached a different patch, please resend.

#3 lore raw
Quoted 2 lines · Sergei Zhirikov

No, it was the correct patch. The Makefile looks for NFPROTO_UNSPEC in the source file in order to decide whether the manpage fragment should be included.

I see, thanks. Please make a formal submission, including a
Signed-off-by: line.