Skip to contentSkip to conversation

GTH board status

U-Boot New Wolfgang Denk 2 participants 13 messages Jun 23, 2010 – Jul 17, 2010 PowerPC

lore
Share & tools
lore

Wolfgang Denk

author
#0 lore raw

Dear Thomas,

is the GTH board still actively being maintained, or what exactly is it's state?

I'm trying to clean up a thing or two and ran into a few strange things:

"common/env_common.c" has this:

230 #if defined(CONFIG_GTH) || defined(CONFIG_ENV_IS_NOWHERE) /* Environment not changable */
231 puts ("Using default environment\n\n");
232 #else
233 puts ("*** Warning - bad CRC, using default environment\n\n");
234 show_boot_progress (-60);
235 #endif

This looks as if the GTH board had no persistent environment storage; but when I was tempted to remove the "defined(CONFIG_GTH) ||" part and add a "#define CONFIG_ENV_IS_NOWHERE" to "include/configs/GTH.h" I see this:

197 #define CONFIG_ENV_IS_IN_FLASH 1
198 #undef CONFIG_ENV_IS_IN_EEPROM
199 #define CONFIG_ENV_OFFSET 0x000E0000
200 #define CONFIG_ENV_SIZE 0x4000 /* Total Size of Environment Sector */
201
202 #define CONFIG_ENV_SECT_SIZE 0x50000 /* see README - env sector total size */

That means that there is actually flash on the GTH board.

Do you agree that we simply remove the "defined(CONFIG_GTH) ||" part from "common/env_common.c" ?

Then I noticed the CONFIG_ENV_SECT_SIZE = 0x50000 setting. I am sure that your flash memory cannot have a sector size of 320 KiB - the 0x50000 must be bogus.

Please comment.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Use C++ to confuse your enemies; use C to produce stable code.
#1 lore raw
Quoted 4 lines · Wolfgang Denk

Dear Thomas,

is the GTH board still actively being maintained, or what exactly is it's state?

The GTH board is obsolete and has not been manufactured for several years. To my knowledge, no recent U-Boot build has been tested on that card.

Quoted 17 lines

I'm trying to clean up a thing or two and ran into a few strange things:

"common/env_common.c" has this:

230 #if defined(CONFIG_GTH) || defined(CONFIG_ENV_IS_NOWHERE) /* Environment not changable */
231 puts ("Using default environment\n\n");
232 #else
233 puts ("*** Warning - bad CRC, using default environment\n\n");
234 show_boot_progress (-60);
235 #endif

This looks as if the GTH board had no persistent environment storage; but when I was tempted to remove the "defined(CONFIG_GTH) ||" part and add a "#define CONFIG_ENV_IS_NOWHERE" to "include/configs/GTH.h" I see this:

Quoted 8 lines

197 #define CONFIG_ENV_IS_IN_FLASH 1
198 #undef CONFIG_ENV_IS_IN_EEPROM
199 #define CONFIG_ENV_OFFSET 0x000E0000
200 #define CONFIG_ENV_SIZE 0x4000 /* Total Size of Environment Sector */
201
202 #define CONFIG_ENV_SECT_SIZE 0x50000 /* see README - env sector total size */

That means that there is actually flash on the GTH board.

Yes, there is a NOR flash on the card, but it was never used for persistent environment storage.

Quoted 2 lines

Do you agree that we simply remove the "defined(CONFIG_GTH) ||" part from "common/env_common.c" ?

Yes.

Quoted 3 lines

Then I noticed the CONFIG_ENV_SECT_SIZE = 0x50000 setting. I am sure that your flash memory cannot have a sector size of 320 KiB - the 0x50000 must be bogus.

The ENV defines above are all bogus. I think they were needed to make ppcboot compile. CONFIG_ENV_IS_NOWHERE did not exist at that time.

/Thomas

author
#2 lore raw

Dear Thomas,

Quoted 3 lines · In message <[email protected]> you wrote:

The GTH board is obsolete and has not been manufactured for several years. To my knowledge, no recent U-Boot build has been tested on that card.

Thanks for the feedback - so can we drop GTH support completely?

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Schshschshchsch.
	-- The Gorn, "Arena", stardate 3046.2
#3 lore raw
Quoted 6 lines · Wolfgang Denk
Quoted 3 lines · In message<[email protected]> you wrote:

The GTH board is obsolete and has not been manufactured for several years. To my knowledge, no recent U-Boot build has been tested on that card.

Thanks for the feedback - so can we drop GTH support completely?

Yes, fine with me.

/Thomas

author
#4 lore raw

PATCH 1/1 Drop support for GTH board

The board maintainer states:

The GTH board is obsolete and has not been manufactured for several years.
To my knowledge, no recent U-Boot build has been tested on that card.

So drop support for this board.

Signed-off-by Wolfgang Denk <[email protected]>
Cc Thomas Lange <[email protected]>
---
 MAINTAINERS           |    4 -
 MAKEALL               |    1 -
 board/gth/Makefile    |   44 ----
 board/gth/README      |   18 --
 board/gth/config.mk   |   40 ---
 board/gth/ee_access.c |  335 -------------------------
 board/gth/ee_access.h |   16 --
 board/gth/ee_dev.h    |   85 -------
 board/gth/flash.c     |  649 -------------------------------------------------
 board/gth/gth.c       |  595 ---------------------------------------------
 board/gth/pcmcia.c    |   93 -------
 board/gth/u-boot.lds  |  127 ----------
 boards.cfg            |    1 -
 13 files changed, 0 insertions(+), 2008 deletions(-)
 delete mode 100644 board/gth/Makefile
 delete mode 100644 board/gth/README
 delete mode 100644 board/gth/config.mk
 delete mode 100644 board/gth/ee_access.c
 delete mode 100644 board/gth/ee_access.h
 delete mode 100644 board/gth/ee_dev.h
 delete mode 100644 board/gth/flash.c
 delete mode 100644 board/gth/gth.c
 delete mode 100644 board/gth/pcmcia.c
 delete mode 100644 board/gth/u-boot.lds
MAINTAINERS +0 -4
index d7aec98..08027ae 100644
@@ -262,10 +262,6 @@ Sangmoon Kim <[email protected]>
 	debris		MPC8245
 	KVME080		MPC8245
 
-Thomas Lange <[email protected]>
-
-	GTH		MPC860
-
 Robert Lazarski <[email protected]>
 
 	ATUM8548	MPC8548
MAKEALL +0 -1
index d6d5f5b..e7c87e1 100755
@@ -118,7 +118,6 @@ LIST_8xx="		\
 	GEN860T		\
 	GEN860T_SC	\
 	GENIETV		\
-	GTH		\
 	hermes		\
 	IAD210		\
 	ICU862_100MHz	\
board/gth/Makefile deleted +0 -44

44 lines not on this page · raw message

board/gth/README deleted +0 -18
deleted file mode 100644
index 241c70b..0000000
@@ -1,18 +0,0 @@
-Written by Thomas.Lange at corelatus.com 010805
-
-To make a system for gth that actually works ;-)
-the variable TBASE needs to be set to 0,1 or 2
-depending on location where image is supposed to
-be started from.
-E.g. make TBASE=1
-
-0: Start from RAM, base 0
-
-1: Start from flash_base + 0x10070
-
-2: Start from flash_base + 0x30070
-
-When using 1 or 2, the image is supposed to be launched
-from miniboot that boots the first U-Boot image found in
-flash.
-For miniboot code, description, see www.opensource.se
board/gth/config.mk deleted +0 -40
deleted file mode 100644
index 3c80156..0000000
@@ -1,40 +0,0 @@
-#
-# (C) Copyright 2000, 2001
-# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
-#
-# See file CREDITS for list of people who contributed to this
-# project.
-#
-# This program is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License as
-# published by the Free Software Foundation; either version 2 of
-# the License, or (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
-# MA 02111-1307 USA
-#
-
-#
-ifeq ($(TBASE),0)
-TEXT_BASE = 0
-else
-ifeq ($(TBASE),1)
-TEXT_BASE = 0x80010070
-else
-ifeq ($(TBASE),2)
-TEXT_BASE = 0x80030070
-else
-## Only to make ordinary make work
-TEXT_BASE = 0x90000000
-endif
-endif
-endif
-
-OBJCFLAGS =	--set-section-flags=.ppcenv=contents,alloc,load,data
board/gth/ee_access.c deleted +0 -335

335 lines not on this page · raw message

board/gth/ee_access.h deleted +0 -16
deleted file mode 100644
index e847f2c..0000000
@@ -1,16 +0,0 @@
-/* By Thomas.Lange at Corelatus.com 001025
-
-   Definitions for EEPROM/VOLT METER  DS2438 */
-
-#ifndef INCeeaccessh
-#define INCeeaccessh
-
-int ee_do_command( u8 *Tx, int Tx_len, u8 *Rx, int Rx_len, int Send_skip );
-int ee_init_data(void);
-int ee_crc_ok( u8 *Buffer, int Len, u8 Crc );
-
-#ifndef TRUE
-#define TRUE 1
-#endif
-
-#endif /* INCeeaccessh */
board/gth/ee_dev.h deleted +0 -85

85 lines not on this page · raw message

board/gth/flash.c deleted +0 -649

649 lines not on this page · raw message

board/gth/gth.c deleted +0 -595

595 lines not on this page · raw message

board/gth/pcmcia.c deleted +0 -93

93 lines not on this page · raw message

board/gth/u-boot.lds deleted +0 -127

127 lines not on this page · raw message

boards.cfg +0 -1
index 912224b..3846517 100644
@@ -143,7 +143,6 @@ EP88x		powerpc	mpc8xx		ep88x
 ETX094		powerpc	mpc8xx		etx094
 FLAGADM		powerpc	mpc8xx		flagadm
 GENIETV		powerpc	mpc8xx		genietv
-GTH		powerpc	mpc8xx		gth
 hermes		powerpc	mpc8xx
 IP860		powerpc	mpc8xx		ip860
 LANTEC		powerpc	mpc8xx		lantec
Signature · 1 line
1.7.0.1
#5 lore raw

PATCH 1/1 Drop support for GTH board

Dear Wolfgang,

Quoted 26 lines · Wolfgang Denk

The board maintainer states:

The GTH board is obsolete and has not been manufactured for several years.
To my knowledge, no recent U-Boot build has been tested on that card.

So drop support for this board.

Signed-off-by Wolfgang Denk<[email protected]>
Cc Thomas Lange<[email protected]>
---
  MAINTAINERS           |    4 -
  MAKEALL               |    1 -
  board/gth/Makefile    |   44 ----
  board/gth/README      |   18 --
  board/gth/config.mk   |   40 ---
  board/gth/ee_access.c |  335 -------------------------
  board/gth/ee_access.h |   16 --
  board/gth/ee_dev.h    |   85 -------
  board/gth/flash.c     |  649 -------------------------------------------------
  board/gth/gth.c       |  595 ---------------------------------------------
  board/gth/pcmcia.c    |   93 -------
  board/gth/u-boot.lds  |  127 ----------
  boards.cfg            |    1 -
  13 files changed, 0 insertions(+), 2008 deletions(-)
Quoted 10 lines

delete mode 100644 board/gth/Makefile
delete mode 100644 board/gth/README
delete mode 100644 board/gth/config.mk
delete mode 100644 board/gth/ee_access.c
delete mode 100644 board/gth/ee_access.h
delete mode 100644 board/gth/ee_dev.h
delete mode 100644 board/gth/flash.c
delete mode 100644 board/gth/gth.c
delete mode 100644 board/gth/pcmcia.c
delete mode 100644 board/gth/u-boot.lds

<...>

This patch does not remove all references to the GTH board.

file include/configs/GTH.h remains.

CONFIG_GTH define is used in
cpu/mpc8xx/cpu_init.c
include/commproc.h
common/env_common.c

Regards,
/Thomas

author
#6 lore raw

PATCH 1/1 Drop support for GTH board

Dear Thomas,

Quoted 2 lines · In message <[email protected]> you wrote:

This patch does not remove all references to the GTH board.

Ah. Thanks for the careful review. Patch v2 following.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It all seemed, he thought, to be rather a lot of  trouble  to  go  to
just sharpen a razor blade.  - Terry Pratchett, _The Light Fantastic_
author
#7 lore raw

PATCH v2 1/1 Drop support for GTH board

In reply to Wolfgang Denk

The board maintainer states:

The GTH board is obsolete and has not been manufactured for several years.
To my knowledge, no recent U-Boot build has been tested on that card.

So drop support for this board.

Signed-off-by Wolfgang Denk <[email protected]>
Cc Thomas Lange <[email protected]>

---
V2: Remove remaining references to CONFIG_GTH as pointed out by
Thomas.

 MAINTAINERS                        |    4 -
 MAKEALL                            |    1 -
 arch/powerpc/cpu/mpc8xx/cpu_init.c |    3 +-
 board/gth/Makefile                 |   44 ---
 board/gth/README                   |   18 -
 board/gth/config.mk                |   40 ---
 board/gth/ee_access.c              |  335 -------------------
 board/gth/ee_access.h              |   16 -
 board/gth/ee_dev.h                 |   85 -----
 board/gth/flash.c                  |  649 ------------------------------------
 board/gth/gth.c                    |  595 ---------------------------------
 board/gth/pcmcia.c                 |   93 -----
 board/gth/u-boot.lds               |  127 -------
 boards.cfg                         |    1 -
 common/cmd_ide.c                   |    2 +-
 common/env_common.c                |    2 +-
 include/commproc.h                 |   32 --
 include/configs/GTH.h              |  389 ---------------------
 18 files changed, 3 insertions(+), 2433 deletions(-)
 delete mode 100644 board/gth/Makefile
 delete mode 100644 board/gth/README
 delete mode 100644 board/gth/config.mk
 delete mode 100644 board/gth/ee_access.c
 delete mode 100644 board/gth/ee_access.h
 delete mode 100644 board/gth/ee_dev.h
 delete mode 100644 board/gth/flash.c
 delete mode 100644 board/gth/gth.c
 delete mode 100644 board/gth/pcmcia.c
 delete mode 100644 board/gth/u-boot.lds
 delete mode 100644 include/configs/GTH.h
MAINTAINERS +0 -4
index 9485070..e1183db 100644
@@ -262,10 +262,6 @@ Sangmoon Kim <[email protected]>
 	debris		MPC8245
 	KVME080		MPC8245
 
-Thomas Lange <[email protected]>
-
-	GTH		MPC860
-
 Robert Lazarski <[email protected]>
 
 	ATUM8548	MPC8548
MAKEALL +0 -1
index 4637390..96b41f5 100755
@@ -118,7 +118,6 @@ LIST_8xx="		\
 	GEN860T		\
 	GEN860T_SC	\
 	GENIETV		\
-	GTH		\
 	hermes		\
 	IAD210		\
 	ICU862_100MHz	\
arch/powerpc/cpu/mpc8xx/cpu_init.c +1 -2
index eb0091b..e97ae68 100644
@@ -149,8 +149,7 @@ void cpu_init_f (volatile immap_t * immr)
 	 *  I owe him a free beer. - wd]
 	 */
 
-#if defined(CONFIG_GTH)	        || \
-    defined(CONFIG_HERMES)	|| \
+#if defined(CONFIG_HERMES)	|| \
     defined(CONFIG_ICU862)	|| \
     defined(CONFIG_IP860)	|| \
     defined(CONFIG_IVML24)	|| \
board/gth/Makefile deleted +0 -44

44 lines not on this page · raw message

board/gth/README deleted +0 -18
deleted file mode 100644
index 241c70b..0000000
@@ -1,18 +0,0 @@
-Written by Thomas.Lange at corelatus.com 010805
-
-To make a system for gth that actually works ;-)
-the variable TBASE needs to be set to 0,1 or 2
-depending on location where image is supposed to
-be started from.
-E.g. make TBASE=1
-
-0: Start from RAM, base 0
-
-1: Start from flash_base + 0x10070
-
-2: Start from flash_base + 0x30070
-
-When using 1 or 2, the image is supposed to be launched
-from miniboot that boots the first U-Boot image found in
-flash.
-For miniboot code, description, see www.opensource.se
board/gth/config.mk deleted +0 -40
deleted file mode 100644
index 3c80156..0000000
@@ -1,40 +0,0 @@
-#
-# (C) Copyright 2000, 2001
-# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
-#
-# See file CREDITS for list of people who contributed to this
-# project.
-#
-# This program is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License as
-# published by the Free Software Foundation; either version 2 of
-# the License, or (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
-# MA 02111-1307 USA
-#
-
-#
-ifeq ($(TBASE),0)
-TEXT_BASE = 0
-else
-ifeq ($(TBASE),1)
-TEXT_BASE = 0x80010070
-else
-ifeq ($(TBASE),2)
-TEXT_BASE = 0x80030070
-else
-## Only to make ordinary make work
-TEXT_BASE = 0x90000000
-endif
-endif
-endif
-
-OBJCFLAGS =	--set-section-flags=.ppcenv=contents,alloc,load,data
board/gth/ee_access.c deleted +0 -335

335 lines not on this page · raw message

board/gth/ee_access.h deleted +0 -16
deleted file mode 100644
index e847f2c..0000000
@@ -1,16 +0,0 @@
-/* By Thomas.Lange at Corelatus.com 001025
-
-   Definitions for EEPROM/VOLT METER  DS2438 */
-
-#ifndef INCeeaccessh
-#define INCeeaccessh
-
-int ee_do_command( u8 *Tx, int Tx_len, u8 *Rx, int Rx_len, int Send_skip );
-int ee_init_data(void);
-int ee_crc_ok( u8 *Buffer, int Len, u8 Crc );
-
-#ifndef TRUE
-#define TRUE 1
-#endif
-
-#endif /* INCeeaccessh */
board/gth/ee_dev.h deleted +0 -85

85 lines not on this page · raw message

board/gth/flash.c deleted +0 -649

649 lines not on this page · raw message

board/gth/gth.c deleted +0 -595

595 lines not on this page · raw message

board/gth/pcmcia.c deleted +0 -93

93 lines not on this page · raw message

board/gth/u-boot.lds deleted +0 -127

127 lines not on this page · raw message

boards.cfg +0 -1
index da31c36..5ec7d4f 100644
@@ -143,7 +143,6 @@ EP88x		powerpc	mpc8xx		ep88x
 ETX094		powerpc	mpc8xx		etx094
 FLAGADM		powerpc	mpc8xx		flagadm
 GENIETV		powerpc	mpc8xx		genietv
-GTH		powerpc	mpc8xx		gth
 hermes		powerpc	mpc8xx
 IP860		powerpc	mpc8xx		ip860
 LANTEC		powerpc	mpc8xx		lantec
common/cmd_ide.c +1 -1
index d486697..c83dcc4 100644
@@ -811,7 +811,7 @@ set_pcmcia_timing (int pmode)
 
 /* We only need to swap data if we are running on a big endian cpu. */
 /* But Au1x00 cpu:s already swaps data in big endian mode! */
-#if defined(__LITTLE_ENDIAN) || ( defined(CONFIG_AU1X00) && !defined(CONFIG_GTH2) )
+#if defined(__LITTLE_ENDIAN) || defined(CONFIG_AU1X00)
 #define input_swap_data(x,y,z) input_data(x,y,z)
 #else
 static void
common/env_common.c +1 -1
index 82e4936..460309b 100644
@@ -227,7 +227,7 @@ void env_relocate (void)
 #endif
 
 	if (gd->env_valid == 0) {
-#if defined(CONFIG_GTH)	|| defined(CONFIG_ENV_IS_NOWHERE)	/* Environment not changable */
+#if defined(CONFIG_ENV_IS_NOWHERE)	/* Environment not changable */
 		puts ("Using default environment\n\n");
 #else
 		puts ("*** Warning - bad CRC, using default environment\n\n");
include/commproc.h +0 -32
index 9d28abc..762238e 100644
@@ -828,38 +828,6 @@ typedef struct scc_enet {
 
 #endif	/* CONFIG_GENIETV */
 
-/*** GTH ******************************************************/
-
-#ifdef CONFIG_GTH
-#ifdef CONFIG_FEC_ENET
-#define	FEC_ENET	/* use FEC for EThernet */
-#endif	/* CONFIG_FEC_ETHERNET */
-
-/* This ENET stuff is for GTH 10 Mbit ( SCC ) */
-#define	PROFF_ENET	PROFF_SCC1
-#define	CPM_CR_ENET	CPM_CR_CH_SCC1
-#define	SCC_ENET	0
-
-#define PA_ENET_RXD	((ushort)0x0001) /* PA15 */
-#define PA_ENET_TXD	((ushort)0x0002) /* PA14 */
-#define PA_ENET_TCLK	((ushort)0x0800) /* PA4 */
-#define PA_ENET_RCLK	((ushort)0x0400) /* PA5 */
-
-#define PB_ENET_TENA	((uint)0x00001000) /* PB19 */
-
-#define PC_ENET_CLSN	((ushort)0x0010) /* PC11 */
-#define PC_ENET_RENA	((ushort)0x0020) /* PC10 */
-
-/* NOTE. This is reset for 10Mbit port only */
-#define PC_ENET_RESET	((ushort)0x0100)	/* PC 7 */
-
-#define SICR_ENET_MASK	((uint)0x000000ff)
-
-/* TCLK PA4 -->CLK4, RCLK PA5 -->CLK3 */
-#define SICR_ENET_CLKRT	((uint)0x00000037)
-
-#endif	/* CONFIG_GTH */
-
 /*** HERMES-PRO ******************************************************/
 
 /* The HERMES-PRO uses the FEC on a MPC860T for Ethernet */
include/configs/GTH.h deleted +0 -389

389 lines not on this page · raw message

Signature · 1 line
1.7.1
#8 lore raw

PATCH v2 1/1 Drop support for GTH board

Dear Wolfgang,

Quoted 2 lines · Wolfgang Denk

V2: Remove remaining references to CONFIG_GTH as pointed out by
Thomas.

Patch looks fine, except this:

common/cmd_ide.c set_pcmcia_timing (int pmode) · line 817

Quoted 13 lines
common/cmd_ide.c +1 -1
index d486697..c83dcc4 100644
@@ -811,7 +811,7 @@ set_pcmcia_timing (int pmode)
 
  /* We only need to swap data if we are running on a big endian cpu. */
  /* But Au1x00 cpu:s already swaps data in big endian mode! */
-#if defined(__LITTLE_ENDIAN) || ( defined(CONFIG_AU1X00)&&  !defined(CONFIG_GTH2) )
+#if defined(__LITTLE_ENDIAN) || defined(CONFIG_AU1X00)
  #define input_swap_data(x,y,z) input_data(x,y,z)
  #else
  static void

This removes code for GTH2 board, not the obsolete GTH board. The GTH2 board is still in production.

Regards,
/Thomas

author
#9 lore raw

PATCH v2 1/1 Drop support for GTH board

Dear Thomas,

Quoted 13 lines · In message <[email protected]> you wrote:
Quoted 2 lines · Wolfgang Denk

V2: Remove remaining references to CONFIG_GTH as pointed out by
Thomas.

Patch looks fine, except this:

Quoted 6 lines
common/cmd_ide.c +0 -0
index d486697..c83dcc4 100644
@@ -811,7 +811,7 @@ set_pcmcia_timing (int pmode)
Quoted 10 lines

common/cmd_ide.c set_pcmcia_timing (int pmode) · line 817

Quoted 7 lines
common/cmd_ide.c +1 -1
  /* We only need to swap data if we are running on a big endian cpu. */
  /* But Au1x00 cpu:s already swaps data in big endian mode! */
-#if defined(__LITTLE_ENDIAN) || ( defined(CONFIG_AU1X00)&&  !defined(CONFIG_GTH2) )
+#if defined(__LITTLE_ENDIAN) || defined(CONFIG_AU1X00)
  #define input_swap_data(x,y,z) input_data(x,y,z)
  #else
  static void

This removes code for GTH2 board, not the obsolete GTH board. The GTH2 board is still in production.

Grrrgh. Stupid me.

Patch v3 on the way...

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Every little picofarad has a nanohenry all its own.      - Don Vonada
author
#10 lore raw

PATCH v3 1/1 Drop support for GTH board

In reply to Wolfgang Denk

The board maintainer states:

The GTH board is obsolete and has not been manufactured for several years.
To my knowledge, no recent U-Boot build has been tested on that card.

So drop support for this board.

Signed-off-by Wolfgang Denk <[email protected]>
Cc Thomas Lange <[email protected]>

---
V2: Remove remaining references to CONFIG_GTH as pointed out by
Thomas.
V3: Fix erroneous deletion of a CONFIG_GTH2 reference.

 MAINTAINERS                        |    4 -
 MAKEALL                            |    1 -
 arch/powerpc/cpu/mpc8xx/cpu_init.c |    3 +-
 board/gth/Makefile                 |   44 ---
 board/gth/README                   |   18 -
 board/gth/config.mk                |   40 ---
 board/gth/ee_access.c              |  335 -------------------
 board/gth/ee_access.h              |   16 -
 board/gth/ee_dev.h                 |   85 -----
 board/gth/flash.c                  |  649 ------------------------------------
 board/gth/gth.c                    |  595 ---------------------------------
 board/gth/pcmcia.c                 |   93 -----
 board/gth/u-boot.lds               |  127 -------
 boards.cfg                         |    1 -
 common/env_common.c                |    2 +-
 include/commproc.h                 |   32 --
 include/configs/GTH.h              |  389 ---------------------
 17 files changed, 2 insertions(+), 2432 deletions(-)
 delete mode 100644 board/gth/Makefile
 delete mode 100644 board/gth/README
 delete mode 100644 board/gth/config.mk
 delete mode 100644 board/gth/ee_access.c
 delete mode 100644 board/gth/ee_access.h
 delete mode 100644 board/gth/ee_dev.h
 delete mode 100644 board/gth/flash.c
 delete mode 100644 board/gth/gth.c
 delete mode 100644 board/gth/pcmcia.c
 delete mode 100644 board/gth/u-boot.lds
 delete mode 100644 include/configs/GTH.h
MAINTAINERS +0 -4
index 9485070..e1183db 100644
@@ -262,10 +262,6 @@ Sangmoon Kim <[email protected]>
 	debris		MPC8245
 	KVME080		MPC8245
 
-Thomas Lange <[email protected]>
-
-	GTH		MPC860
-
 Robert Lazarski <[email protected]>
 
 	ATUM8548	MPC8548
MAKEALL +0 -1
index 4637390..96b41f5 100755
@@ -118,7 +118,6 @@ LIST_8xx="		\
 	GEN860T		\
 	GEN860T_SC	\
 	GENIETV		\
-	GTH		\
 	hermes		\
 	IAD210		\
 	ICU862_100MHz	\
arch/powerpc/cpu/mpc8xx/cpu_init.c +1 -2
index eb0091b..e97ae68 100644
@@ -149,8 +149,7 @@ void cpu_init_f (volatile immap_t * immr)
 	 *  I owe him a free beer. - wd]
 	 */
 
-#if defined(CONFIG_GTH)	        || \
-    defined(CONFIG_HERMES)	|| \
+#if defined(CONFIG_HERMES)	|| \
     defined(CONFIG_ICU862)	|| \
     defined(CONFIG_IP860)	|| \
     defined(CONFIG_IVML24)	|| \
board/gth/Makefile deleted +0 -44

44 lines not on this page · raw message

board/gth/README deleted +0 -18
deleted file mode 100644
index 241c70b..0000000
@@ -1,18 +0,0 @@
-Written by Thomas.Lange at corelatus.com 010805
-
-To make a system for gth that actually works ;-)
-the variable TBASE needs to be set to 0,1 or 2
-depending on location where image is supposed to
-be started from.
-E.g. make TBASE=1
-
-0: Start from RAM, base 0
-
-1: Start from flash_base + 0x10070
-
-2: Start from flash_base + 0x30070
-
-When using 1 or 2, the image is supposed to be launched
-from miniboot that boots the first U-Boot image found in
-flash.
-For miniboot code, description, see www.opensource.se
board/gth/config.mk deleted +0 -40
deleted file mode 100644
index 3c80156..0000000
@@ -1,40 +0,0 @@
-#
-# (C) Copyright 2000, 2001
-# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
-#
-# See file CREDITS for list of people who contributed to this
-# project.
-#
-# This program is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License as
-# published by the Free Software Foundation; either version 2 of
-# the License, or (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
-# MA 02111-1307 USA
-#
-
-#
-ifeq ($(TBASE),0)
-TEXT_BASE = 0
-else
-ifeq ($(TBASE),1)
-TEXT_BASE = 0x80010070
-else
-ifeq ($(TBASE),2)
-TEXT_BASE = 0x80030070
-else
-## Only to make ordinary make work
-TEXT_BASE = 0x90000000
-endif
-endif
-endif
-
-OBJCFLAGS =	--set-section-flags=.ppcenv=contents,alloc,load,data
board/gth/ee_access.c deleted +0 -335

335 lines not on this page · raw message

board/gth/ee_access.h deleted +0 -16
deleted file mode 100644
index e847f2c..0000000
@@ -1,16 +0,0 @@
-/* By Thomas.Lange at Corelatus.com 001025
-
-   Definitions for EEPROM/VOLT METER  DS2438 */
-
-#ifndef INCeeaccessh
-#define INCeeaccessh
-
-int ee_do_command( u8 *Tx, int Tx_len, u8 *Rx, int Rx_len, int Send_skip );
-int ee_init_data(void);
-int ee_crc_ok( u8 *Buffer, int Len, u8 Crc );
-
-#ifndef TRUE
-#define TRUE 1
-#endif
-
-#endif /* INCeeaccessh */
board/gth/ee_dev.h deleted +0 -85

85 lines not on this page · raw message

board/gth/flash.c deleted +0 -649

649 lines not on this page · raw message

board/gth/gth.c deleted +0 -595

595 lines not on this page · raw message

board/gth/pcmcia.c deleted +0 -93

93 lines not on this page · raw message

board/gth/u-boot.lds deleted +0 -127

127 lines not on this page · raw message

boards.cfg +0 -1
index da31c36..5ec7d4f 100644
@@ -143,7 +143,6 @@ EP88x		powerpc	mpc8xx		ep88x
 ETX094		powerpc	mpc8xx		etx094
 FLAGADM		powerpc	mpc8xx		flagadm
 GENIETV		powerpc	mpc8xx		genietv
-GTH		powerpc	mpc8xx		gth
 hermes		powerpc	mpc8xx
 IP860		powerpc	mpc8xx		ip860
 LANTEC		powerpc	mpc8xx		lantec
common/env_common.c +1 -1
index 82e4936..460309b 100644
@@ -227,7 +227,7 @@ void env_relocate (void)
 #endif
 
 	if (gd->env_valid == 0) {
-#if defined(CONFIG_GTH)	|| defined(CONFIG_ENV_IS_NOWHERE)	/* Environment not changable */
+#if defined(CONFIG_ENV_IS_NOWHERE)	/* Environment not changable */
 		puts ("Using default environment\n\n");
 #else
 		puts ("*** Warning - bad CRC, using default environment\n\n");
include/commproc.h +0 -32
index 9d28abc..762238e 100644
@@ -828,38 +828,6 @@ typedef struct scc_enet {
 
 #endif	/* CONFIG_GENIETV */
 
-/*** GTH ******************************************************/
-
-#ifdef CONFIG_GTH
-#ifdef CONFIG_FEC_ENET
-#define	FEC_ENET	/* use FEC for EThernet */
-#endif	/* CONFIG_FEC_ETHERNET */
-
-/* This ENET stuff is for GTH 10 Mbit ( SCC ) */
-#define	PROFF_ENET	PROFF_SCC1
-#define	CPM_CR_ENET	CPM_CR_CH_SCC1
-#define	SCC_ENET	0
-
-#define PA_ENET_RXD	((ushort)0x0001) /* PA15 */
-#define PA_ENET_TXD	((ushort)0x0002) /* PA14 */
-#define PA_ENET_TCLK	((ushort)0x0800) /* PA4 */
-#define PA_ENET_RCLK	((ushort)0x0400) /* PA5 */
-
-#define PB_ENET_TENA	((uint)0x00001000) /* PB19 */
-
-#define PC_ENET_CLSN	((ushort)0x0010) /* PC11 */
-#define PC_ENET_RENA	((ushort)0x0020) /* PC10 */
-
-/* NOTE. This is reset for 10Mbit port only */
-#define PC_ENET_RESET	((ushort)0x0100)	/* PC 7 */
-
-#define SICR_ENET_MASK	((uint)0x000000ff)
-
-/* TCLK PA4 -->CLK4, RCLK PA5 -->CLK3 */
-#define SICR_ENET_CLKRT	((uint)0x00000037)
-
-#endif	/* CONFIG_GTH */
-
 /*** HERMES-PRO ******************************************************/
 
 /* The HERMES-PRO uses the FEC on a MPC860T for Ethernet */
include/configs/GTH.h deleted +0 -389

389 lines not on this page · raw message

Signature · 1 line
1.7.1
#11 lore raw

PATCH v3 1/1 Drop support for GTH board

Quoted 7 lines · Wolfgang Denk

The board maintainer states:

The GTH board is obsolete and has not been manufactured for several years.
To my knowledge, no recent U-Boot build has been tested on that card.

Quoted 8 lines

So drop support for this board.

Signed-off-by Wolfgang Denk<[email protected]>
Cc Thomas Lange<[email protected]>

---
V2: Remove remaining references to CONFIG_GTH as pointed out by
Thomas.
V3: Fix erroneous deletion of a CONFIG_GTH2 reference.

Acked-by Thomas Lange<[email protected]>

Regards,
/Thomas

author Applied
#12 lore raw

PATCH v3 1/1 Drop support for GTH board

In reply to Wolfgang Denk
Quoted 7 lines · In message <[email protected]> you wrote:

The board maintainer states:

The GTH board is obsolete and has not been manufactured for several years.
To my knowledge, no recent U-Boot build has been tested on that card.

Quoted 8 lines

So drop support for this board.

Signed-off-by Wolfgang Denk <[email protected]>
Cc Thomas Lange <[email protected]>

---
V2: Remove remaining references to CONFIG_GTH as pointed out by
Thomas.
V3: Fix erroneous deletion of a CONFIG_GTH2 reference.

Applied.

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Punishment becomes ineffective after a certain point. Men become  in-
sensitive.
	-- Eneg, "Patterns of Force", stardate 2534.7