ARM: SAMSUNG: Add keypad device support

PATCH New Joonyoung Shim 3 participants 21 messages Jun 28, 2010 – Aug 3, 2010

Subsystems (5)

Arm (32-bit) Arm sub-architectures HID Arm Samsung Exynos +1 more subsystems

lore

Share & tools

lore

Joonyoung Shim

author

2010-06-28 11:33 UTC #0 lore raw

PATCH v6 1/3 ARM: SAMSUNG: Add keypad device support

This patch adds samsung keypad device definition for samsung cpus.

Signed-off-by Joonyoung Shim <[email protected]>

Signed-off-by Kyungmin Park <[email protected]>

---
 arch/arm/plat-samsung/Kconfig               |    5 ++
 arch/arm/plat-samsung/Makefile              |    1 +
 arch/arm/plat-samsung/dev-keypad.c          |   58 ++++++++++++++++++++++++++
 arch/arm/plat-samsung/include/plat/devs.h   |    2 +
 arch/arm/plat-samsung/include/plat/keypad.h |   59 +++++++++++++++++++++++++++
 5 files changed, 125 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/plat-samsung/dev-keypad.c
 create mode 100644 arch/arm/plat-samsung/include/plat/keypad.h

arch/arm/plat-samsung/Kconfig +5 -0

index 2753fb3..bd007e3 100644
@@ -227,6 +227,11 @@ config SAMSUNG_DEV_TS
 	help
 	    Common in platform device definitions for touchscreen device
 
+config SAMSUNG_DEV_KEYPAD
+	bool
+	help
+	  Compile in platform device definitions for keypad
+
 # DMA
 
 config S3C_DMA

arch/arm/plat-samsung/Makefile +1 -0

index b1d82cc..8269d80 100644
@@ -48,6 +48,7 @@ obj-$(CONFIG_S3C_DEV_RTC)	+= dev-rtc.o
 
 obj-$(CONFIG_SAMSUNG_DEV_ADC)	+= dev-adc.o
 obj-$(CONFIG_SAMSUNG_DEV_TS)	+= dev-ts.o
+obj-$(CONFIG_SAMSUNG_DEV_KEYPAD)	+= dev-keypad.o
 
 # DMA support

arch/arm/plat-samsung/dev-keypad.c new file +58 -0

58 lines not on this page · raw message

arch/arm/plat-samsung/include/plat/devs.h +2 -0

index e6144e4..6d9f01b 100644
@@ -100,6 +100,8 @@ extern struct platform_device s5pc100_device_iis0;
 extern struct platform_device s5pc100_device_iis1;
 extern struct platform_device s5pc100_device_iis2;
 
+extern struct platform_device samsung_device_keypad;
+
 /* s3c2440 specific devices */
 
 #ifdef CONFIG_CPU_S3C2440

arch/arm/plat-samsung/include/plat/keypad.h new file +59 -0

59 lines not on this page · raw message

Signature · 1 line

1.7.0.4

Joonyoung Shim

author

2010-06-28 11:33 UTC #1 lore raw

PATCH v6 2/3 ARM: S5PV210: Add keypad device helpers

This patch adds the keypad device platform helpers for S5PV210 cpu.

Signed-off-by Joonyoung Shim <[email protected]>

Signed-off-by Kyungmin Park <[email protected]>

---
 arch/arm/mach-s5pv210/Kconfig                    |    5 +++
 arch/arm/mach-s5pv210/Makefile                   |    1 +
 arch/arm/mach-s5pv210/cpu.c                      |    4 ++
 arch/arm/mach-s5pv210/include/mach/map.h         |    3 ++
 arch/arm/mach-s5pv210/setup-keypad.c             |   34 ++++++++++++++++++++++
 arch/arm/plat-samsung/include/plat/keypad-core.h |   31 ++++++++++++++++++++
 6 files changed, 78 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-s5pv210/setup-keypad.c
 create mode 100644 arch/arm/plat-samsung/include/plat/keypad-core.h

arch/arm/mach-s5pv210/Kconfig +5 -0

index 0761eac..692d01c 100644
@@ -32,6 +32,11 @@ config S5PV210_SETUP_FB_24BPP
 	help
           Common setup code for S5PV210 with an 24bpp RGB display helper.
 
+config S5PV210_SETUP_KEYPAD
+	bool
+	help
+	  Common setup code for keypad.
+
 config S5PV210_SETUP_SDHCI
         bool
         select S5PV210_SETUP_SDHCI_GPIO

arch/arm/mach-s5pv210/Makefile +1 -0

index 30be9a6..aae592a 100644
@@ -31,5 +31,6 @@ obj-$(CONFIG_S5PC110_DEV_ONENAND) += dev-onenand.o
 obj-$(CONFIG_S5PV210_SETUP_FB_24BPP)	+= setup-fb-24bpp.o
 obj-$(CONFIG_S5PV210_SETUP_I2C1) 	+= setup-i2c1.o
 obj-$(CONFIG_S5PV210_SETUP_I2C2) 	+= setup-i2c2.o
+obj-$(CONFIG_S5PV210_SETUP_KEYPAD)	+= setup-keypad.o
 obj-$(CONFIG_S5PV210_SETUP_SDHCI)       += setup-sdhci.o
 obj-$(CONFIG_S5PV210_SETUP_SDHCI_GPIO)	+= setup-sdhci-gpio.o

arch/arm/mach-s5pv210/cpu.c +4 -0

index 411a4a9..94c632b 100644
@@ -33,6 +33,7 @@
 #include <plat/clock.h>
 #include <plat/s5pv210.h>
 #include <plat/iic-core.h>
+#include <plat/keypad-core.h>
 #include <plat/sdhci.h>
 
 /* Initial IO mappings */

@@ -91,6 +92,9 @@ void __init s5pv210_map_io(void)
 	s3c_i2c0_setname("s3c2440-i2c");
 	s3c_i2c1_setname("s3c2440-i2c");
 	s3c_i2c2_setname("s3c2440-i2c");
+
+	/* Use s5pv210-keypad instead of samsung-keypad */
+	samsung_keypad_setname("s5pv210-keypad");
 }
 
 void __init s5pv210_init_clocks(int xtal)

arch/arm/mach-s5pv210/include/mach/map.h +3 -0

index 34eb168..e2f6e2a 100644
@@ -32,6 +32,8 @@
 #define S5PV210_PA_SPI0		0xE1300000
 #define S5PV210_PA_SPI1		0xE1400000
 
+#define S5PV210_PA_KEYPAD	(0xE1600000)
+
 #define S5PV210_PA_IIC0		(0xE1800000)
 #define S5PV210_PA_IIC1		(0xFAB00000)
 #define S5PV210_PA_IIC2		(0xE1A00000)

@@ -104,5 +106,6 @@
 #define S3C_PA_WDT		S5PV210_PA_WATCHDOG
 
 #define SAMSUNG_PA_ADC		S5PV210_PA_ADC
+#define SAMSUNG_PA_KEYPAD	S5PV210_PA_KEYPAD
 
 #endif /* __ASM_ARCH_MAP_H */

arch/arm/mach-s5pv210/setup-keypad.c new file +34 -0

new file mode 100644
index 0000000..37b2790
@@ -0,0 +1,34 @@
+/*
+ * linux/arch/arm/mach-s5pv210/setup-keypad.c
+ *
+ * Copyright (C) 2010 Samsung Electronics Co.Ltd
+ * Author: Joonyoung Shim <[email protected]>
+ *
+ *  This program is free software; you can redistribute  it and/or modify it
+ *  under  the terms of  the GNU General  Public License as published by the
+ *  Free Software Foundation;  either version 2 of the  License, or (at your
+ *  option) any later version.
+ *
+ */
+
+#include <linux/gpio.h>
+#include <plat/gpio-cfg.h>
+
+void samsung_keypad_cfg_gpio(unsigned int rows, unsigned int cols)
+{
+	unsigned int gpio, end;
+
+	/* Set all the necessary GPH3 pins to special-function 3: KP_ROW[x] */
+	end = S5PV210_GPH3(rows);
+	for (gpio = S5PV210_GPH3(0); gpio < end; gpio++) {
+		s3c_gpio_cfgpin(gpio, S3C_GPIO_SFN(3));
+		s3c_gpio_setpull(gpio, S3C_GPIO_PULL_NONE);
+	}
+
+	/* Set all the necessary GPH2 pins to special-function 3: KP_COL[x] */
+	end = S5PV210_GPH2(cols);
+	for (gpio = S5PV210_GPH2(0); gpio < end; gpio++) {
+		s3c_gpio_cfgpin(gpio, S3C_GPIO_SFN(3));
+		s3c_gpio_setpull(gpio, S3C_GPIO_PULL_NONE);
+	}
+}

arch/arm/plat-samsung/include/plat/keypad-core.h new file +31 -0

new file mode 100644
index 0000000..d513e1b
@@ -0,0 +1,31 @@
+/*
+ * linux/arch/arm/plat-samsung/include/plat/keypad-core.h
+ *
+ * Copyright (C) 2010 Samsung Electronics Co.Ltd
+ * Author: Joonyoung Shim <[email protected]>
+ *
+ * Samsung keypad controller core function
+ *
+ *  This program is free software; you can redistribute  it and/or modify it
+ *  under  the terms of  the GNU General  Public License as published by the
+ *  Free Software Foundation;  either version 2 of the  License, or (at your
+ *  option) any later version.
+ *
+ */
+
+#ifndef __ASM_ARCH_KEYPAD_CORE_H
+#define __ASM_ARCH_KEYPAD_CORE_H
+
+/* These function are only for use with the core support code, such as
+ * the cpu specific initialisation code
+ */
+
+/* re-define device name depending on support. */
+static inline void samsung_keypad_setname(char *name)
+{
+#ifdef CONFIG_SAMSUNG_DEV_KEYPAD
+	samsung_device_keypad.name = name;
+#endif
+}
+
+#endif /* __ASM_ARCH_KEYPAD_CORE_H */

Signature · 1 line

1.7.0.4

Joonyoung Shim

author

2010-06-28 11:33 UTC #2 lore raw

PATCH v6 3/3 input: samsung-keypad - Add samsung keypad driver

In reply to Joonyoung Shim

This patch adds support for keypad driver running on Samsung cpus. This driver is tested on GONI and Aquila board using S5PC110 cpu.

Signed-off-by Joonyoung Shim <[email protected]>

Signed-off-by Kyungmin Park <[email protected]>

---
 drivers/input/keyboard/Kconfig          |    9 +
 drivers/input/keyboard/Makefile         |    1 +
 drivers/input/keyboard/samsung-keypad.c |  491 +++++++++++++++++++++++++++++++
 3 files changed, 501 insertions(+), 0 deletions(-)
 create mode 100644 drivers/input/keyboard/samsung-keypad.c

drivers/input/keyboard/Kconfig +9 -0

index d8fa5d7..bf6a50f 100644
@@ -342,6 +342,15 @@ config KEYBOARD_PXA930_ROTARY
 	  To compile this driver as a module, choose M here: the
 	  module will be called pxa930_rotary.
 
+config KEYBOARD_SAMSUNG
+	tristate "Samsung keypad support"
+	depends on SAMSUNG_DEV_KEYPAD
+	help
+	  Say Y here if you want to use the Samsung keypad.
+
+	  To compile this driver as a module, choose M here: the
+	  module will be called samsung-keypad.
+
 config KEYBOARD_STOWAWAY
 	tristate "Stowaway keyboard"
 	select SERIO

drivers/input/keyboard/Makefile +1 -0

index 4596d0c..8f973ed 100644
@@ -32,6 +32,7 @@ obj-$(CONFIG_KEYBOARD_OPENCORES)	+= opencores-kbd.o
 obj-$(CONFIG_KEYBOARD_PXA27x)		+= pxa27x_keypad.o
 obj-$(CONFIG_KEYBOARD_PXA930_ROTARY)	+= pxa930_rotary.o
 obj-$(CONFIG_KEYBOARD_QT2160)		+= qt2160.o
+obj-$(CONFIG_KEYBOARD_SAMSUNG)		+= samsung-keypad.o
 obj-$(CONFIG_KEYBOARD_SH_KEYSC)		+= sh_keysc.o
 obj-$(CONFIG_KEYBOARD_STOWAWAY)		+= stowaway.o
 obj-$(CONFIG_KEYBOARD_SUNKBD)		+= sunkbd.o

drivers/input/keyboard/samsung-keypad.c new file +491 -0

491 lines not on this page · raw message

Signature · 1 line

1.7.0.4

Joonyoung Shim

author

2010-07-06 07:58 UTC #3 lore raw

PATCH v6 3/3 input: samsung-keypad - Add samsung keypad driver

Hi, Naveen.

Quoted 12 lines · Joonyoung Shim

This patch adds support for keypad driver running on Samsung cpus. This driver is tested on GONI and Aquila board using S5PC110 cpu.
Signed-off-by Joonyoung Shim <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
---
 drivers/input/keyboard/Kconfig          |    9 +
 drivers/input/keyboard/Makefile         |    1 +
 drivers/input/keyboard/samsung-keypad.c |  491 +++++++++++++++++++++++++++++++
 3 files changed, 501 insertions(+), 0 deletions(-)
 create mode 100644 drivers/input/keyboard/samsung-keypad.c

Could you please test this v6 keypad driver on your various targets?

Kukjin Kim

2010-07-06 23:52 UTC #4 lore raw

PATCH v6 3/3 input: samsung-keypad - Add samsung keypad driver

Quoted 13 lines · Joonyoung Shim

Hi, Naveen.
Quoted 9 lines · Joonyoung Shim
This patch adds support for keypad driver running on Samsung cpus. This driver is tested on GONI and Aquila board using S5PC110 cpu.
Signed-off-by Joonyoung Shim <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
---
 drivers/input/keyboard/Kconfig          |    9 +
 drivers/input/keyboard/Makefile         |    1 +
 drivers/input/keyboard/samsung-keypad.c |  491

Quoted 6 lines

+++++++++++++++++++++++++++++++
Quoted 3 lines
 3 files changed, 501 insertions(+), 0 deletions(-)
 create mode 100644 drivers/input/keyboard/samsung-keypad.c
Could you please test this v6 keypad driver on your various targets?

Hi,

I received the test result from Naveen.
And now he is debugging about that.

..his e-mail client has some problem..so I replied...

---
From: Naveen Ch

I've tested with v6 patches and they are working fine on SMDK6410, SMDKC100 and SMDKV210, except for some header inclusion (linux/sched.h) in samsung-keypad.c.

The build breaking error is like following:
(make s5pc100_defconfig and select input->keypad->samsung keypad)

drivers/input/keyboard/samsung-keypad.c: In function 'samsung_keypad_irq':
drivers/input/keyboard/samsung-keypad.c:170: error: 'TASK_UNINTERRUPTIBLE' undeclared (first use in this function) drivers/input/keyboard/samsung-keypad.c:170: error: (Each undeclared identifier is reported only once drivers/input/keyboard/samsung-keypad.c:170: error: for each function it appears in.) drivers/input/keyboard/samsung-keypad.c:170: error: implicit declaration of function 'schedule_timeout' drivers/input/keyboard/samsung-keypad.c: In function 'samsung_keypad_stop':
drivers/input/keyboard/samsung-keypad.c:202: error: 'TASK_NORMAL' undeclared (first use in this function) make[3]: *** [drivers/input/keyboard/samsung-keypad.o] Error 1

---

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

Joonyoung Shim

author

2010-07-07 01:28 UTC #5 lore raw

PATCH v6 3/3 input: samsung-keypad - Add samsung keypad driver

Quoted 34 lines · Kukjin Kim

Quoted 12 lines · Joonyoung Shim
Hi, Naveen.
Quoted 9 lines · Joonyoung Shim
This patch adds support for keypad driver running on Samsung cpus. This driver is tested on GONI and Aquila board using S5PC110 cpu.
Signed-off-by Joonyoung Shim <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
---
 drivers/input/keyboard/Kconfig          |    9 +
 drivers/input/keyboard/Makefile         |    1 +
 drivers/input/keyboard/samsung-keypad.c |  491
Quoted 5 lines
+++++++++++++++++++++++++++++++
Quoted 3 lines
 3 files changed, 501 insertions(+), 0 deletions(-)
 create mode 100644 drivers/input/keyboard/samsung-keypad.c
Could you please test this v6 keypad driver on your various targets?
Hi,
I received the test result from Naveen.
And now he is debugging about that.
..his e-mail client has some problem..so I replied...
---
From: Naveen Ch
I've tested with v6 patches and they are working fine on SMDK6410, SMDKC100 and SMDKV210, except for some header inclusion (linux/sched.h) in samsung-keypad.c.
The build breaking error is like following:
(make s5pc100_defconfig and select input->keypad->samsung keypad)

Quoted 9 lines

drivers/input/keyboard/samsung-keypad.c: In function 'samsung_keypad_irq':
drivers/input/keyboard/samsung-keypad.c:170: error: 'TASK_UNINTERRUPTIBLE' undeclared (first use in this function) drivers/input/keyboard/samsung-keypad.c:170: error: (Each undeclared identifier is reported only once drivers/input/keyboard/samsung-keypad.c:170: error: for each function it appears in.) drivers/input/keyboard/samsung-keypad.c:170: error: implicit declaration of function 'schedule_timeout' drivers/input/keyboard/samsung-keypad.c: In function 'samsung_keypad_stop':
drivers/input/keyboard/samsung-keypad.c:202: error: 'TASK_NORMAL' undeclared (first use in this function) make[3]: *** [drivers/input/keyboard/samsung-keypad.o] Error 1

This error occurs on s5pc100_defconfig having disabled CONFIG_PREEMPT option. I think sched.h should be included to remove like this dependency in driver, are there other ways?

Kukjin Kim

2010-07-09 07:07 UTC #6 lore raw

PATCH v6 3/3 input: samsung-keypad - Add samsung keypad driver

Quoted 49 lines · Joonyoung Shim

Quoted 24 lines · Kukjin Kim
Quoted 12 lines · Joonyoung Shim
Hi, Naveen.
Quoted 9 lines · Joonyoung Shim
This patch adds support for keypad driver running on Samsung cpus. This driver is tested on GONI and Aquila board using S5PC110 cpu.
Signed-off-by Joonyoung Shim <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
---
 drivers/input/keyboard/Kconfig          |    9 +
 drivers/input/keyboard/Makefile         |    1 +
 drivers/input/keyboard/samsung-keypad.c |  491
Quoted 5 lines
+++++++++++++++++++++++++++++++
Quoted 3 lines
 3 files changed, 501 insertions(+), 0 deletions(-)
 create mode 100644 drivers/input/keyboard/samsung-keypad.c
Could you please test this v6 keypad driver on your various targets?
Hi,
I received the test result from Naveen.
And now he is debugging about that.
Quoted 6 lines
..his e-mail client has some problem..so I replied...
---
From: Naveen Ch
I've tested with v6 patches and they are working fine on SMDK6410, SMDKC100
and SMDKV210, except for some header inclusion (linux/sched.h) in samsung- keypad.c.
Quoted 6 lines
The build breaking error is like following:
(make s5pc100_defconfig and select input->keypad->samsung keypad)
drivers/input/keyboard/samsung-keypad.c: In function 'samsung_keypad_irq':
drivers/input/keyboard/samsung-keypad.c:170: error: 'TASK_UNINTERRUPTIBLE'
undeclared (first use in this function)
Quoted 1 line
drivers/input/keyboard/samsung-keypad.c:170: error: (Each undeclared identifier
is reported only once
Quoted 1 line
drivers/input/keyboard/samsung-keypad.c:170: error: for each function it appears
in.)
Quoted 1 line
drivers/input/keyboard/samsung-keypad.c:170: error: implicit declaration of
function 'schedule_timeout'
Quoted 2 lines
drivers/input/keyboard/samsung-keypad.c: In function 'samsung_keypad_stop':
drivers/input/keyboard/samsung-keypad.c:202: error: 'TASK_NORMAL'

Quoted 7 lines

undeclared (first use in this function)
Quoted 2 lines
make[3]: *** [drivers/input/keyboard/samsung-keypad.o] Error 1
This error occurs on s5pc100_defconfig having disabled CONFIG_PREEMPT option. I think sched.h should be included to remove like this dependency in driver, are there other ways?

I'm not sure root cause is that. But as you said, I think need inclusion it for prevent the problem. Actually didn't happen it before..so maybe the some core functions have moved between rc-3 and earlier versions...

Anyway, if no any issues, could you please re-submit updated it soon?

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

Joonyoung Shim

author

2010-07-09 07:39 UTC #7 lore raw

PATCH v6 3/3 input: samsung-keypad - Add samsung keypad driver

Quoted 48 lines · Kukjin Kim

Quoted 47 lines · Joonyoung Shim
Quoted 23 lines · Kukjin Kim
Quoted 12 lines · Joonyoung Shim
Hi, Naveen.
Quoted 9 lines · Joonyoung Shim
This patch adds support for keypad driver running on Samsung cpus. This driver is tested on GONI and Aquila board using S5PC110 cpu.
Signed-off-by Joonyoung Shim <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
---
 drivers/input/keyboard/Kconfig          |    9 +
 drivers/input/keyboard/Makefile         |    1 +
 drivers/input/keyboard/samsung-keypad.c |  491
Quoted 5 lines
+++++++++++++++++++++++++++++++
Quoted 3 lines
 3 files changed, 501 insertions(+), 0 deletions(-)
 create mode 100644 drivers/input/keyboard/samsung-keypad.c
Could you please test this v6 keypad driver on your various targets?
Hi,
I received the test result from Naveen.
And now he is debugging about that.
Quoted 6 lines
..his e-mail client has some problem..so I replied...
---
From: Naveen Ch
I've tested with v6 patches and they are working fine on SMDK6410, SMDKC100
and SMDKV210, except for some header inclusion (linux/sched.h) in samsung- keypad.c.
Quoted 5 lines
The build breaking error is like following:
(make s5pc100_defconfig and select input->keypad->samsung keypad)
drivers/input/keyboard/samsung-keypad.c: In function 'samsung_keypad_irq':
drivers/input/keyboard/samsung-keypad.c:170: error: 'TASK_UNINTERRUPTIBLE'
undeclared (first use in this function)
Quoted 1 line
drivers/input/keyboard/samsung-keypad.c:170: error: (Each undeclared identifier
is reported only once
Quoted 1 line
drivers/input/keyboard/samsung-keypad.c:170: error: for each function it appears
in.)
Quoted 1 line
drivers/input/keyboard/samsung-keypad.c:170: error: implicit declaration of
function 'schedule_timeout'
Quoted 2 lines
drivers/input/keyboard/samsung-keypad.c: In function 'samsung_keypad_stop':
drivers/input/keyboard/samsung-keypad.c:202: error: 'TASK_NORMAL'
undeclared (first use in this function)

Quoted 8 lines

Quoted 5 lines
Quoted 2 lines
make[3]: *** [drivers/input/keyboard/samsung-keypad.o] Error 1
This error occurs on s5pc100_defconfig having disabled CONFIG_PREEMPT option. I think sched.h should be included to remove like this dependency in driver, are there other ways?
I'm not sure root cause is that. But as you said, I think need inclusion it for prevent the problem. Actually didn't happen it before..so maybe the some core functions have moved between rc-3 and earlier versions...

The sched.h is included by below path.

interrupt.h -> hardirq.h -> smp_lock.h -> sched.h

The smp_lock.h in hardirq.h is included if CONFIG_PREEMPT is defined. The samsung keypad driver haven't needed including sched.h before Dmitry's patch is applied..

Quoted 2 lines

Anyway, if no any issues, could you please re-submit updated it soon?

I haven't get yet Dmitry's review of v6 patch set, so i am waiting it.

Thanks.

Joonyoung Shim

author

2010-07-21 05:42 UTC #8 lore raw

PATCH v6 3/3 input: samsung-keypad - Add samsung keypad driver

Hi, Dmitry.

Quoted 61 lines · Joonyoung Shim

Quoted 47 lines · Kukjin Kim
Quoted 46 lines · Joonyoung Shim
Quoted 23 lines · Kukjin Kim
Quoted 12 lines · Joonyoung Shim
Hi, Naveen.
Quoted 9 lines · Joonyoung Shim
This patch adds support for keypad driver running on Samsung cpus. This driver is tested on GONI and Aquila board using S5PC110 cpu.
Signed-off-by Joonyoung Shim <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
---
 drivers/input/keyboard/Kconfig          |    9 +
 drivers/input/keyboard/Makefile         |    1 +
 drivers/input/keyboard/samsung-keypad.c |  491
Quoted 5 lines
+++++++++++++++++++++++++++++++
Quoted 3 lines
 3 files changed, 501 insertions(+), 0 deletions(-)
 create mode 100644 drivers/input/keyboard/samsung-keypad.c
Could you please test this v6 keypad driver on your various targets?
Hi,
I received the test result from Naveen.
And now he is debugging about that.
Quoted 6 lines
..his e-mail client has some problem..so I replied...
---
From: Naveen Ch
I've tested with v6 patches and they are working fine on SMDK6410, SMDKC100
and SMDKV210, except for some header inclusion (linux/sched.h) in samsung- keypad.c.
Quoted 5 lines
The build breaking error is like following:
(make s5pc100_defconfig and select input->keypad->samsung keypad)
drivers/input/keyboard/samsung-keypad.c: In function 'samsung_keypad_irq':
drivers/input/keyboard/samsung-keypad.c:170: error: 'TASK_UNINTERRUPTIBLE'
undeclared (first use in this function)
Quoted 1 line
drivers/input/keyboard/samsung-keypad.c:170: error: (Each undeclared identifier
is reported only once
Quoted 1 line
drivers/input/keyboard/samsung-keypad.c:170: error: for each function it appears
in.)
Quoted 1 line
drivers/input/keyboard/samsung-keypad.c:170: error: implicit declaration of
function 'schedule_timeout'
Quoted 2 lines
drivers/input/keyboard/samsung-keypad.c: In function 'samsung_keypad_stop':
drivers/input/keyboard/samsung-keypad.c:202: error: 'TASK_NORMAL'
Quoted 8 lines
Quoted 6 lines
undeclared (first use in this function)
Quoted 2 lines
make[3]: *** [drivers/input/keyboard/samsung-keypad.o] Error 1
This error occurs on s5pc100_defconfig having disabled CONFIG_PREEMPT option. I think sched.h should be included to remove like this dependency in driver, are there other ways?
I'm not sure root cause is that. But as you said, I think need inclusion it for prevent the problem. Actually didn't happen it before..so maybe the some core functions have moved between rc-3 and earlier versions...
The sched.h is included by below path.
interrupt.h -> hardirq.h -> smp_lock.h -> sched.h

Quoted 8 lines

The smp_lock.h in hardirq.h is included if CONFIG_PREEMPT is defined. The samsung keypad driver haven't needed including sched.h before Dmitry's patch is applied..
Quoted 1 line
Anyway, if no any issues, could you please re-submit updated it soon?
I haven't get yet Dmitry's review of v6 patch set, so i am waiting it.

Ping.

Do you have any feedback? If ok, i want to go to input tree or samsung tree these added sched.h including.

Kukjin Kim

2010-07-21 06:21 UTC #9 lore raw

PATCH v6 3/3 input: samsung-keypad - Add samsung keypad driver

Quoted 79 lines · Joonyoung Shim

Hi, Dmitry.
Quoted 26 lines · Joonyoung Shim
Quoted 25 lines · Kukjin Kim
Quoted 24 lines · Joonyoung Shim
Quoted 23 lines · Kukjin Kim
Quoted 12 lines · Joonyoung Shim
Hi, Naveen.
Quoted 9 lines · Joonyoung Shim
This patch adds support for keypad driver running on Samsung cpus. This driver is tested on GONI and Aquila board using S5PC110 cpu.
Signed-off-by Joonyoung Shim <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
---
 drivers/input/keyboard/Kconfig          |    9 +
 drivers/input/keyboard/Makefile         |    1 +
 drivers/input/keyboard/samsung-keypad.c |  491
Quoted 5 lines
+++++++++++++++++++++++++++++++
Quoted 3 lines
 3 files changed, 501 insertions(+), 0 deletions(-)
 create mode 100644 drivers/input/keyboard/samsung-keypad.c
Could you please test this v6 keypad driver on your various targets?
Hi,
I received the test result from Naveen.
And now he is debugging about that.
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
..his e-mail client has some problem..so I replied...
---
From: Naveen Ch
I've tested with v6 patches and they are working fine on SMDK6410,
SMDKC100
Quoted 1 line
Quoted 1 line
Quoted 1 line
and SMDKV210, except for some header inclusion (linux/sched.h) in
samsung-
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
keypad.c.
Quoted 5 lines
The build breaking error is like following:
(make s5pc100_defconfig and select input->keypad->samsung keypad)
drivers/input/keyboard/samsung-keypad.c: In function 'samsung_keypad_irq':
drivers/input/keyboard/samsung-keypad.c:170: error:
'TASK_UNINTERRUPTIBLE'
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
undeclared (first use in this function)
Quoted 1 line
drivers/input/keyboard/samsung-keypad.c:170: error: (Each undeclared
identifier
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
is reported only once
Quoted 1 line
drivers/input/keyboard/samsung-keypad.c:170: error: for each function it
appears
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
in.)
Quoted 1 line
drivers/input/keyboard/samsung-keypad.c:170: error: implicit declaration of
function 'schedule_timeout'
Quoted 1 line
drivers/input/keyboard/samsung-keypad.c: In function
'samsung_keypad_stop':
Quoted 8 lines
Quoted 8 lines
Quoted 7 lines
Quoted 1 line
drivers/input/keyboard/samsung-keypad.c:202: error: 'TASK_NORMAL'
undeclared (first use in this function)
Quoted 2 lines
make[3]: *** [drivers/input/keyboard/samsung-keypad.o] Error 1
This error occurs on s5pc100_defconfig having disabled CONFIG_PREEMPT option. I think sched.h should be included to remove like this dependency in driver, are there other ways?
I'm not sure root cause is that. But as you said, I think need inclusion it for
prevent the problem.
Quoted 1 line
Quoted 1 line
Actually didn't happen it before..so maybe the some core functions have
moved between rc-3 and earlier versions...
Quoted 11 lines
The sched.h is included by below path.
interrupt.h -> hardirq.h -> smp_lock.h -> sched.h
The smp_lock.h in hardirq.h is included if CONFIG_PREEMPT is defined. The samsung keypad driver haven't needed including sched.h before Dmitry's patch is applied..
Quoted 1 line
Anyway, if no any issues, could you please re-submit updated it soon?

Quoted 7 lines

Quoted 2 lines
I haven't get yet Dmitry's review of v6 patch set, so i am waiting it.
Ping.
Do you have any feedback? If ok, i want to go to input tree or samsung tree these added sched.h including.

With including sched.h and Naveen's keypad support patches for SMDK6410, SMDKC100 and SMDKV210:

[ch.naveen at samsung.com: tested on SMDK6410, SMDKC100, and SMDKV210]

Tested-by Naveen Krishna Ch <[email protected]>

Acked-by Kukjin Kim <[email protected]>

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

Dmitry Torokhov

maintainer

2010-07-21 08:07 UTC #10 lore raw

PATCH v6 3/3 input: samsung-keypad - Add samsung keypad driver

In reply to Joonyoung Shim

Hi Joonyoung,

Quoted 70 lines · Joonyoung Shim

Hi, Dmitry.
Quoted 67 lines · Joonyoung Shim
Quoted 47 lines · Kukjin Kim
Quoted 46 lines · Joonyoung Shim
Quoted 23 lines · Kukjin Kim
Quoted 12 lines · Joonyoung Shim
Hi, Naveen.
Quoted 9 lines · Joonyoung Shim
This patch adds support for keypad driver running on Samsung cpus. This driver is tested on GONI and Aquila board using S5PC110 cpu.
Signed-off-by Joonyoung Shim <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
---
 drivers/input/keyboard/Kconfig          |    9 +
 drivers/input/keyboard/Makefile         |    1 +
 drivers/input/keyboard/samsung-keypad.c |  491
Quoted 5 lines
+++++++++++++++++++++++++++++++
Quoted 3 lines
 3 files changed, 501 insertions(+), 0 deletions(-)
 create mode 100644 drivers/input/keyboard/samsung-keypad.c
Could you please test this v6 keypad driver on your various targets?
Hi,
I received the test result from Naveen.
And now he is debugging about that.
Quoted 6 lines
..his e-mail client has some problem..so I replied...
---
From: Naveen Ch
I've tested with v6 patches and they are working fine on SMDK6410, SMDKC100
and SMDKV210, except for some header inclusion (linux/sched.h) in samsung- keypad.c.
Quoted 5 lines
The build breaking error is like following:
(make s5pc100_defconfig and select input->keypad->samsung keypad)
drivers/input/keyboard/samsung-keypad.c: In function 'samsung_keypad_irq':
drivers/input/keyboard/samsung-keypad.c:170: error: 'TASK_UNINTERRUPTIBLE'
undeclared (first use in this function)
Quoted 1 line
drivers/input/keyboard/samsung-keypad.c:170: error: (Each undeclared identifier
is reported only once
Quoted 1 line
drivers/input/keyboard/samsung-keypad.c:170: error: for each function it appears
in.)
Quoted 1 line
drivers/input/keyboard/samsung-keypad.c:170: error: implicit declaration of
function 'schedule_timeout'
Quoted 2 lines
drivers/input/keyboard/samsung-keypad.c: In function 'samsung_keypad_stop':
drivers/input/keyboard/samsung-keypad.c:202: error: 'TASK_NORMAL'
Quoted 8 lines
Quoted 6 lines
undeclared (first use in this function)
Quoted 2 lines
make[3]: *** [drivers/input/keyboard/samsung-keypad.o] Error 1
This error occurs on s5pc100_defconfig having disabled CONFIG_PREEMPT option. I think sched.h should be included to remove like this dependency in driver, are there other ways?
I'm not sure root cause is that. But as you said, I think need inclusion it for prevent the problem. Actually didn't happen it before..so maybe the some core functions have moved between rc-3 and earlier versions...
The sched.h is included by below path.
interrupt.h -> hardirq.h -> smp_lock.h -> sched.h
The smp_lock.h in hardirq.h is included if CONFIG_PREEMPT is defined. The samsung keypad driver haven't needed including sched.h before Dmitry's patch is applied..
Quoted 1 line
Anyway, if no any issues, could you please re-submit updated it soon?

Quoted 7 lines

Quoted 2 lines
I haven't get yet Dmitry's review of v6 patch set, so i am waiting it.
Ping.
Do you have any feedback? If ok, i want to go to input tree or samsung tree these added sched.h including.

I applied the patch adding samsung-keypad.c and the platform data arch/arm/plat-samsung/include/plat/keypad.h and I expect that patches to actually enable keypad will go through appropriate platform tree(s).

The only caveat is that I removed declarations for copying platform data around and for gpio config function - if it is there there is no point of invoking it through the pointer in platform data.

Overall I am confused why you set up keypad in platform code in the way you do. I'd put the device definitions and all supporting functions in the same module that registers platform device and be done with it.

Thanks.

Signature · 1 line

Dmitry

Joonyoung Shim

author

2010-07-21 09:01 UTC #11 lore raw

PATCH v6 3/3 input: samsung-keypad - Add samsung keypad driver

Quoted 75 lines · Dmitry Torokhov

Hi Joonyoung,
Quoted 72 lines · Joonyoung Shim
Hi, Dmitry.
Quoted 58 lines · Joonyoung Shim
Quoted 47 lines · Kukjin Kim
Quoted 46 lines · Joonyoung Shim
Quoted 23 lines · Kukjin Kim
Quoted 12 lines · Joonyoung Shim
Hi, Naveen.
Quoted 9 lines · Joonyoung Shim
This patch adds support for keypad driver running on Samsung cpus. This driver is tested on GONI and Aquila board using S5PC110 cpu.
Signed-off-by Joonyoung Shim <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
---
 drivers/input/keyboard/Kconfig          |    9 +
 drivers/input/keyboard/Makefile         |    1 +
 drivers/input/keyboard/samsung-keypad.c |  491
Quoted 5 lines
+++++++++++++++++++++++++++++++
Quoted 3 lines
 3 files changed, 501 insertions(+), 0 deletions(-)
 create mode 100644 drivers/input/keyboard/samsung-keypad.c
Could you please test this v6 keypad driver on your various targets?
Hi,
I received the test result from Naveen.
And now he is debugging about that.
Quoted 6 lines
..his e-mail client has some problem..so I replied...
---
From: Naveen Ch
I've tested with v6 patches and they are working fine on SMDK6410, SMDKC100
and SMDKV210, except for some header inclusion (linux/sched.h) in samsung- keypad.c.
Quoted 5 lines
The build breaking error is like following:
(make s5pc100_defconfig and select input->keypad->samsung keypad)
drivers/input/keyboard/samsung-keypad.c: In function 'samsung_keypad_irq':
drivers/input/keyboard/samsung-keypad.c:170: error: 'TASK_UNINTERRUPTIBLE'
undeclared (first use in this function)
Quoted 1 line
drivers/input/keyboard/samsung-keypad.c:170: error: (Each undeclared identifier
is reported only once
Quoted 1 line
drivers/input/keyboard/samsung-keypad.c:170: error: for each function it appears
in.)
Quoted 1 line
drivers/input/keyboard/samsung-keypad.c:170: error: implicit declaration of
function 'schedule_timeout'
Quoted 2 lines
drivers/input/keyboard/samsung-keypad.c: In function 'samsung_keypad_stop':
drivers/input/keyboard/samsung-keypad.c:202: error: 'TASK_NORMAL'
Quoted 8 lines
Quoted 6 lines
undeclared (first use in this function)
Quoted 2 lines
make[3]: *** [drivers/input/keyboard/samsung-keypad.o] Error 1
This error occurs on s5pc100_defconfig having disabled CONFIG_PREEMPT option. I think sched.h should be included to remove like this dependency in driver, are there other ways?
I'm not sure root cause is that. But as you said, I think need inclusion it for prevent the problem. Actually didn't happen it before..so maybe the some core functions have moved between rc-3 and earlier versions...
The sched.h is included by below path.
Quoted 9 lines
interrupt.h -> hardirq.h -> smp_lock.h -> sched.h
The smp_lock.h in hardirq.h is included if CONFIG_PREEMPT is defined. The samsung keypad driver haven't needed including sched.h before Dmitry's patch is applied..
Quoted 1 line
Anyway, if no any issues, could you please re-submit updated it soon?
I haven't get yet Dmitry's review of v6 patch set, so i am waiting it.
Ping.

Quoted 8 lines

Quoted 2 lines
Do you have any feedback? If ok, i want to go to input tree or samsung tree these added sched.h including.
I applied the patch adding samsung-keypad.c and the platform data arch/arm/plat-samsung/include/plat/keypad.h and I expect that patches to actually enable keypad will go through appropriate platform tree(s).

OK, the rest will go through samsung platform tree

Quoted 4 lines

The only caveat is that I removed declarations for copying platform data around and for gpio config function - if it is there there is no point of invoking it through the pointer in platform data.

I agree, but currently samsung platform framework uses such this way. I believe these can change later at once.

Quoted 4 lines

Overall I am confused why you set up keypad in platform code in the way you do. I'd put the device definitions and all supporting functions in the same module that registers platform device and be done with it.

Thanks.

Kukjin Kim

2010-07-21 12:39 UTC #12 lore raw

PATCH v6 3/3 input: samsung-keypad - Add samsung keypad driver

Quoted 92 lines · Joonyoung Shim

Quoted 14 lines · Dmitry Torokhov
Hi Joonyoung,
Quoted 11 lines · Joonyoung Shim
Hi, Dmitry.
Quoted 8 lines · Joonyoung Shim
Quoted 7 lines · Kukjin Kim
Quoted 6 lines · Joonyoung Shim
Quoted 5 lines · Kukjin Kim
Quoted 4 lines · Joonyoung Shim
Hi, Naveen.
Quoted 1 line · Joonyoung Shim
This patch adds support for keypad driver running on Samsung cpus.
This
Quoted 18 lines
Quoted 18 lines
Quoted 18 lines
Quoted 18 lines
Quoted 18 lines
Quoted 18 lines
Quoted 8 lines
Quoted 8 lines
driver is tested on GONI and Aquila board using S5PC110 cpu.
Signed-off-by Joonyoung Shim <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
---
 drivers/input/keyboard/Kconfig          |    9 +
 drivers/input/keyboard/Makefile         |    1 +
 drivers/input/keyboard/samsung-keypad.c |  491
Quoted 5 lines
+++++++++++++++++++++++++++++++
Quoted 3 lines
 3 files changed, 501 insertions(+), 0 deletions(-)
 create mode 100644 drivers/input/keyboard/samsung-keypad.c
Could you please test this v6 keypad driver on your various targets?
Hi,
I received the test result from Naveen.
And now he is debugging about that.
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
..his e-mail client has some problem..so I replied...
---
From: Naveen Ch
I've tested with v6 patches and they are working fine on SMDK6410,
SMDKC100
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
and SMDKV210, except for some header inclusion (linux/sched.h) in
samsung-
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
keypad.c.
Quoted 4 lines
The build breaking error is like following:
(make s5pc100_defconfig and select input->keypad->samsung keypad)
drivers/input/keyboard/samsung-keypad.c: In function
'samsung_keypad_irq':
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
drivers/input/keyboard/samsung-keypad.c:170: error:
'TASK_UNINTERRUPTIBLE'
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
undeclared (first use in this function)
Quoted 1 line
drivers/input/keyboard/samsung-keypad.c:170: error: (Each undeclared
identifier
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
is reported only once
Quoted 1 line
drivers/input/keyboard/samsung-keypad.c:170: error: for each function it
appears
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
in.)
Quoted 1 line
drivers/input/keyboard/samsung-keypad.c:170: error: implicit declaration
of
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
function 'schedule_timeout'
Quoted 1 line
drivers/input/keyboard/samsung-keypad.c: In function
'samsung_keypad_stop':
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 1 line
drivers/input/keyboard/samsung-keypad.c:202: error: 'TASK_NORMAL'
undeclared (first use in this function)
Quoted 2 lines
make[3]: *** [drivers/input/keyboard/samsung-keypad.o] Error 1
This error occurs on s5pc100_defconfig having disabled
CONFIG_PREEMPT
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 2 lines
option. I think sched.h should be included to remove like this dependency in driver, are there other ways?
I'm not sure root cause is that. But as you said, I think need inclusion it for
prevent the problem.
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Actually didn't happen it before..so maybe the some core functions have
moved between rc-3 and earlier versions...
Quoted 16 lines
Quoted 15 lines
Quoted 11 lines
The sched.h is included by below path.
interrupt.h -> hardirq.h -> smp_lock.h -> sched.h
The smp_lock.h in hardirq.h is included if CONFIG_PREEMPT is defined. The samsung keypad driver haven't needed including sched.h before Dmitry's patch is applied..
Quoted 1 line
Anyway, if no any issues, could you please re-submit updated it soon?
I haven't get yet Dmitry's review of v6 patch set, so i am waiting it.
Ping.
Do you have any feedback? If ok, i want to go to input tree or samsung tree these added sched.h including.

Quoted 8 lines

Quoted 5 lines
I applied the patch adding samsung-keypad.c and the platform data arch/arm/plat-samsung/include/plat/keypad.h and I expect that patches to actually enable keypad will go through appropriate platform tree(s).
OK, the rest will go through samsung platform tree

Ok..will apply.

Quoted 8 lines

Quoted 4 lines
The only caveat is that I removed declarations for copying platform data around and for gpio config function - if it is there there is no point of invoking it through the pointer in platform data.
I agree, but currently samsung platform framework uses such this way. I believe these can change later at once.

Quoted 6 lines

Quoted 4 lines
Overall I am confused why you set up keypad in platform code in the way you do. I'd put the device definitions and all supporting functions in the same module that registers platform device and be done with it.
Thanks.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

Joonyoung Shim

author

2010-08-02 03:09 UTC #13 lore raw

PATCH v6 3/3 input: samsung-keypad - Add samsung keypad driver

Hi, I came back from vacation.

Quoted 11 lines

Quoted 9 lines
Quoted 7 lines
Quoted 2 lines
Do you have any feedback? If ok, i want to go to input tree or samsung tree these added sched.h including.
I applied the patch adding samsung-keypad.c and the platform data arch/arm/plat-samsung/include/plat/keypad.h and I expect that patches to actually enable keypad will go through appropriate platform tree(s).
OK, the rest will go through samsung platform tree
Ok..will apply.

Kukjin, could you remove keypad.h on the commit "ARM: SAMSUNG: Add keypad device support" of the samsung platform tree. The keypad.h file was included on input tree.
(http://git.kernel.org/?p=linux/kernel/git/dtor/input.git;a=commit;h=0fffed27f92d9d7a34de9fe017b7082b5958bb93)

Quoted 7 lines

Quoted 7 lines
Quoted 4 lines
The only caveat is that I removed declarations for copying platform data around and for gpio config function - if it is there there is no point of invoking it through the pointer in platform data.
I agree, but currently samsung platform framework uses such this way. I believe these can change later at once.

Dmitry, could you apply original keypad.h. We can get problem such this on most samsung device driver too. As i said before, these can be fixed later.

Quoted 21 lines

Quoted 5 lines
Quoted 4 lines
Overall I am confused why you set up keypad in platform code in the way you do. I'd put the device definitions and all supporting functions in the same module that registers platform device and be done with it.
Thanks.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Kukjin Kim

2010-08-02 03:38 UTC #14 lore raw

PATCH v6 3/3 input: samsung-keypad - Add samsung keypad driver

Quoted 12 lines · Joonyoung Shim

Hi, I came back from vacation.
Quoted 9 lines
Quoted 9 lines
Quoted 7 lines
Quoted 2 lines
Do you have any feedback? If ok, i want to go to input tree or samsung tree these added sched.h including.
I applied the patch adding samsung-keypad.c and the platform data arch/arm/plat-samsung/include/plat/keypad.h and I expect that patches to actually enable keypad will go through appropriate platform tree(s).
OK, the rest will go through samsung platform tree

Quoted 8 lines

Quoted 2 lines
Ok..will apply.
Kukjin, could you remove keypad.h on the commit "ARM: SAMSUNG: Add keypad device support" of the samsung platform tree. The keypad.h file was included on input tree.
(http://git.kernel.org/?p=linux/kernel/git/dtor/input.git;a=commit;h=0fffed27f92d9d7
a34de9fe017b7082b5958bb93)

You mean in plat-samsung/dev-keypad.c?
If remove inclusion plat/keypad.h in there, following build error happens.

arch/arm/plat-samsung/dev-keypad.c:41: warning: 'struct samsung_keypad_platdata' declared inside parameter list arch/arm/plat-samsung/dev-keypad.c:41: warning: its scope is only this definition or declaration, which is probably not what you want arch/arm/plat-samsung/dev-keypad.c: In function 'samsung_keypad_set_platdata':
arch/arm/plat-samsung/dev-keypad.c:50: error: invalid application of 'sizeof' to incomplete type 'struct samsung_keypad_platdata' arch/arm/plat-samsung/dev-keypad.c:54: error: dereferencing pointer to incomplete type arch/arm/plat-samsung/dev-keypad.c:55: error: dereferencing pointer to incomplete type arch/arm/plat-samsung/dev-keypad.c:55: error: 'samsung_keypad_cfg_gpio' undeclared (first use in this function) arch/arm/plat-samsung/dev-keypad.c:55: error: (Each undeclared identifier is reported only once arch/arm/plat-samsung/dev-keypad.c:55: error: for each function it appears in.)
make[1]: *** [arch/arm/plat-samsung/dev-keypad.o] Error 1

As you know, released 35 today. So we have no much time for this merge window.

Quoted 5 lines

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
The only caveat is that I removed declarations for copying platform data around and for gpio config function - if it is there there is no point of invoking it through the pointer in platform data.

Quoted 15 lines

Quoted 3 lines
Quoted 3 lines
I agree, but currently samsung platform framework uses such this way. I believe these can change later at once.
Dmitry, could you apply original keypad.h. We can get problem such this on most samsung device driver too. As i said before, these can be fixed later.
Quoted 7 lines
Quoted 5 lines
Quoted 4 lines
Overall I am confused why you set up keypad in platform code in the way you do. I'd put the device definitions and all supporting functions in the same module that registers platform device and be done with it.
Thanks.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

Joonyoung Shim

author

2010-08-02 04:41 UTC #15 lore raw

PATCH v6 3/3 input: samsung-keypad - Add samsung keypad driver

Quoted 14 lines · Kukjin Kim

Quoted 13 lines · Joonyoung Shim
Hi, I came back from vacation.
Quoted 11 lines
Quoted 9 lines
Quoted 7 lines
Quoted 2 lines
Do you have any feedback? If ok, i want to go to input tree or samsung tree these added sched.h including.
I applied the patch adding samsung-keypad.c and the platform data arch/arm/plat-samsung/include/plat/keypad.h and I expect that patches to actually enable keypad will go through appropriate platform tree(s).
OK, the rest will go through samsung platform tree
Ok..will apply.

Quoted 9 lines

Quoted 5 lines
Kukjin, could you remove keypad.h on the commit "ARM: SAMSUNG: Add keypad device support" of the samsung platform tree. The keypad.h file was included on input tree.
(http://git.kernel.org/?p=linux/kernel/git/dtor/input.git;a=commit;h=0fffed27f92d9d7
a34de9fe017b7082b5958bb93)
You mean in plat-samsung/dev-keypad.c?
If remove inclusion plat/keypad.h in there, following build error happens.

No. I mean to remove arch/arm/plat-samsung/include/plat/keypad.h file on samsung platform tree, it was applied on input tree already. If needs, i can repost.

Quoted 11 lines

arch/arm/plat-samsung/dev-keypad.c:41: warning: 'struct samsung_keypad_platdata' declared inside parameter list arch/arm/plat-samsung/dev-keypad.c:41: warning: its scope is only this definition or declaration, which is probably not what you want arch/arm/plat-samsung/dev-keypad.c: In function 'samsung_keypad_set_platdata':
arch/arm/plat-samsung/dev-keypad.c:50: error: invalid application of 'sizeof' to incomplete type 'struct samsung_keypad_platdata' arch/arm/plat-samsung/dev-keypad.c:54: error: dereferencing pointer to incomplete type arch/arm/plat-samsung/dev-keypad.c:55: error: dereferencing pointer to incomplete type arch/arm/plat-samsung/dev-keypad.c:55: error: 'samsung_keypad_cfg_gpio' undeclared (first use in this function) arch/arm/plat-samsung/dev-keypad.c:55: error: (Each undeclared identifier is reported only once arch/arm/plat-samsung/dev-keypad.c:55: error: for each function it appears in.)
make[1]: *** [arch/arm/plat-samsung/dev-keypad.o] Error 1

Quoted 2 lines

As you know, released 35 today. So we have no much time for this merge window.

I'm not sure about merge rule, but I think the compile problem can be solved by merge to 36 of input tree and samsung platform tree.

Kukjin Kim

2010-08-02 05:12 UTC #16 lore raw

PATCH v6 3/3 input: samsung-keypad - Add samsung keypad driver

Quoted 23 lines · Joonyoung Shim

Quoted 10 lines · Kukjin Kim
Quoted 9 lines · Joonyoung Shim
Hi, I came back from vacation.
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 2 lines
Do you have any feedback? If ok, i want to go to input tree or samsung tree these added sched.h including.
I applied the patch adding samsung-keypad.c and the platform data arch/arm/plat-samsung/include/plat/keypad.h and I expect that patches to actually enable keypad will go through appropriate platform tree(s).
Quoted 8 lines
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
OK, the rest will go through samsung platform tree
Ok..will apply.
Kukjin, could you remove keypad.h on the commit "ARM: SAMSUNG: Add keypad device support" of the samsung platform tree. The keypad.h file was included on input tree.
(http://git.kernel.org/?p=linux/kernel/git/dtor/input.git;a=commit;h=0fffed27f92d9d7
Quoted 2 lines
Quoted 1 line
a34de9fe017b7082b5958bb93)

Quoted 8 lines

Quoted 3 lines
You mean in plat-samsung/dev-keypad.c?
If remove inclusion plat/keypad.h in there, following build error happens.
No. I mean to remove arch/arm/plat-samsung/include/plat/keypad.h file on samsung platform tree, it was applied on input tree already. If needs, i can repost.

If it is not small change like to remove a file in a patch, I think should be re-submitted. Will drop your previous patch in my tree.

Quoted 19 lines

Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c:41: warning: 'struct
samsung_keypad_platdata' declared inside parameter list
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c:41: warning: its scope is only this definition
or declaration, which is probably not what you want
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c: In function
'samsung_keypad_set_platdata':
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c:50: error: invalid application of 'sizeof' to
incomplete type 'struct samsung_keypad_platdata'
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c:54: error: dereferencing pointer to
incomplete type
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c:55: error: dereferencing pointer to
incomplete type
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c:55: error: 'samsung_keypad_cfg_gpio'
undeclared (first use in this function)
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c:55: error: (Each undeclared identifier is
reported only once
Quoted 3 lines
arch/arm/plat-samsung/dev-keypad.c:55: error: for each function it appears in.) make[1]: *** [arch/arm/plat-samsung/dev-keypad.o] Error 1

Quoted 6 lines

Quoted 1 line
As you know, released 35 today. So we have no much time for this merge
window.
Quoted 1 line
I'm not sure about merge rule, but I think the compile problem can be solved by merge to 36 of input tree and samsung platform tree.

Hmm...actually, already informed about that on linux-next.
If it's just build problem, I or Dmitry can fix it. However, this is not just that. I cannot understand how your 'plat/keypad.h' was included to both of patch. And I'm not sure, should be 'plat/keypad.h' in which tree...

Anyway, as I said, should be solved that as soon as possible....

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

Joonyoung Shim

author

2010-08-02 05:52 UTC #17 lore raw

PATCH v6 3/3 input: samsung-keypad - Add samsung keypad driver

Quoted 51 lines · Kukjin Kim

Quoted 19 lines · Joonyoung Shim
Quoted 10 lines · Kukjin Kim
Quoted 9 lines · Joonyoung Shim
Hi, I came back from vacation.
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 2 lines
Do you have any feedback? If ok, i want to go to input tree or samsung tree these added sched.h including.
I applied the patch adding samsung-keypad.c and the platform data arch/arm/plat-samsung/include/plat/keypad.h and I expect that patches to actually enable keypad will go through appropriate platform tree(s).
Quoted 8 lines
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
OK, the rest will go through samsung platform tree
Ok..will apply.
Kukjin, could you remove keypad.h on the commit "ARM: SAMSUNG: Add keypad device support" of the samsung platform tree. The keypad.h file was included on input tree.
Quoted 9 lines
(http://git.kernel.org/?p=linux/kernel/git/dtor/input.git;a=commit;h=0fffed27f92d9d7
Quoted 4 lines
Quoted 1 line
a34de9fe017b7082b5958bb93)
You mean in plat-samsung/dev-keypad.c?
If remove inclusion plat/keypad.h in there, following build error happens.
No. I mean to remove arch/arm/plat-samsung/include/plat/keypad.h file on samsung platform tree, it was applied on input tree already. If needs, i can repost.
If it is not small change like to remove a file in a patch, I think should be re-submitted. Will drop your previous patch in my tree.
Quoted 19 lines
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c:41: warning: 'struct
samsung_keypad_platdata' declared inside parameter list
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c:41: warning: its scope is only this definition
or declaration, which is probably not what you want
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c: In function
'samsung_keypad_set_platdata':
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c:50: error: invalid application of 'sizeof' to
incomplete type 'struct samsung_keypad_platdata'
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c:54: error: dereferencing pointer to
incomplete type
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c:55: error: dereferencing pointer to
incomplete type
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c:55: error: 'samsung_keypad_cfg_gpio'
undeclared (first use in this function)
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c:55: error: (Each undeclared identifier is
reported only once
Quoted 3 lines
arch/arm/plat-samsung/dev-keypad.c:55: error: for each function it appears in.) make[1]: *** [arch/arm/plat-samsung/dev-keypad.o] Error 1

Quoted 8 lines

Quoted 4 lines
Quoted 1 line
As you know, released 35 today. So we have no much time for this merge
window.
I'm not sure about merge rule, but I think the compile problem can be solved by merge to 36 of input tree and samsung platform tree.
Hmm...actually, already informed about that on linux-next.
If it's just build problem, I or Dmitry can fix it. However, this is not just that. I cannot understand how your 'plat/keypad.h' was included to both of patch.

Please see the prior mail history. The keypad.h file is included only at the 1/3 patch in the original patch set, but Dmitry applied the 3/3 patch modified with keypad.h.

The basic problem is that each patches be applied on two tree. It makes compile errors at the one tree lacking keypad.h file because both tree share keypad.h file.

There are two solutions, First, all patches go to one tree. Second, we wait for merging to 36 of both tree then apply platform patches.

Quoted 2 lines

And I'm not sure, should be 'plat/keypad.h' in which tree...

Kukjin Kim

2010-08-02 06:30 UTC #18 lore raw

PATCH v6 3/3 input: samsung-keypad - Add samsung keypad driver

Quoted 70 lines · Joonyoung Shim

Quoted 14 lines · Kukjin Kim
Quoted 13 lines · Joonyoung Shim
Quoted 12 lines · Kukjin Kim
Quoted 11 lines · Joonyoung Shim
Hi, I came back from vacation.
Quoted 9 lines
Quoted 9 lines
Quoted 7 lines
Quoted 2 lines
Do you have any feedback? If ok, i want to go to input tree or samsung tree these added sched.h including.
I applied the patch adding samsung-keypad.c and the platform data arch/arm/plat-samsung/include/plat/keypad.h and I expect that patches to actually enable keypad will go through appropriate platform tree(s).
OK, the rest will go through samsung platform tree
Quoted 7 lines
Quoted 7 lines
Quoted 6 lines
Quoted 6 lines
Quoted 2 lines
Ok..will apply.
Kukjin, could you remove keypad.h on the commit "ARM: SAMSUNG: Add keypad device support" of the samsung platform tree. The keypad.h file was included on input tree.
(http://git.kernel.org/?p=linux/kernel/git/dtor/input.git;a=commit;h=0fffed27f92d9d7
Quoted 9 lines
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
a34de9fe017b7082b5958bb93)
You mean in plat-samsung/dev-keypad.c?
If remove inclusion plat/keypad.h in there, following build error happens.
No. I mean to remove arch/arm/plat-samsung/include/plat/keypad.h file on samsung platform tree, it was applied on input tree already. If needs, i can repost.
If it is not small change like to remove a file in a patch, I think should be re-
submitted.
Quoted 5 lines
Will drop your previous patch in my tree.
Quoted 3 lines
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c:41: warning: 'struct
samsung_keypad_platdata' declared inside parameter list
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c:41: warning: its scope is only this
definition
Quoted 4 lines
Quoted 4 lines
or declaration, which is probably not what you want
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c: In function
'samsung_keypad_set_platdata':
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c:50: error: invalid application of 'sizeof'
to
Quoted 12 lines
Quoted 12 lines
incomplete type 'struct samsung_keypad_platdata'
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c:54: error: dereferencing pointer to
incomplete type
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c:55: error: dereferencing pointer to
incomplete type
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c:55: error: 'samsung_keypad_cfg_gpio'
undeclared (first use in this function)
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c:55: error: (Each undeclared identifier is
reported only once
Quoted 3 lines
arch/arm/plat-samsung/dev-keypad.c:55: error: for each function it appears in.) make[1]: *** [arch/arm/plat-samsung/dev-keypad.o] Error 1
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
As you know, released 35 today. So we have no much time for this merge
window.
I'm not sure about merge rule, but I think the compile problem can be solved by merge to 36 of input tree and samsung platform tree.
Hmm...actually, already informed about that on linux-next.
If it's just build problem, I or Dmitry can fix it. However, this is not just that. I cannot understand how your 'plat/keypad.h' was included to both of patch.
Please see the prior mail history. The keypad.h file is included only at the 1/3 patch in the original patch set, but Dmitry applied the 3/3 patch modified with keypad.h.

Quoted 9 lines

The basic problem is that each patches be applied on two tree. It makes compile errors at the one tree lacking keypad.h file because both tree share keypad.h file.
There are two solutions, First, all patches go to one tree. Second, we wait for merging to 36 of both tree then apply platform patches.
Quoted 2 lines
And I'm not sure, should be 'plat/keypad.h' in which tree...

Hi Dmitry,

How can/should I do for it?...Which way is better to us? :-)

Joonyoung,
Let's wait for Dmitry's reply.
I will holding drop your previous patch in my tree till that time.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

Dmitry Torokhov

maintainer

2010-08-02 07:58 UTC #19 lore raw

PATCH v6 3/3 input: samsung-keypad - Add samsung keypad driver

Quoted 81 lines · Kukjin Kim

Quoted 70 lines · Joonyoung Shim
Quoted 14 lines · Kukjin Kim
Quoted 13 lines · Joonyoung Shim
Quoted 12 lines · Kukjin Kim
Quoted 11 lines · Joonyoung Shim
Hi, I came back from vacation.
Quoted 9 lines
Quoted 9 lines
Quoted 7 lines
Quoted 2 lines
Do you have any feedback? If ok, i want to go to input tree or samsung tree these added sched.h including.
I applied the patch adding samsung-keypad.c and the platform data arch/arm/plat-samsung/include/plat/keypad.h and I expect that patches to actually enable keypad will go through appropriate platform tree(s).
OK, the rest will go through samsung platform tree
Quoted 7 lines
Quoted 7 lines
Quoted 6 lines
Quoted 6 lines
Quoted 2 lines
Ok..will apply.
Kukjin, could you remove keypad.h on the commit "ARM: SAMSUNG: Add keypad device support" of the samsung platform tree. The keypad.h file was included on input tree.
(http://git.kernel.org/?p=linux/kernel/git/dtor/input.git;a=commit;h=0fffed27f92d9d7
Quoted 9 lines
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
a34de9fe017b7082b5958bb93)
You mean in plat-samsung/dev-keypad.c?
If remove inclusion plat/keypad.h in there, following build error happens.
No. I mean to remove arch/arm/plat-samsung/include/plat/keypad.h file on samsung platform tree, it was applied on input tree already. If needs, i can repost.
If it is not small change like to remove a file in a patch, I think should be re-
submitted.
Quoted 5 lines
Will drop your previous patch in my tree.
Quoted 3 lines
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c:41: warning: 'struct
samsung_keypad_platdata' declared inside parameter list
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c:41: warning: its scope is only this
definition
Quoted 4 lines
Quoted 4 lines
or declaration, which is probably not what you want
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c: In function
'samsung_keypad_set_platdata':
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c:50: error: invalid application of 'sizeof'
to
Quoted 12 lines
Quoted 12 lines
incomplete type 'struct samsung_keypad_platdata'
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c:54: error: dereferencing pointer to
incomplete type
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c:55: error: dereferencing pointer to
incomplete type
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c:55: error: 'samsung_keypad_cfg_gpio'
undeclared (first use in this function)
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c:55: error: (Each undeclared identifier is
reported only once
Quoted 3 lines
arch/arm/plat-samsung/dev-keypad.c:55: error: for each function it appears in.) make[1]: *** [arch/arm/plat-samsung/dev-keypad.o] Error 1
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
As you know, released 35 today. So we have no much time for this merge
window.
I'm not sure about merge rule, but I think the compile problem can be solved by merge to 36 of input tree and samsung platform tree.
Hmm...actually, already informed about that on linux-next.
If it's just build problem, I or Dmitry can fix it. However, this is not just that. I cannot understand how your 'plat/keypad.h' was included to both of patch.
Please see the prior mail history. The keypad.h file is included only at the 1/3 patch in the original patch set, but Dmitry applied the 3/3 patch modified with keypad.h.
Quoted 9 lines
The basic problem is that each patches be applied on two tree. It makes compile errors at the one tree lacking keypad.h file because both tree share keypad.h file.
There are two solutions, First, all patches go to one tree. Second, we wait for merging to 36 of both tree then apply platform patches.
Quoted 2 lines
And I'm not sure, should be 'plat/keypad.h' in which tree...

Quoted 9 lines

Hi Dmitry,
How can/should I do for it?...Which way is better to us? :-)
Joonyoung,
Let's wait for Dmitry's reply.
I will holding drop your previous patch in my tree till that time.

Kgene,

I will be sending pull request to Linus in the next day or so, so it will have plat/keypad.h as it is in my tree. Once you merge (with his or mine) you have an option to patching the plat/keypad.h with hooks that I removed, although I would prefer if you changed the way you initialize your devices since having the these hooks defeats the purpose of having config pointer in platform data. Another option would be to have a separate include file for the hooks, one that drivers/input/keyboard/samsung-keypad.c does not use.

Thanks.

Signature · 1 line

Dmitry

Kukjin Kim

2010-08-03 02:10 UTC #20 lore raw

PATCH v6 3/3 input: samsung-keypad - Add samsung keypad driver

Quoted 11 lines · Dmitry Torokhov

Quoted 9 lines · Kukjin Kim
Quoted 8 lines · Joonyoung Shim
Quoted 6 lines · Kukjin Kim
Quoted 5 lines · Joonyoung Shim
Quoted 4 lines · Kukjin Kim
Quoted 3 lines · Joonyoung Shim
Hi, I came back from vacation.
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Do you have any feedback? If ok, i want to go to input tree

Quoted 3 lines

samsung
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 1 line
tree these added sched.h including.
I applied the patch adding samsung-keypad.c and the platform

data

Quoted 11 lines

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
arch/arm/plat-samsung/include/plat/keypad.h and I expect that patches to actually enable keypad will go through appropriate platform tree(s).
OK, the rest will go through samsung platform tree
Ok..will apply.
Kukjin, could you remove keypad.h on the commit "ARM: SAMSUNG:
Add
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
keypad device support" of the samsung platform tree. The keypad.h

file

Quoted 5 lines

Quoted 4 lines
Quoted 4 lines
Quoted 3 lines
Quoted 3 lines
Quoted 2 lines
Quoted 2 lines
was included on input tree.

(http://git.kernel.org/?p=linux/kernel/git/dtor/input.git;a=commit;h=0fffed2
7f92d9d7

Quoted 3 lines

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 1 line
a34de9fe017b7082b5958bb93)
You mean in plat-samsung/dev-keypad.c?
If remove inclusion plat/keypad.h in there, following build error

happens.

Quoted 2 lines

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 1 line
No. I mean to remove arch/arm/plat-samsung/include/plat/keypad.h

file on

Quoted 1 line

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
samsung platform tree, it was applied on input tree already. If

needs, i

Quoted 3 lines

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 2 lines
can repost.
If it is not small change like to remove a file in a patch, I think

should be re-

Quoted 6 lines

Quoted 6 lines
Quoted 6 lines
submitted.
Quoted 5 lines
Will drop your previous patch in my tree.
Quoted 3 lines
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c:41: warning: 'struct
samsung_keypad_platdata' declared inside parameter list
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c:41: warning: its scope is only

this

Quoted 5 lines

Quoted 5 lines
Quoted 5 lines
definition
Quoted 4 lines
Quoted 4 lines
or declaration, which is probably not what you want
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c: In function
'samsung_keypad_set_platdata':
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c:50: error: invalid application

Quoted 4 lines

'sizeof'
Quoted 3 lines
Quoted 3 lines
to
Quoted 2 lines
Quoted 2 lines
incomplete type 'struct samsung_keypad_platdata'
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c:54: error: dereferencing

pointer to

Quoted 2 lines

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
incomplete type
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c:55: error: dereferencing

pointer to

Quoted 5 lines

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
incomplete type
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c:55: error:
'samsung_keypad_cfg_gpio'
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
undeclared (first use in this function)
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c:55: error: (Each undeclared

identifier

Quoted 7 lines

is
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
reported only once
Quoted 1 line
arch/arm/plat-samsung/dev-keypad.c:55: error: for each function it
appears in.)
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
make[1]: *** [arch/arm/plat-samsung/dev-keypad.o] Error 1
As you know, released 35 today. So we have no much time for this

merge

Quoted 2 lines

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
window.
I'm not sure about merge rule, but I think the compile problem can

Quoted 4 lines

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 1 line
solved by merge to 36 of input tree and samsung platform tree.
Hmm...actually, already informed about that on linux-next. If it's just build problem, I or Dmitry can fix it. However, this is

not just that.

Quoted 1 line

Quoted 1 line
Quoted 1 line
Quoted 1 line
I cannot understand how your 'plat/keypad.h' was included to both of

patch.

Quoted 2 lines

Quoted 2 lines
Quoted 2 lines
Please see the prior mail history. The keypad.h file is included only

Quoted 4 lines

Quoted 4 lines
Quoted 4 lines
the 1/3 patch in the original patch set, but Dmitry applied the 3/3 patch modified with keypad.h.
The basic problem is that each patches be applied on two tree. It

makes

Quoted 30 lines

Quoted 9 lines
Quoted 8 lines
compile errors at the one tree lacking keypad.h file because both tree share keypad.h file.
There are two solutions, First, all patches go to one tree. Second, we wait for merging to 36 of both tree then apply platform patches.
Quoted 2 lines
And I'm not sure, should be 'plat/keypad.h' in which tree...
Quoted 9 lines
Hi Dmitry,
How can/should I do for it?...Which way is better to us? :-)
Joonyoung,
Let's wait for Dmitry's reply.
I will holding drop your previous patch in my tree till that time.
Kgene,
I will be sending pull request to Linus in the next day or so, so it will have plat/keypad.h as it is in my tree. Once you merge (with his or mine) you have an option to patching the plat/keypad.h with hooks that I removed, although I would prefer if you changed the way you initialize your devices since having the these hooks defeats the purpose of having config pointer in platform data. Another option would be to have a separate include file for the hooks, one that drivers/input/keyboard/samsung-keypad.c does not use.

Quoted 2 lines

Thanks.

Hi Dmitry,

Hmm...I saw your pull request to Linus...ok...will replace new one which don't have duplicate 'plat/keypad.h' in my tree.
But..in this case, I'm not sure which way is better to us...

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.