Skip to contentSkip to conversation

Latest "git" version fails to compile on Linux host

Qemu-devel Applied Nigel Horne 3 participants 4 messages Jul 6, 2010

lore
Share & tools
lore

Nigel Horne

author
#0 lore raw

./configure --enable-linux-aio --enable-io-thread --enable-kvm
make
...
/home/njh/src/qemu/cpus.c:532: error: ‘exit_request’ undeclared (first use in this function) /home/njh/src/qemu/cpus.c:532: error: (Each undeclared identifier is reported only once /home/njh/src/qemu/cpus.c:532: error: for each function it appears in.)

Perhaps cpus.c needs to have:

extern volatile sig_atomic_t exit_request;

-Nigel

#1 lore raw

PATCH 1/1 Fix io-thread build breakage of a88790a14f

Quoted 9 lines · Nigel Horne

./configure --enable-linux-aio --enable-io-thread --enable-kvm make
...
/home/njh/src/qemu/cpus.c:532: error: ‘exit_request’ undeclared (first use in this function)
/home/njh/src/qemu/cpus.c:532: error: (Each undeclared identifier is reported only once
/home/njh/src/qemu/cpus.c:532: error: for each function it appears in.)

Quoted 3 lines

Perhaps cpus.c needs to have:

extern volatile sig_atomic_t exit_request;

Better include the header:

---------->

Signed-off-by Jan Kiszka <[email protected]>
---
 cpus.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
cpus.c +1 -0
index fcd0f09..eef0bb8 100644
@@ -30,6 +30,7 @@
 #include "gdbstub.h"
 #include "dma.h"
 #include "kvm.h"
+#include "exec-all.h"
 
 #include "cpus.h"
Signature · 1 line
1.7.1
Applied
#2 lore raw

Re: [Qemu-devel] [PATCH] Fix io-thread build breakage of a88790a14f

Quoted 13 lines · Jan Kiszka
Quoted 11 lines · Nigel Horne

./configure --enable-linux-aio --enable-io-thread --enable-kvm make
...
/home/njh/src/qemu/cpus.c:532: error: ‘exit_request’ undeclared (first use in this function)
/home/njh/src/qemu/cpus.c:532: error: (Each undeclared identifier is reported only once
/home/njh/src/qemu/cpus.c:532: error: for each function it appears in.)

Perhaps cpus.c needs to have:

Quoted 8 lines
Quoted 2 lines

extern volatile sig_atomic_t exit_request;

Better include the header:

---------->

Signed-off-by Jan Kiszka<[email protected]>

Applied. Thanks.

In the future, please try to avoid quoting in like this. I often forget to remove it from the commit message before pushing (although I did in this case).

Regards,

Anthony Liguori

Quoted 17 lines
---
  cpus.c |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)
cpus.c +1 -0
index fcd0f09..eef0bb8 100644
@@ -30,6 +30,7 @@
  #include "gdbstub.h"
  #include "dma.h"
  #include "kvm.h"
+#include "exec-all.h"
 
  #include "cpus.h"
#3 lore raw

Re: [Qemu-devel] [PATCH] Fix io-thread build breakage of a88790a14f

Quoted 20 lines · Anthony Liguori
Quoted 19 lines · Jan Kiszka
Quoted 9 lines · Nigel Horne

./configure --enable-linux-aio --enable-io-thread --enable-kvm make
...
/home/njh/src/qemu/cpus.c:532: error: ‘exit_request’ undeclared (first use in this function)
/home/njh/src/qemu/cpus.c:532: error: (Each undeclared identifier is reported only once
/home/njh/src/qemu/cpus.c:532: error: for each function it appears in.)

Quoted 4 lines

Perhaps cpus.c needs to have:

extern volatile sig_atomic_t exit_request;

Better include the header:

---------->

Quoted 8 lines
Quoted 2 lines
Signed-off-by Jan Kiszka<[email protected]>

Applied. Thanks.

In the future, please try to avoid quoting in like this. I often forget to remove it from the commit message before pushing (although I did in this case).

OK.

Note that there is also 'git am -c' - but I used a non-standard scissors line here...

Jan

Signature · 2 lines
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux