Skip to contentSkip to conversation

ipmi:ipmi_si_intf.c Fix warning: variable 'addr_space' set but not used

PATCH In review Justin P. Mattock 2 participants 3 messages Jul 8, 2010 IPMI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ipmi:ipmi_si_intf.c Fix warning: variable 'addr_space' set but not used

The below patch fixes a warning message generated by GCC, and also
updates a web address pointing to a pdf containging information.
CC [M] drivers/char/ipmi/ipmi_si_intf.o
drivers/char/ipmi/ipmi_si_intf.c: In function 'try_init_spmi':
drivers/char/ipmi/ipmi_si_intf.c:2016:8: warning: variable 'addr_space' set but not used

---
 drivers/char/ipmi/ipmi_si_intf.c |   10 ++--------
 1 files changed, 2 insertions(+), 8 deletions(-)
drivers/char/ipmi/ipmi_si_intf.c +2 -8
index 094bdc3..7e40d02 100644
@@ -1965,8 +1965,8 @@ static int acpi_gpe_irq_setup(struct smi_info *info)
 
 /*
  * Defined at
- * http://h21007.www2.hp.com/dspp/files/unprotected/devresource/
- * Docs/TechPapers/IA64/hpspmi.pdf
+ * http://h21007.www2.hp.com/portal/download/files 
+ * /unprot/hpspmi.pdf
  */
 struct SPMITable {
 	s8	Signature[4];
@@ -2013,18 +2013,12 @@ struct SPMITable {
 static __devinit int try_init_spmi(struct SPMITable *spmi)
 {
 	struct smi_info  *info;
-	u8 		 addr_space;
 
 	if (spmi->IPMIlegacy != 1) {
 		printk(KERN_INFO PFX "Bad SPMI legacy %d\n", spmi->IPMIlegacy);
 		return -ENODEV;
 	}
 
-	if (spmi->addr.space_id == ACPI_ADR_SPACE_SYSTEM_MEMORY)
-		addr_space = IPMI_MEM_ADDR_SPACE;
-	else
-		addr_space = IPMI_IO_ADDR_SPACE;
-
 	info = kzalloc(sizeof(*info), GFP_KERNEL);
 	if (!info) {
 		printk(KERN_ERR PFX "Could not allocate SI data (3)\n");
Signature · 1 line
1.7.1.rc1.21.gf3bd6
Acked-by on v1 1/1
#1 lore raw

Looks good to me:

Quoted 48 lines · Justin P. Mattock

The below patch fixes a warning message generated by GCC, and also
updates a web address pointing to a pdf containging information.
CC [M] drivers/char/ipmi/ipmi_si_intf.o
drivers/char/ipmi/ipmi_si_intf.c: In function 'try_init_spmi':
drivers/char/ipmi/ipmi_si_intf.c:2016:8: warning: variable 'addr_space' set but not used

---
  drivers/char/ipmi/ipmi_si_intf.c |   10 ++--------
  1 files changed, 2 insertions(+), 8 deletions(-)
drivers/char/ipmi/ipmi_si_intf.c +2 -8
index 094bdc3..7e40d02 100644
@@ -1965,8 +1965,8 @@ static int acpi_gpe_irq_setup(struct smi_info *info)
 
  /*
   * Defined at
- * http://h21007.www2.hp.com/dspp/files/unprotected/devresource/
- * Docs/TechPapers/IA64/hpspmi.pdf
+ * http://h21007.www2.hp.com/portal/download/files
+ * /unprot/hpspmi.pdf
   */
  struct SPMITable {
  	s8	Signature[4];
@@ -2013,18 +2013,12 @@ struct SPMITable {
  static __devinit int try_init_spmi(struct SPMITable *spmi)
  {
  	struct smi_info  *info;
-	u8 		 addr_space;
 
  	if (spmi->IPMIlegacy != 1) {
  		printk(KERN_INFO PFX "Bad SPMI legacy %d\n", spmi->IPMIlegacy);
  		return -ENODEV;
  	}
 
-	if (spmi->addr.space_id == ACPI_ADR_SPACE_SYSTEM_MEMORY)
-		addr_space = IPMI_MEM_ADDR_SPACE;
-	else
-		addr_space = IPMI_IO_ADDR_SPACE;
-
  	info = kzalloc(sizeof(*info), GFP_KERNEL);
  	if (!info) {
  		printk(KERN_ERR PFX "Could not allocate SI data (3)\n");