Fix building of tusb6010

PATCH In review Kirill A. Shutemov 2 participants 3 messages Jul 12, 2010 – Jul 13, 2010

Subsystems (2)

USB MUSB multipoint high speed dual-role controller

lore

Share & tools

lore

Kirill A. Shutemov

author

2010-07-12 22:42 UTC #0 lore raw

PATCH 1/1 Fix building of tusb6010

CC drivers/usb/musb/tusb6010.o
drivers/usb/musb/tusb6010.c:34: error: expected identifier or '(' before 'do' drivers/usb/musb/tusb6010.c:34: error: expected identifier or '(' before 'while' drivers/usb/musb/tusb6010.c:39: error: expected identifier or '(' before 'do' drivers/usb/musb/tusb6010.c:39: error: expected identifier or '(' before 'while' make[2]: *** [drivers/usb/musb/tusb6010.o] Error 1
make[1]: *** [drivers/usb/musb] Error 2
make: *** [drivers] Error 2

Empty musb_platform_save_context and musb_platform_restore_context provided by musb_core.h.

Signed-off-by Kirill A. Shutemov <[email protected]>

---
 drivers/usb/musb/tusb6010.c |   13 -------------
 1 files changed, 0 insertions(+), 13 deletions(-)

drivers/usb/musb/tusb6010.c +0 ~~-13~~

index 05c077f..3c48e77 100644
@@ -29,19 +29,6 @@ static void tusb_source_power(struct musb *musb, int is_on);
 #define TUSB_REV_MAJOR(reg_val)		((reg_val >> 4) & 0xf)
 #define TUSB_REV_MINOR(reg_val)		(reg_val & 0xf)
 
-#ifdef CONFIG_PM
-/* REVISIT: These should be only needed if somebody implements off idle */
-void musb_platform_save_context(struct musb *musb,
-			struct musb_context_registers *musb_context)
-{
-}
-
-void musb_platform_restore_context(struct musb *musb,
-			struct musb_context_registers *musb_context)
-{
-}
-#endif
-
 /*
  * Checks the revision. We need to use the DMA register as 3.0 does not
  * have correct versions for TUSB_PRCM_REV or TUSB_INT_CTRL_REV.

Signature · 1 line

1.7.1.1

Sergei Shtylyov

2010-07-13 09:12 UTC #1 lore raw

Hello.

Quoted 9 lines · Kirill A. Shutemov

CC drivers/usb/musb/tusb6010.o
drivers/usb/musb/tusb6010.c:34: error: expected identifier or '(' before 'do' drivers/usb/musb/tusb6010.c:34: error: expected identifier or '(' before 'while' drivers/usb/musb/tusb6010.c:39: error: expected identifier or '(' before 'do' drivers/usb/musb/tusb6010.c:39: error: expected identifier or '(' before 'while' make[2]: *** [drivers/usb/musb/tusb6010.o] Error 1
make[1]: *** [drivers/usb/musb] Error 2
make: *** [drivers] Error 2

Quoted 4 lines

Empty musb_platform_save_context and musb_platform_restore_context provided by musb_core.h.
Signed-off-by Kirill A. Shutemov <[email protected]>

Such patch has already been submitted by Felipe Balbi:

http://marc.info/?l=linux-usb&m=127832134917692

WBR, Sergei

Kirill A. Shutemov

author

2010-07-13 09:27 UTC #2 lore raw

Quoted 13 lines · Sergei Shtylyov

Hello.
Quoted 8 lines · Kirill A. Shutemov
CC drivers/usb/musb/tusb6010.o
drivers/usb/musb/tusb6010.c:34: error: expected identifier or '(' before 'do' drivers/usb/musb/tusb6010.c:34: error: expected identifier or '(' before 'while' drivers/usb/musb/tusb6010.c:39: error: expected identifier or '(' before 'do' drivers/usb/musb/tusb6010.c:39: error: expected identifier or '(' before 'while' make[2]: *** [drivers/usb/musb/tusb6010.o] Error 1
make[1]: *** [drivers/usb/musb] Error 2
make: *** [drivers] Error 2

Quoted 8 lines

Quoted 4 lines
Empty musb_platform_save_context and musb_platform_restore_context provided by musb_core.h.
Signed-off-by Kirill A. Shutemov <[email protected]>
Such patch has already been submitted by Felipe Balbi:
http://marc.info/?l=linux-usb&m=127832134917692

Oh, Ok. Sorry.

Signature · 1 line

 Kirill A. Shutemov