davinci: Add MityDSP-L138/MityARM-1808 SOM support
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH v2 1/1 davinci: Add MityDSP-L138/MityARM-1808 SOM support
Hi,
Nice to see a new board based on the OMAP-L138.
A small comment below.
On 19.07.2010 15:21, Michael Williamson wrote:
[...]
Review
Quoted 6 lines
(quoted diff) +6
-0+static struct davinci_i2c_platform_data mityomap_i2c_0_pdata = { + .bus_freq = 100, /* kHz */ + .bus_delay = 0, /* usec */ +}; + +/* TPS65070 voltage regulator support */
The comment doesn't match what your supporting.
Quoted 14 lines
(quoted diff) +14
-0+ +/* 1.2V Core */ +struct regulator_consumer_supply tps65023_dcdc1_consumers[] = { + { + .supply = "cvdd", + }, +}; + +/* 1.8V */ +struct regulator_consumer_supply tps65023_dcdc2_consumers[] = { + { + .supply = "usb0_vdda18", + }, + {
Review
Quoted 10 lines
(quoted diff) +10
-0+ .supply = "usb1_vdda18", + }, + { + .supply = "ddr_dvdd18", + }, + { + .supply = "sata_vddr", + }, +}; +
[...]
Regards,
Signature · 12 lines
Christophe Aeschlimann Embedded Software Engineer Advanced Communications Networks S.A. Rue du Puits-Godet 8a 2000 Neuch?tel, Switzerland T?l. +41 32 724 74 31 c.aeschlimann at acn-group.ch
PATCH v2 1/1 davinci: Add MityDSP-L138/MityARM-1808 SOM support
In reply to a message not in the archiveHi,
Nice to see a new board based on the OMAP-L138.
A small comment below.
On 19.07.2010 15:21, Michael Williamson wrote:
[...]
Review
Quoted 6 lines
(quoted diff) +6
-0+static struct davinci_i2c_platform_data mityomap_i2c_0_pdata = { + .bus_freq = 100, /* kHz */ + .bus_delay = 0, /* usec */ +}; + +/* TPS65070 voltage regulator support */
The comment doesn't match what _you are_ supporting.
Quoted 14 lines
(quoted diff) +14
-0+ +/* 1.2V Core */ +struct regulator_consumer_supply tps65023_dcdc1_consumers[] = { + { + .supply = "cvdd", + }, +}; + +/* 1.8V */ +struct regulator_consumer_supply tps65023_dcdc2_consumers[] = { + { + .supply = "usb0_vdda18", + }, + {
Review
Quoted 10 lines
(quoted diff) +10
-0+ .supply = "usb1_vdda18", + }, + { + .supply = "ddr_dvdd18", + }, + { + .supply = "sata_vddr", + }, +}; +
[...]
Regards,
Signature · 12 lines
Christophe Aeschlimann Embedded Software Engineer Advanced Communications Networks S.A. Rue du Puits-Godet 8a 2000 Neuch?tel, Switzerland T?l. +41 32 724 74 31 c.aeschlimann at acn-group.ch
PATCH v2 1/1 davinci: Add MityDSP-L138/MityARM-1808 SOM support
In reply to a message not in the archiveQuoted 1 line · Michael Williamson
arch/arm/configs/mityomapl138_defconfig | 1764 ++++++++++++++++++++
Please don't include full defconfigs; we've recently reduced the size of those merged because they're getting OTT. Please combine your defconfig with another existing defconfig where possible.
If not, Uwe has a script which can be run to reduce the size of the defconfig. However, I'd personally prefer to see a reduction in the number of defconfigs we have now.
PATCH v2 1/1 davinci: Add MityDSP-L138/MityARM-1808 SOM support
Quoted 10 lines · Russell King - ARM Linux
Quoted 1 line · Michael Williamson
arch/arm/configs/mityomapl138_defconfig | 1764 ++++++++++++++++++++Please don't include full defconfigs; we've recently reduced the size of those merged because they're getting OTT. Please combine your defconfig with another existing defconfig where possible.
If not, Uwe has a script which can be run to reduce the size of the defconfig. However, I'd personally prefer to see a reduction in the number of defconfigs we have now.
OK. I think I can roll this in with the da8xx_omapl_defconfig and scrap the one submitted.
Thanks for the feedback.
-Mike