cpufreq: fix memory leak in cpufreq_add_dev
PATCH 1/1 cpufreq: fix memory leak in cpufreq_add_dev
We didn't free policy->related_cpus in error path err_unlock_policy. This is catched by following kmemleak report:
unreferenced object 0xffff88022a0b96d0 (size 512):
comm "modprobe", pid 886, jiffies 4294689177 (age 780.694s) hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<ffffffff8111ebe5>] create_object+0x186/0x281
[<ffffffff814fad4f>] kmemleak_alloc+0x60/0xa7
[<ffffffff8111127a>] kmem_cache_alloc_node_notrace+0x120/0x142
[<ffffffff81262e4f>] alloc_cpumask_var_node+0x2c/0xd7
[<ffffffff81262f0b>] alloc_cpumask_var+0x11/0x13
[<ffffffff81262f1c>] zalloc_cpumask_var+0xf/0x11
[<ffffffff8140fac0>] cpufreq_add_dev+0x11f/0x547
[<ffffffff81334bda>] sysdev_driver_register+0xc2/0x11d
[<ffffffff8140e334>] cpufreq_register_driver+0xcb/0x1b8
[<ffffffffa032e040>] 0xffffffffa032e040
[<ffffffff810021ba>] do_one_initcall+0x5e/0x15c
[<ffffffff81087f94>] sys_init_module+0xa6/0x1e6
[<ffffffff81009bc2>] system_call_fastpath+0x16/0x1b
[<ffffffffffffffff>] 0xffffffffffffffffSigned-off-by Xiaotian Feng <[email protected]>
Cc Dave Jones <[email protected]>
Cc Thomas Renninger <[email protected]>
Cc Prarit Bhargava <[email protected]>
--- drivers/cpufreq/cpufreq.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/cpufreq/cpufreq.c +1 -0
@@ -1077,6 +1077,7 @@ err_out_unregister: err_unlock_policy:unlock_policy_rwsem_write (cpu); +free_cpumask_var (policy->related_cpus); err_free_cpumask:free_cpumask_var (policy->cpus); err_free_policy:
Signature · 1 line
1.7.1.1
drivers/cpufreq/cpufreq.c err_out_unregister: · line 1083
Quoted 13 lines · Xiaotian Feng
drivers/cpufreq/cpufreq.c +1
-0@@ -1077,6 +1077,7 @@ err_out_unregister: err_unlock_policy:unlock_policy_rwsem_write (cpu); +free_cpumask_var (policy->related_cpus); err_free_cpumask:free_cpumask_var (policy->cpus); err_free_policy:
Seems right to me ...
P.