Skip to contentSkip to conversation

net, fec: Shorten device name as done for other drivers

PATCH New Stefano Babic 3 participants 3 messages Jul 20, 2010 – Aug 8, 2010 Network drivers

lore
Share & tools
lore

Stefano Babic

author
#0 lore raw

PATCH 1/1 net, fec: Shorten device name as done for other drivers

After discussion on the ML it is suggested to drop unrequired and not useful characters from the device name. This patch changes the name for the fec_mxc driver from "FEC_MXC" to "FEC".

Signed-off-by Stefano Babic <[email protected]>
---
 drivers/net/fec_mxc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/fec_mxc.c +1 -1
index 57f89a3..6b801ce 100644
@@ -743,7 +743,7 @@ static int fec_probe(bd_t *bd)
 	writel(0x05ee0024, &fec->eth->r_cntrl);	/* FIXME 0x05ee0004 */
 	fec_mii_setspeed(fec);
 
-	sprintf(edev->name, "FEC_MXC");
+	sprintf(edev->name, "FEC");
 
 	miiphy_register(edev->name, fec_miiphy_read, fec_miiphy_write);
Signature · 1 line
1.6.3.3
Applied
#1 lore raw

PATCH 1/1 net, fec: Shorten device name as done for other drivers

Hi Stefano,

Quoted 15 lines · Stefano Babic

After discussion on the ML it is suggested to drop unrequired and not useful characters from the device name. This patch changes the name for the fec_mxc driver from "FEC_MXC" to "FEC".

Signed-off-by Stefano Babic<[email protected]>
---
  drivers/net/fec_mxc.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/fec_mxc.c +0 -0
index 57f89a3..6b801ce 100644

drivers/net/fec_mxc.c static int fec_probe(bd_t *bd) · line 749

Quoted 8 lines
drivers/net/fec_mxc.c +1 -1
@@ -743,7 +743,7 @@ static int fec_probe(bd_t *bd)
  	writel(0x05ee0024,&fec->eth->r_cntrl);	/* FIXME 0x05ee0004 */
  	fec_mii_setspeed(fec);
 
-	sprintf(edev->name, "FEC_MXC");
+	sprintf(edev->name, "FEC");
 
  	miiphy_register(edev->name, fec_miiphy_read, fec_miiphy_write);

Applied to net repo.

thanks,
Ben

#2 lore raw

PATCH 1/1 net, fec: Shorten device name as done for other drivers

Dear Ben Warren,

Quoted 12 lines · In message <[email protected]> you wrote:

Hi Stefano,

Quoted 9 lines · Stefano Babic

After discussion on the ML it is suggested to drop unrequired and not useful characters from the device name. This patch changes the name for the fec_mxc driver from "FEC_MXC" to "FEC".

Signed-off-by Stefano Babic<[email protected]>
---
  drivers/net/fec_mxc.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

...

Quoted 1 line

Applied to net repo.

I consider this a bug fix. Could you please send a pull request any time soon? Thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Accident: A condition in which presence of mind is good, but  absence
of body is better.