Skip to contentSkip to conversation

x86, mrst: remove unused mrst_identify_cpu()

PATCH NAK Javier Martinez Canillas 3 participants 5 messages Jul 25, 2010 x86

lore
Share & tools
lore

Javier Martinez Canillas

author
#0 lore raw

PATCH 1/1 x86, mrst: remove unused mrst_identify_cpu()

mrst_identify_cpu() function is not been used anymore (at today linux-next). This patch removes it.

Signed-off-by Javier Martinez Canillas <[email protected]>
---
 arch/x86/include/asm/mrst.h |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
arch/x86/include/asm/mrst.h +0 -4
index 1635074..0d0e702 100644
@@ -26,10 +26,6 @@ enum mrst_cpu_type {
 };
 
 extern enum mrst_cpu_type __mrst_cpu_chip;
-static enum mrst_cpu_type mrst_identify_cpu(void)
-{
-	return __mrst_cpu_chip;
-}
 
 enum mrst_timer_options {
 	MRST_TIMER_DEFAULT,
Signature · 1 line
1.7.0.4
reviewer
#1 lore raw

Jacob, is this obsolete or something that will be needed in future versions?

It seems that either __mrst_cpu_chip should be killed off, or read-only users should be using the inline instead of __mrst_cpu_chip directly.

-hpa

Quoted 22 lines · Javier Martinez Canillas

mrst_identify_cpu() function is not been used anymore (at today linux-next). This patch removes it.

Signed-off-by Javier Martinez Canillas <[email protected]>
---
 arch/x86/include/asm/mrst.h |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
arch/x86/include/asm/mrst.h +0 -4
index 1635074..0d0e702 100644
@@ -26,10 +26,6 @@ enum mrst_cpu_type {
 };
 
 extern enum mrst_cpu_type __mrst_cpu_chip;
-static enum mrst_cpu_type mrst_identify_cpu(void)
-{
-	return __mrst_cpu_chip;
-}
 
 enum mrst_timer_options {
 	MRST_TIMER_DEFAULT,
Signature · 2 lines
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.
#2 lore raw
Quoted 4 lines · On Sat, 24 Jul 2010 22:04:45 -0700 "H. Peter Anvin" <[email protected]> wrote:

Jacob, is this obsolete or something that will be needed in future versions?

It seems that either __mrst_cpu_chip should be killed off, or read-only users should be using the inline instead of __mrst_cpu_chip directly.

And how is the inline going to access the variable if the variable isn't global ...

Alan

reviewer
#3 lore raw
Quoted 5 lines · Alan Cox
Quoted 2 lines · On Sat, 24 Jul 2010 22:04:45 -0700 "H. Peter Anvin" <[email protected]> wrote:

Jacob, is this obsolete or something that will be needed in future versions?

Quoted 7 lines
Quoted 2 lines

It seems that either __mrst_cpu_chip should be killed off, or read-only users should be using the inline instead of __mrst_cpu_chip directly.

And how is the inline going to access the variable if the variable isn't global ...

Alan

Well, of course it needs to be global. The "or" in the above sentence is an xor.

-hpa

Signature · 2 lines
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.
NAK
#4 lore raw
In reply to Javier Martinez Canillas
Quoted 1 line · On Sun, 25 Jul 2010 00:50:38 -0400 Javier Martinez Canillas…

mrst_identify_cpu() function is not been used anymore (at today linux-next). This patch removes it.

NAK

This is stuff being merged.

If you are going to try and remove stuff, -next is not the place to track !