Skip to contentSkip to conversation

i2c: fix command usage help

RFC PATCH New Heiko Schocher 2 participants 4 messages Jul 29, 2010 – Aug 3, 2010

lore
Share & tools
lore

Heiko Schocher

author
#0 lore raw

RFC PATCH 8/19 i2c: fix command usage help

Signed-off-by Heiko Schocher <[email protected]>
---
 common/cmd_i2c.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
common/cmd_i2c.c +5 -0
index a1a84a1..91e60ae 100644
@@ -1297,6 +1297,11 @@ static int do_i2c(cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
 {
 	cmd_tbl_t *c;
 
+	if (argc < 2) {
+		cmd_usage(cmdtp);
+		return 1;
+	}
+
 	/* Strip off leading 'i2c' command argument */
 	argc--;
 	argv++;
Signature · 5 lines
1.6.2.5

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#1 lore raw

RFC PATCH 8/19 i2c: fix command usage help

common/cmd_i2c.c static int do_i2c(cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[]) · line 1304

Quoted 8 lines

{

common/cmd_i2c.c +5 -0
 	cmd_tbl_t *c;
 
+	if (argc < 2) {
+		cmd_usage(cmdtp);
+		return 1;
+	}
+

Wolfgang recently made cmd_usage() return 1 so the above could be simplified to:
if (argc < 2)

	return cmd_usage(cmdtp);

Best,
Peter

author
#2 lore raw

RFC PATCH 8/19 i2c: fix command usage help

Hello Peter,

Quoted 12 lines · Peter Tyser

common/cmd_i2c.c static int do_i2c(cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[]) · line 1304

Quoted 8 lines

{

common/cmd_i2c.c +5 -0
 	cmd_tbl_t *c;
 
+	if (argc < 2) {
+		cmd_usage(cmdtp);
+		return 1;
+	}
+

Wolfgang recently made cmd_usage() return 1 so the above could be simplified to:
if (argc < 2)

Quoted 1 line
	return cmd_usage(cmdtp);

Hups, missed this, sorry. I fix it in the next version. thanks.

bye
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
author
#3 lore raw

RFC PATCH v2 8/19 i2c: fix command usage help

Signed-off-by Heiko Schocher <[email protected]>

---
- changes since v1
added comment from Peter Tyser
- simplified this patch as cmd_usage() returns 1

 common/cmd_i2c.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
common/cmd_i2c.c +3 -0
index a1a84a1..48de54b 100644
@@ -1297,6 +1297,9 @@ static int do_i2c(cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
 {
 	cmd_tbl_t *c;
 
+	if (argc < 2)
+		return cmd_usage(cmdtp);
+
 	/* Strip off leading 'i2c' command argument */
 	argc--;
 	argv++;
Signature · 5 lines
1.6.2.5

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany