Skip to contentSkip to conversation

nf_conntrack_acct: use skb->len for accounting

PATCH Applied Changli Gao 2 participants 2 messages Jul 23, 2010 – Aug 2, 2010

Subsystems (3)
Networking Network drivers netfilter
lore
Share & tools
lore

Changli Gao

author
#0 lore raw

PATCH 1/1 nf_conntrack_acct: use skb->len for accounting

nf_conntrack_acct: use skb->len for accounting

use skb->len for accounting as xt_quota does. Since nf_conntrack works at the network layer, skb_network_offset should always returns ZERO.

Signed-off-by Changli Gao <[email protected]>

----

 net/netfilter/nf_conntrack_core.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
net/netfilter/nf_conntrack_core.c +1 -2
index 16b41b4..df3eedb 100644
@@ -966,8 +966,7 @@ acct:
 		if (acct) {
 			spin_lock_bh(&ct->lock);
 			acct[CTINFO2DIR(ctinfo)].packets++;
-			acct[CTINFO2DIR(ctinfo)].bytes +=
-				skb->len - skb_network_offset(skb);
+			acct[CTINFO2DIR(ctinfo)].bytes += skb->len;
 			spin_unlock_bh(&ct->lock);
 		}
 	}
Applied
#1 lore raw
Quoted 2 lines · Changli Gao

use skb->len for accounting as xt_quota does. Since nf_conntrack works at the network layer, skb_network_offset should always returns ZERO.

Applied.