Skip to contentSkip to conversation

update the MIPS u-boot.lds

PATCH Superseded Xiangfu Liu 2 participants 4 messages Aug 2, 2010 – Aug 4, 2010

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#1 lore raw

PATCH 1/1 update the MIPS u-boot.lds

Thanks for following-up,

Quoted 3 lines · Xiangfu Liu

From: Xiangfu Liu <[email protected]>

Hi Wolfgang

No greetings in the longlog, please. Such comments, supplements are to go below the three-dashes (---):

Quoted 6 lines
Quoted 1 line

From the document, if set all arguments in "OUTPUT_FORMAT"

to "tradbigmips", then even add "-EL" to gcc we still get EB format.

Signed-off-by Xiangfu Liu <[email protected]>

---

(Here...)

Quoted 8 lines
 board/dbau1x00/u-boot.lds    |    2 +-
 board/gth2/u-boot.lds        |    2 +-
 board/incaip/u-boot.lds      |    2 +-
 board/pb1x00/u-boot.lds      |    2 +-
 board/purple/u-boot.lds      |    2 +-
 board/qemu-mips/u-boot.lds   |    2 +-
 examples/standalone/mips.lds |    2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)

[snip]

board/pb1x00/u-boot.lds line 30

Quoted 13 lines
board/pb1x00/u-boot.lds +1 -1
index 9a6cd1b..3c4fbe3 100644
@@ -24,7 +24,7 @@
 /*
 OUTPUT_FORMAT("elf32-bigmips", "elf32-bigmips", "elf32-bigmips")
 */
-OUTPUT_FORMAT("elf32-tradbigmips", "elf32-tradbigmips", "elf32-tradbigmips")
+OUTPUT_FORMAT("elf32-tradbigmips", "elf32-tradbigmips", "elf32-tradlittlemips")
 OUTPUT_ARCH(mips)
 ENTRY(_start)
 SECTIONS

According to MAKEALL script, pb1000_config is only used in Little- endian, so its default endian should be set to LE as well. I too missed this point in my previous patch.

With fixing above nits, feel free to add:

Acked-by Shinya Kuribayashi <[email protected]>

Wolfgang: Could you take care of this patch (hopefully revised one) directly into your master. The fix is obvious.

author
#2 lore raw

PATCH 1/1 update the MIPS u-boot.lds

Hi Shinya

Quoted 4 lines · Shinya Kuribayashi

Aconfccording to MAKEALL script, pb1000_ig is only used in Little- endian, so its default endian should be set to LE as well. I too missed this point in my previous patch.

thanks.

Quoted 4 lines

With fixing above nits, feel free to add:

Acked-by Shinya Kuribayashi<[email protected]>

(by the way. I manually added this line to email.
is the another way to add "Acked-by" like "Signed-off-by" is "-s")

Signature · 3 lines
Best Regards
Xiangfu Liu
http://www.openmobilefree.net
#3 lore raw

PATCH 1/1 update the MIPS u-boot.lds

Quoted 6 lines · Xiangfu Liu
Quoted 3 lines · Shinya Kuribayashi

Aconfccording to MAKEALL script, pb1000_ig is only used in Little- endian, so its default endian should be set to LE as well. I too missed this point in my previous patch.

thanks.

You still forgot to fix this part:

| No greetings in the longlog, please. Such comments, supplements are | to go below the three-dashes (---):

In other words, please remove "Hi Wolfgang" line, and in this case "v1:" and "v2:" at the same time. The resulting longlog would be like this:

<longlog>