Skip to contentSkip to conversation

serial: samsung: fix device name

PATCH New Darius Augulis 5 participants 13 messages Aug 5, 2010 – Sep 1, 2010 TTY layer and serial drivers

lore
Share & tools
lore

Darius Augulis

author
#0 lore raw

PATCH 1/1 serial: samsung: fix device name

Swap device and driver names in serial/samsung.c

Signed-off-by Darius Augulis <[email protected]>
---
 drivers/serial/samsung.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/serial/samsung.c +2 -2
index a9d6c56..9d63f24 100644
@@ -878,10 +878,10 @@ static struct uart_ops s3c24xx_serial_ops = {
 
 static struct uart_driver s3c24xx_uart_drv = {
 	.owner		= THIS_MODULE,
-	.dev_name	= "s3c2410_serial",
+	.driver_name    = "s3c2410_serial",
 	.nr		= CONFIG_SERIAL_SAMSUNG_UARTS,
 	.cons		= S3C24XX_SERIAL_CONSOLE,
-	.driver_name	= S3C24XX_SERIAL_NAME,
+	.dev_name       = S3C24XX_SERIAL_NAME,
 	.major		= S3C24XX_SERIAL_MAJOR,
 	.minor		= S3C24XX_SERIAL_MINOR,
 };
#1 lore raw

PATCH 1/1 serial: samsung: fix device name

Hi,

It's already posted by Mr. Shim
http://marc.info/?l=linux-arm-kernel&m=127410047306149&w=2

As discussed with Ben. even though it's right patch, there's some users to use previous interface.
I also think it will be fixed. but need to coordinate with existing users.

Ben, how to you think?

Quoted 31 lines · Darius Augulis

Swap device and driver names in serial/samsung.c

Signed-off-by Darius Augulis <[email protected]>

---
?drivers/serial/samsung.c | ? ?4 ++--
?1 files changed, 2 insertions(+), 2 deletions(-)

drivers/serial/samsung.c +2 -2
index a9d6c56..9d63f24 100644
@@ -878,10 +878,10 @@ static struct uart_ops s3c24xx_serial_ops = {
 
 ?static struct uart_driver s3c24xx_uart_drv = {
 ? ? ? ?.owner ? ? ? ? ?= THIS_MODULE,
- ? ? ? .dev_name ? ? ? = "s3c2410_serial",
+ ? ? ? .driver_name ? ?= "s3c2410_serial",
 ? ? ? ?.nr ? ? ? ? ? ? = CONFIG_SERIAL_SAMSUNG_UARTS,
 ? ? ? ?.cons ? ? ? ? ? = S3C24XX_SERIAL_CONSOLE,
- ? ? ? .driver_name ? ?= S3C24XX_SERIAL_NAME,
+ ? ? ? .dev_name ? ? ? = S3C24XX_SERIAL_NAME,
 ? ? ? ?.major ? ? ? ? ?= S3C24XX_SERIAL_MAJOR,
 ? ? ? ?.minor ? ? ? ? ?= S3C24XX_SERIAL_MINOR,
 ?};

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

author
#2 lore raw

PATCH 1/1 serial: samsung: fix device name

Quoted 9 lines · Kyungmin Park

Hi,

It's already posted by Mr. Shim
http://marc.info/?l=linux-arm-kernel&m=127410047306149&w=2

As discussed with Ben. even though it's right patch, there's some users to use previous interface.
I also think it will be fixed. but need to coordinate with existing users.

IMHO, it must be fixed. It's very annoying bug and I spend few hours trying to understand why kernel with devtmpfs auto-mount option doesn't provide ttySAC0, because when grep'ing 'grep -R ttySAC0 drivers/serial/* it's found in samsung driver and I thought everything should be o.k. Who could imagine that it's driver name, not device?... Regarding old users, they should not use such strange device name in their configs, they have to sync with main line.

Quoted 39 lines

Ben, how to you think?

Quoted 26 lines · Darius Augulis

Swap device and driver names in serial/samsung.c

Signed-off-by Darius Augulis<[email protected]>
---
  drivers/serial/samsung.c |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
drivers/serial/samsung.c +2 -2
index a9d6c56..9d63f24 100644
@@ -878,10 +878,10 @@ static struct uart_ops s3c24xx_serial_ops = {
 
  static struct uart_driver s3c24xx_uart_drv = {
        .owner          = THIS_MODULE,
-       .dev_name       = "s3c2410_serial",
+       .driver_name    = "s3c2410_serial",
        .nr             = CONFIG_SERIAL_SAMSUNG_UARTS,
        .cons           = S3C24XX_SERIAL_CONSOLE,
-       .driver_name    = S3C24XX_SERIAL_NAME,
+       .dev_name       = S3C24XX_SERIAL_NAME,
        .major          = S3C24XX_SERIAL_MAJOR,
        .minor          = S3C24XX_SERIAL_MINOR,
  };
Quoted 5 lines

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw

PATCH 1/1 serial: samsung: fix device name

Quoted 12 lines · Darius Augulis
Quoted 10 lines · Kyungmin Park

Hi,

It's already posted by Mr. Shim
http://marc.info/?l=linux-arm-kernel&m=127410047306149&w=2

As discussed with Ben. even though it's right patch, there's some users to use previous interface.
I also think it will be fixed. but need to coordinate with existing users.

Quoted 7 lines

IMHO, it must be fixed. It's very annoying bug and I spend few hours trying to understand why kernel with devtmpfs auto-mount option doesn't provide ttySAC0, because when grep'ing 'grep -R ttySAC0 drivers/serial/* it's found in samsung driver and I thought everything should be o.k. Who could imagine that it's driver name, not device?...
Regarding old users, they should not use such strange device name in their configs, they have to sync with main line.

Absolutely agree.

Quoted 44 lines
Quoted 42 lines

Ben, how to you think?

Quoted 27 lines · On Fri, Aug 6, 2010 at 5:10 AM, Darius Augulis<[email protected]> ?wrote:

Swap device and driver names in serial/samsung.c

Signed-off-by Darius Augulis<[email protected]>

---
?drivers/serial/samsung.c | ? ?4 ++--
?1 files changed, 2 insertions(+), 2 deletions(-)

drivers/serial/samsung.c +2 -2
index a9d6c56..9d63f24 100644
@@ -878,10 +878,10 @@ static struct uart_ops s3c24xx_serial_ops = {
 
 ?static struct uart_driver s3c24xx_uart_drv = {
 ? ? ? ?.owner ? ? ? ? ?= THIS_MODULE,
- ? ? ? .dev_name ? ? ? = "s3c2410_serial",
+ ? ? ? .driver_name ? ?= "s3c2410_serial",
 ? ? ? ?.nr ? ? ? ? ? ? = CONFIG_SERIAL_SAMSUNG_UARTS,
 ? ? ? ?.cons ? ? ? ? ? = S3C24XX_SERIAL_CONSOLE,
- ? ? ? .driver_name ? ?= S3C24XX_SERIAL_NAME,
+ ? ? ? .dev_name ? ? ? = S3C24XX_SERIAL_NAME,
 ? ? ? ?.major ? ? ? ? ?= S3C24XX_SERIAL_MAJOR,
 ? ? ? ?.minor ? ? ? ? ?= S3C24XX_SERIAL_MINOR,
 ?};
Quoted 5 lines

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo at vger.kernel.org
More majordomo info at ?http://vger.kernel.org/majordomo-info.html

#4 lore raw

PATCH 1/1 serial: samsung: fix device name

In reply to Kyungmin Park
Quoted 4 lines · Kyungmin Park

Hi,

It's already posted by Mr. Shim
http://marc.info/?l=linux-arm-kernel&m=127410047306149&w=2

Darius patch is a little bit cleaner.

Quoted 3 lines

As discussed with Ben. even though it's right patch, there's some users to use previous interface.
I also think it will be fixed. but need to coordinate with existing users.

IMO this is obvious bug fix.

Acked-by Paulius Zaleckas <[email protected]>
Quoted 39 lines

Ben, how to you think?

Quoted 26 lines · Darius Augulis

Swap device and driver names in serial/samsung.c

Signed-off-by Darius Augulis<[email protected]>
---
  drivers/serial/samsung.c |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
drivers/serial/samsung.c +2 -2
index a9d6c56..9d63f24 100644
@@ -878,10 +878,10 @@ static struct uart_ops s3c24xx_serial_ops = {
 
  static struct uart_driver s3c24xx_uart_drv = {
        .owner          = THIS_MODULE,
-       .dev_name       = "s3c2410_serial",
+       .driver_name    = "s3c2410_serial",
        .nr             = CONFIG_SERIAL_SAMSUNG_UARTS,
        .cons           = S3C24XX_SERIAL_CONSOLE,
-       .driver_name    = S3C24XX_SERIAL_NAME,
+       .dev_name       = S3C24XX_SERIAL_NAME,
        .major          = S3C24XX_SERIAL_MAJOR,
        .minor          = S3C24XX_SERIAL_MINOR,
  };
Quoted 5 lines

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

#5 lore raw

PATCH 1/1 serial: samsung: fix device name

Quoted 8 lines · Paulius Zaleckas
Quoted 4 lines · Kyungmin Park

Hi,

It's already posted by Mr. Shim
http://marc.info/?l=linux-arm-kernel&m=127410047306149&w=2

Darius patch is a little bit cleaner.

OK, it's better.

Acked-by Joonyoung Shim <[email protected]>
Quoted 52 lines
Quoted 4 lines

As discussed with Ben. even though it's right patch, there's some users to use previous interface.
I also think it will be fixed. but need to coordinate with existing users.

IMO this is obvious bug fix.

Acked-by Paulius Zaleckas <[email protected]>
Quoted 41 lines

Ben, how to you think?

Quoted 31 lines · Darius Augulis

Swap device and driver names in serial/samsung.c

Signed-off-by Darius Augulis<[email protected]>
---
  drivers/serial/samsung.c |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
drivers/serial/samsung.c +2 -2
index a9d6c56..9d63f24 100644
@@ -878,10 +878,10 @@ static struct uart_ops s3c24xx_serial_ops = {
 
  static struct uart_driver s3c24xx_uart_drv = {
        .owner          = THIS_MODULE,
-       .dev_name       = "s3c2410_serial",
+       .driver_name    = "s3c2410_serial",
        .nr             = CONFIG_SERIAL_SAMSUNG_UARTS,
        .cons           = S3C24XX_SERIAL_CONSOLE,
-       .driver_name    = S3C24XX_SERIAL_NAME,
+       .dev_name       = S3C24XX_SERIAL_NAME,
        .major          = S3C24XX_SERIAL_MAJOR,
        .minor          = S3C24XX_SERIAL_MINOR,
  };

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Signature · 4 lines
To unsubscribe from this list: send the line "unsubscribe
linux-serial" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#6 lore raw

PATCH 1/1 serial: samsung: fix device name

Quoted 8 lines · Joonyoung Shim
Quoted 6 lines · Paulius Zaleckas
Quoted 4 lines · Kyungmin Park

Hi,

It's already posted by Mr. Shim
http://marc.info/?l=linux-arm-kernel&m=127410047306149&w=2

Quoted 7 lines
Quoted 2 lines

Darius patch is a little bit cleaner.

OK, it's better.

Acked-by Joonyoung Shim <[email protected]>

Hi all,

I think, this should be handled by Ben Dooks.... As Kyungmin Park said, there was his comment about this.

This is just for your information....

===

Quoted 4 lines · Joonyoung Shim
Quoted 3 lines · Ben Dooks
Quoted 1 line · Joonyoung Shim

Thd dev_name and driver_name should be switched each other.

Quoted 8 lines
Quoted 5 lines

Hmm, this doesn't seem to have appeard on the linux-arm-kernel list yet.

Please provide some information about what problem that this is fixing and the impact on any existing systems.

The serial device nodes are created to s3c2410_serial* on android platform instead of ttySAC*.

This has been how they've been for ages, surely the android device node creation sytstem supports symlinking /dev/SACx -> /dev/s3c2410_serialx, like many other operating sysyerms that can already do this.

Changing this just because android (something as-yet unmerged into mainline) does not like it. I'm not even happy with an #ifdef around this.

If you really feel this is a problem that you absolutely must fix in kernel then please provide a kernel commandline option to change the serial driver name and use that on any platform that needs it. Another way would be to update the serial platform data to have a field for which name to choose.

Signature · 6 lines
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.

===
Quoted 26 lines
Quoted 26 lines
Quoted 4 lines

As discussed with Ben. even though it's right patch, there's some users to use previous interface.
I also think it will be fixed. but need to coordinate with existing users.

IMO this is obvious bug fix.

Acked-by Paulius Zaleckas <[email protected]>
Quoted 17 lines

Ben, how to you think?

Quoted 13 lines · Darius Augulis

Swap device and driver names in serial/samsung.c

Signed-off-by Darius Augulis<[email protected]>
---
  drivers/serial/samsung.c |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
drivers/serial/samsung.c +0 -0
index a9d6c56..9d63f24 100644
@@ -878,10 +878,10 @@ static struct uart_ops s3c24xx_serial_ops = {
Quoted 13 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
drivers/serial/samsung.c +1 -1
  static struct uart_driver s3c24xx_uart_drv = {
        .owner          = THIS_MODULE,
-       .dev_name       = "s3c2410_serial",
+       .driver_name    = "s3c2410_serial",
        .nr             = CONFIG_SERIAL_SAMSUNG_UARTS,
Quoted 8 lines
Quoted 8 lines

drivers/serial/samsung.c static struct uart_ops s3c24xx_serial_ops = { · line 887

Quoted 8 lines
drivers/serial/samsung.c +1 -1
        .cons           = S3C24XX_SERIAL_CONSOLE,
-       .driver_name    = S3C24XX_SERIAL_NAME,
+       .dev_name       = S3C24XX_SERIAL_NAME,
        .major          = S3C24XX_SERIAL_MAJOR,
        .minor          = S3C24XX_SERIAL_MINOR,
  };

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

#7 lore raw

PATCH 1/1 serial: samsung: fix device name

Quoted 40 lines · Kukjin Kim
Quoted 8 lines · Joonyoung Shim
Quoted 6 lines · Paulius Zaleckas
Quoted 4 lines · Kyungmin Park

Hi,

It's already posted by Mr. Shim
http://marc.info/?l=linux-arm-kernel&m=127410047306149&w=2

Quoted 7 lines
Quoted 2 lines

Darius patch is a little bit cleaner.

OK, it's better.

Acked-by Joonyoung Shim<[email protected]>

Hi all,

I think, this should be handled by Ben Dooks.... As Kyungmin Park said, there was his comment about this.

This is just for your information....

===

Quoted 4 lines · Joonyoung Shim
Quoted 3 lines · Ben Dooks
Quoted 1 line · Joonyoung Shim

Thd dev_name and driver_name should be switched each other.

Quoted 8 lines
Quoted 5 lines

Hmm, this doesn't seem to have appeard on the linux-arm-kernel list yet.

Please provide some information about what problem that this is fixing and the impact on any existing systems.

The serial device nodes are created to s3c2410_serial* on android platform instead of ttySAC*.

Quoted 6 lines

This has been how they've been for ages, surely the android device node creation sytstem supports symlinking /dev/SACx -> /dev/s3c2410_serialx, like many other operating sysyerms that can already do this.

Changing this just because android (something as-yet unmerged into mainline) does not like it. I'm not even happy with an #ifdef around this.

Not just android. Every linux user/developer is confused here... The first thing when I need to supply some application with serial port I type /dev/tty and press TAB couple times and in this case it FAILS.

That is precisely the case Darius has spend couple days to realize that serial port is under same strange name s3c2410_serialx, even thou his CPU really is s3c6410!

Even when I type in google "samsung console kernel", the first page I hit has information that it is under ttySACx name!

Quoted 4 lines

If you really feel this is a problem that you absolutely must fix in kernel then please provide a kernel commandline option to change the serial driver name and use that on any platform that needs it. Another way would be to update the serial platform data to have a field for which name to choose.

If there is need for old/broken name then userspace can create a symlink for this s3c2410_serial*. Udev can do this, static dev population can do this, init shell script can do this and many many other ways...

Why should we put support for this broken name into kernel? My opinion would be to even send this patch to stable at vger.kernel.org

author
#8 lore raw

PATCH 1/1 serial: samsung: fix device name

In reply to Kukjin Kim
Quoted 14 lines · Kukjin Kim
Quoted 13 lines · Joonyoung Shim
Quoted 8 lines · Paulius Zaleckas
Quoted 4 lines · Kyungmin Park

Hi,

It's already posted by Mr. Shim
http://marc.info/?l=linux-arm-kernel&m=127410047306149&w=2

Darius patch is a little bit cleaner.

OK, it's better.

Quoted 8 lines
Quoted 2 lines
Acked-by Joonyoung Shim<[email protected]>

Hi all,

I think, this should be handled by Ben Dooks.... As Kyungmin Park said, there was his comment about this.

Ben, what's your opinion about that? Are you going to merge that?

Quoted 30 lines

This is just for your information....

===

Quoted 4 lines · Joonyoung Shim
Quoted 3 lines · Ben Dooks
Quoted 1 line · Joonyoung Shim

Thd dev_name and driver_name should be switched each other.

Quoted 8 lines
Quoted 5 lines

Hmm, this doesn't seem to have appeard on the linux-arm-kernel list yet.

Please provide some information about what problem that this is fixing and the impact on any existing systems.

The serial device nodes are created to s3c2410_serial* on android platform instead of ttySAC*.

This has been how they've been for ages, surely the android device node creation sytstem supports symlinking /dev/SACx -> /dev/s3c2410_serialx, like many other operating sysyerms that can already do this.

Changing this just because android (something as-yet unmerged into mainline) does not like it. I'm not even happy with an #ifdef around this.

If you really feel this is a problem that you absolutely must fix in kernel then please provide a kernel commandline option to change the serial driver name and use that on any platform that needs it. Another way would be to update the serial platform data to have a field for which name to choose.

author
#9 lore raw

PATCH 1/1 serial: samsung: fix device name

In reply to Kukjin Kim

Hi Kukjin,

please pick up this one to your tree too.

Thanks,

Darius.

Quoted 52 lines · Kukjin Kim
Quoted 8 lines · Joonyoung Shim
Quoted 6 lines · Paulius Zaleckas
Quoted 4 lines · Kyungmin Park

Hi,

It's already posted by Mr. Shim
http://marc.info/?l=linux-arm-kernel&m=127410047306149&w=2

Quoted 7 lines
Quoted 2 lines

Darius patch is a little bit cleaner.

OK, it's better.

Acked-by Joonyoung Shim<[email protected]>

Hi all,

I think, this should be handled by Ben Dooks.... As Kyungmin Park said, there was his comment about this.

This is just for your information....

===

Quoted 4 lines · Joonyoung Shim
Quoted 3 lines · Ben Dooks
Quoted 1 line · Joonyoung Shim

Thd dev_name and driver_name should be switched each other.

Quoted 8 lines
Quoted 5 lines

Hmm, this doesn't seem to have appeard on the linux-arm-kernel list yet.

Please provide some information about what problem that this is fixing and the impact on any existing systems.

The serial device nodes are created to s3c2410_serial* on android platform instead of ttySAC*.

This has been how they've been for ages, surely the android device node creation sytstem supports symlinking /dev/SACx -> /dev/s3c2410_serialx, like many other operating sysyerms that can already do this.

Changing this just because android (something as-yet unmerged into mainline) does not like it. I'm not even happy with an #ifdef around this.

If you really feel this is a problem that you absolutely must fix in kernel then please provide a kernel commandline option to change the serial driver name and use that on any platform that needs it. Another way would be to update the serial platform data to have a field for which name to choose.

#10 lore raw

PATCH 1/1 serial: samsung: fix device name

Quoted 3 lines · Darius Augulis

Hi Kukjin,

Hi ;-)

Quoted 2 lines

please pick up this one to your tree too.

As I still thinking, this should be handled by Ben Dooks.

And please refer to below Ben's comments about this.

Quoted 37 lines

Thanks,

Darius.

Quoted 32 lines · Kukjin Kim
Quoted 8 lines · Joonyoung Shim
Quoted 6 lines · Paulius Zaleckas
Quoted 4 lines · Kyungmin Park

Hi,

It's already posted by Mr. Shim
http://marc.info/?l=linux-arm-kernel&m=127410047306149&w=2

Quoted 7 lines
Quoted 2 lines

Darius patch is a little bit cleaner.

OK, it's better.

Acked-by Joonyoung Shim<[email protected]>

Hi all,

I think, this should be handled by Ben Dooks.... As Kyungmin Park said, there was his comment about this.

This is just for your information....

===

Quoted 5 lines · Joonyoung Shim
Quoted 4 lines · Ben Dooks
Quoted 1 line · Joonyoung Shim

Thd dev_name and driver_name should be switched each other.

Hmm, this doesn't seem to have appeard on the linux-arm-kernel list

yet.

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 4 lines

Please provide some information about what problem that this is fixing and the impact on any existing systems.

Quoted 8 lines
Quoted 8 lines
Quoted 2 lines

The serial device nodes are created to s3c2410_serial* on android platform instead of ttySAC*.

This has been how they've been for ages, surely the android device node creation sytstem supports symlinking /dev/SACx -> /dev/s3c2410_serialx, like many other operating sysyerms that can already do this.

Changing this just because android (something as-yet unmerged into

mainline)

Quoted 3 lines
Quoted 3 lines

does not like it. I'm not even happy with an #ifdef around this.

If you really feel this is a problem that you absolutely must fix in

kernel

Quoted 1 line
Quoted 1 line

then please provide a kernel commandline option to change the serial

driver

Quoted 2 lines
Quoted 2 lines

name and use that on any platform that needs it. Another way would be to update the serial platform data to have a field for which name to

choose.

Quoted 1 line
Quoted 1 line

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

#11 lore raw

PATCH 1/1 serial: samsung: fix device name

Quoted 4 lines · Kukjin Kim
Quoted 3 lines · Darius Augulis

Hi Kukjin,

Quoted 9 lines

Hi ;-)

Quoted 2 lines

please pick up this one to your tree too.

As I still thinking, this should be handled by Ben Dooks.

And please refer to below Ben's comments about this.

I am really wondering your opinion about this fix. Why should handle only by Ben? This is obvious bug fix if you think so, you can handle it too.

Quoted 78 lines
Quoted 37 lines

Thanks,

Darius.

Quoted 32 lines · Kukjin Kim
Quoted 8 lines · Joonyoung Shim
Quoted 6 lines · Paulius Zaleckas
Quoted 4 lines · Kyungmin Park

Hi,

It's already posted by Mr. Shim
http://marc.info/?l=linux-arm-kernel&m=127410047306149&w=2

Quoted 7 lines
Quoted 2 lines

Darius patch is a little bit cleaner.

OK, it's better.

Acked-by Joonyoung Shim<[email protected]>

Hi all,

I think, this should be handled by Ben Dooks.... As Kyungmin Park said, there was his comment about this.

This is just for your information....

===

Quoted 5 lines · Joonyoung Shim
Quoted 4 lines · Ben Dooks
Quoted 1 line · Joonyoung Shim

Thd dev_name and driver_name should be switched each other.

Hmm, this doesn't seem to have appeard on the linux-arm-kernel list

yet.

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 4 lines

Please provide some information about what problem that this is fixing and the impact on any existing systems.

Quoted 8 lines
Quoted 8 lines
Quoted 2 lines

The serial device nodes are created to s3c2410_serial* on android platform instead of ttySAC*.

This has been how they've been for ages, surely the android device node
creation sytstem supports symlinking /dev/SACx -> /dev/s3c2410_serialx,
like many other operating sysyerms that can already do this.

Changing this just because android (something as-yet unmerged into

mainline)

Quoted 3 lines
Quoted 3 lines

does not like it. I'm not even happy with an #ifdef around this.

If you really feel this is a problem that you absolutely must fix in

kernel

Quoted 1 line
Quoted 1 line

then please provide a kernel commandline option to change the serial

driver

Quoted 2 lines
Quoted 2 lines

name and use that on any platform that needs it. Another way would be to update the serial platform data to have a field for which name to

choose.

Quoted 1 line
Quoted 1 line

Thanks.

Best regards,
Kgene.
--
Kukjin Kim<[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

author
#12 lore raw

PATCH 1/1 serial: samsung: fix device name

In reply to Kukjin Kim
Quoted 4 lines · Kukjin Kim
Quoted 3 lines · Darius Augulis

Hi Kukjin,

Quoted 8 lines

Hi ;-)

Quoted 2 lines

please pick up this one to your tree too.

As I still thinking, this should be handled by Ben Dooks.

And please refer to below Ben's comments about this.

there isn't anything to handle. it's few lines patch, we type more lines to discuss it.
this patch hangs there for almost half year. we waste time.

Quoted 74 lines
Quoted 38 lines

Thanks,

Darius.

Quoted 32 lines · Kukjin Kim
Quoted 8 lines · Joonyoung Shim
Quoted 6 lines · Paulius Zaleckas
Quoted 4 lines · Kyungmin Park

Hi,

It's already posted by Mr. Shim
http://marc.info/?l=linux-arm-kernel&m=127410047306149&w=2

Quoted 7 lines
Quoted 2 lines

Darius patch is a little bit cleaner.

OK, it's better.

Acked-by Joonyoung Shim<[email protected]>

Hi all,

I think, this should be handled by Ben Dooks.... As Kyungmin Park said, there was his comment about this.

This is just for your information....

===

Quoted 5 lines · Joonyoung Shim
Quoted 4 lines · Ben Dooks
Quoted 1 line · Joonyoung Shim

Thd dev_name and driver_name should be switched each other.

Hmm, this doesn't seem to have appeard on the linux-arm-kernel list

yet.

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 4 lines

Please provide some information about what problem that this is fixing and the impact on any existing systems.

Quoted 8 lines
Quoted 8 lines
Quoted 2 lines

The serial device nodes are created to s3c2410_serial* on android platform instead of ttySAC*.

This has been how they've been for ages, surely the android device node creation sytstem supports symlinking /dev/SACx -> ?/dev/s3c2410_serialx, like many other operating sysyerms that can already do this.

Changing this just because android (something as-yet unmerged into

mainline)

Quoted 3 lines
Quoted 3 lines

does not like it. I'm not even happy with an #ifdef around this.

If you really feel this is a problem that you absolutely must fix in

kernel

Quoted 1 line
Quoted 1 line

then please provide a kernel commandline option to change the serial

driver

Quoted 2 lines
Quoted 2 lines

name and use that on any platform that needs it. Another way would be to update the serial platform data to have a field for which name to

choose.

Quoted 1 line
Quoted 1 line

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.