Skip to contentSkip to conversation

Bluetooth: HCI devices are either BR/EDR or AMP radios

PATCH In review David Vrabel 2 participants 2 messages Aug 9, 2010

Subsystems (2)
Bluetooth drivers Bluetooth
lore
Share & tools
lore

David Vrabel

author
#0 lore raw

PATCH 1/1 Bluetooth: HCI devices are either BR/EDR or AMP radios

HCI transport drivers may not know what type of radio an AMP device has so only say whether they're BR/EDR or AMP devices.

Signed-off-by David Vrabel <[email protected]>
---
 include/net/bluetooth/hci.h |    2 +-
 net/bluetooth/hci_sysfs.c   |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
include/net/bluetooth/hci.h +1 -1
index ca2518e..cc14731 100644
@@ -54,7 +54,7 @@
 
 /* HCI controller types */
 #define HCI_BREDR	0x00
-#define HCI_80211	0x01
+#define HCI_AMP		0x01
 
 /* HCI device quirks */
 enum {
net/bluetooth/hci_sysfs.c +2 -2
index ce44c47..4e9ca9b 100644
@@ -196,8 +196,8 @@ static inline char *host_typetostr(int type)
 	switch (type) {
 	case HCI_BREDR:
 		return "BR/EDR";
-	case HCI_80211:
-		return "802.11";
+	case HCI_AMP:
+		return "AMP";
 	default:
 		return "UNKNOWN";
 	}
Signature · 8 lines
1.5.4.3
-- 
David Vrabel, Senior Software Engineer, Drivers
CSR, Churchill House, Cambridge Business Park,  Tel: +44 (0)1223 692562
Cowley Road, Cambridge, CB4 0WZ                 http://www.csr.com/


Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
maintainer
#1 lore raw

Hi David,

Quoted 8 lines

HCI transport drivers may not know what type of radio an AMP device has so only say whether they're BR/EDR or AMP devices.

Signed-off-by David Vrabel <[email protected]>
---
  include/net/bluetooth/hci.h |    2 +-
  net/bluetooth/hci_sysfs.c   |    4 ++--
  2 files changed, 3 insertions(+), 3 deletions(-)

a little bit different version that also fixes the Marvell driver has been applied to my tree. Thanks.

Regards

Marcel