Skip to contentSkip to conversation

ARM: S3C2410: Fix on build warning about dependency in mach-s3c2440/Kconfig

PATCH New Kukjin Kim 2 participants 2 messages Aug 13, 2010 – Aug 14, 2010

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm Samsung Exynos
lore
Share & tools
lore

Kukjin Kim

author
#0 lore raw

PATCH v2 1/1 ARM: S3C2410: Fix on build warning about dependency in mach-s3c2440/Kconfig

This patch fixes on following build warnings.

warning: (CPU_S3C2440 && ARCH_S3C2410 && S3C2410_DMA) selects S3C2440_DMA which

             has unmet direct dependencies (ARCH_S3C2410 && CPU_S3C24405B)

warning: (CPU_S3C2440 && ARCH_S3C2410 || CPU_S3C2442 && ARCH_S3C2410) selects
CPU_S3C244X which has unmet direct dependencies (!ARCH_S3C2410)

Signed-off-by Kukjin Kim <[email protected]>
Cc Ben Dooks <[email protected]>

---
Changes since v1:
- Address comments from Uwe :-)

Thanks
Kgene.

 arch/arm/mach-s3c2440/Kconfig |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-s3c2440/Kconfig +2 -2
index cd8e7de..f60a370 100644
@@ -30,7 +30,7 @@ config CPU_S3C2442
 
 config CPU_S3C244X
 	bool
-	depends on ARCH_S3C2410 && (CPU_S3C2440 || CPU_S3C2442)
+	depends on CPU_S3C2440 || CPU_S3C2442
 	help
 	  Support for S3C2440 and S3C2442 Samsung Mobile CPU based systems.
 

@@ -72,7 +72,7 @@ config S3C2440_PLL_16934400
 
 config S3C2440_DMA
 	bool
-	depends on ARCH_S3C2410 && CPU_S3C24405B
+	depends on ARCH_S3C2410 || CPU_S3C24405B
 	help
 	  Support for S3C2440 specific DMA code5A
Signature · 1 line
1.6.2.5
#1 lore raw

PATCH v2 1/1 ARM: S3C2410: Fix on build warning about dependency in mach-s3c2440/Kconfig

Quoted 33 lines · Kukjin Kim

This patch fixes on following build warnings.

warning: (CPU_S3C2440 && ARCH_S3C2410 && S3C2410_DMA) selects S3C2440_DMA which

             has unmet direct dependencies (ARCH_S3C2410 && CPU_S3C24405B)

warning: (CPU_S3C2440 && ARCH_S3C2410 || CPU_S3C2442 && ARCH_S3C2410) selects
CPU_S3C244X which has unmet direct dependencies (!ARCH_S3C2410)

Signed-off-by Kukjin Kim <[email protected]>
Cc Ben Dooks <[email protected]>

---
Changes since v1:
- Address comments from Uwe :-)

Thanks
Kgene.

 arch/arm/mach-s3c2440/Kconfig |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-s3c2440/Kconfig +1 -1
index cd8e7de..f60a370 100644
@@ -30,7 +30,7 @@ config CPU_S3C2442
 
 config CPU_S3C244X
 	bool
-	depends on ARCH_S3C2410 && (CPU_S3C2440 || CPU_S3C2442)
+	depends on CPU_S3C2440 || CPU_S3C2442
 	help
 	  Support for S3C2440 and S3C2442 Samsung Mobile CPU based systems.

arch/arm/mach-s3c2440/Kconfig config S3C2440_PLL_16934400 · line 75

Quoted 5 lines
arch/arm/mach-s3c2440/Kconfig +1 -1
@@ -72,7 +72,7 @@ config S3C2440_PLL_16934400
 
 config S3C2440_DMA
 	bool
-	depends on ARCH_S3C2410 && CPU_S3C24405B
+	depends on ARCH_S3C2410 || CPU_S3C24405B

Hmm, i think it should be CPU_S3C2440, not sure what happened to that line

Quoted 3 lines
arch/arm/mach-s3c2440/Kconfig +0 -0
 	help
 	  Support for S3C2440 specific DMA code5A